Fixes #91#95
Open
thargy wants to merge 1 commit into
Open
Conversation
…essful compilation via SharpDX. Further, it will fall back to trying to use FXC is SharpDX fails. Also, centralises logic for Process execution to make consistent and robust. Cleaned up error messages for consistency, and changed logic to prevent duplicate and unecessary process execution on some platforms (so should improve execution speed).
Contributor
Author
|
Don't believe the CI fail is related to the changes. |
I can test on Mac, not exactly sure what I need to do though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures path of
hlsl.bytesfile is returned on successful compilation via SharpDX. Further, it will fall back to trying to use FXC is SharpDX fails.Also, centralizes logic for Process execution to make consistent and robust. Cleaned up error messages for consistency, and changed logic to prevent duplicate and unnecessary process execution on some platforms (so should improve execution speed).
NOTE: Have not been able to test on Mac as I don't have.