Skip to content

docs: name the required check CI Status - #247

Merged
kyle-sexton merged 1 commit into
mainfrom
docs/ci-status-check-text
Nov 14, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
docs/ci-status-check-text

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: text follow-up to the ci-status mirror removal (#245).

Summary

CONTRIBUTING.md and the pull request template still named the required check ci-status. The org ruleset requires CI Status.

Fix

  • CONTRIBUTING.md:18 and .github/PULL_REQUEST_TEMPLATE.md:17: one name each.

Verification

  • git diff shows two one-word changes.

Related

🤖 Generated with Claude Code

CONTRIBUTING.md and the pull request template still named the required
check `ci-status`. The org ruleset requires `CI Status`.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T01:24:42.627205Z bae564f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed bae564f18c1e399e0e98f7f66bf666a654518717: 0 finding(s), 0 as inline comments.

Security review: PR #247 (head bae564f)

No security findings.

The diff touches two documentation files and changes one string in each. ci-status becomes CI Status in .github/PULL_REQUEST_TEMPLATE.md and in CONTRIBUTING.md. Both describe the required check by name.

  • No workflow, action, script, manifest, trusted-actor list, CODEOWNERS, .gitmodules or token-scope file changed.
  • No trust control or merge hold is widened, weakened or removed.
  • No standing instruction (CLAUDE.md, a rules file, a skill or agent body) is deleted, narrowed or softened. The edits only rename the check in prose.
  • The template says the contract step is advisory and that the step's output is authoritative over the comment. The edit keeps both statements.

I did not check whether the check's actual name in the workflow or the ruleset matches CI Status. That is a docs-accuracy question, not a security one.

critical-findings: 0

@github-actions

Copy link
Copy Markdown

claude-review reviewed bae564f18c1e399e0e98f7f66bf666a654518717: 0 finding(s), 0 as inline comments.

No findings. The PR is two one-word documentation edits that change ci-status to CI Status, in CONTRIBUTING.md:18 and .github/PULL_REQUEST_TEMPLATE.md:17.

I read the diff and the PR context, and grepped the repo. .github/workflows/pr-require-checks.yml:73 says the job ci-status aggregates into the single CI Status check, and README.md:33 and CLAUDE.md:31 use the same name. So the new text matches the required-check name. The two edits are the only places in the user-facing contributor docs that still used the old name for the required check.

Other ci-status mentions remain in README.md, REVIEW.md, AGENTS.md, docs/standards/issue-tracker.md and .claude/rules/pr-body-contract.md. Each one points to the job ID or to a step inside that job, so none is stale. The template's "check-contract step inside CI Status" wording now differs slightly from README.md:35, which says "inside the ci-status job". Both read correctly, and I did not count this as a finding.

The PR has no closing issue; its body uses "No related issue: ", so there are no acceptance criteria to check. The body has the Summary, Fix, Verification and Related sections. The title follows Conventional Commits. No manifests, path-scoped rules or paved-path rows apply. The verification line in the PR body is the author's claim; I did not run anything beyond reading and grepping.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton merged commit b8bb639 into main Nov 14, 2026
17 checks passed
@kyle-sexton
kyle-sexton deleted the docs/ci-status-check-text branch November 14, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant