Repository navigation
ci: move ci-status onto the shared report-ci-status composite - #271
Conversation
The contract check and lane aggregation become one report-ci-status step pinned at ci-workflows v0.76.0, with a step that fails the job on the contract or draft output. The draft policy stays allow, and treat-skipped-as is now set to pass explicitly: the old aggregate-results step left it at that action's default, pass, while the composite's default is fail. The job keeps if: always(). Concurrency already falls back to github.run_id. pr-section-drift read the check-contract pin from this workflow; it now also accepts the report-ci-status pin, since that composite runs check-contract at the commit it is pinned to. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed Code review: PR #271 (ci-status onto
|
|
claude-security-review reviewed Security review: PR #271Result: no security findings. Scope. The PR touches three files. Trust-control read,
Not verified. Whether
Owner threat model. No named friction hold is weakened, and no token scope, secret, trusted actor or billing surface changes. Instruction-surface and manifests. No instruction files or plugin manifests changed. |
No related issue: a rollout step of melodic-software/ci-workflows#1138, which stays open until every repository has migrated.
Summary
Rollout of ci-workflows#1138: the
ci-statusjob now runs the sharedreport-ci-statuscomposite (ci-workflows#1139, v0.76.0) instead of its owncheck-contractandaggregate-resultssteps.CI Statusstays the job's name and the single required check. Worked examples copied: songwriting#75 and codex-plugins#208.Fix
ci-statussteps: onereport-ci-statusstep, then a "Fail on the contract or draft policy" step that fails on any outcome other thansuccess, so an empty or renamed output fails closed. The composite step keeps the nameAggregate lane results, so a contract-only run still finds the writer step of a full run recorded before this change.draft: allow: the job had no draft refusal and the workflow has noready_for_reviewtrigger.treat-skipped-as: pass, now explicit. The oldaggregate-resultsstep set nothing and so ran on that action's default,pass(aggregate-results action.yml at v0.75.0); the composite's default isfail.if: always(),needs, permissions, runner and timeout are unchanged. No exempt authors, as before.github.run_id.yield-to-full-run: 'true',carry-forward-wait-seconds: '0', action.yml L128-L129) instead of inputs the file no longer sets..github/scripts/pr-section-drift.mjsread thecheck-contract@<sha>pin from this workflow and would have failed theCheck PR Sectionslane with no such pin. It now also accepts thereport-ci-status@<sha>pin, since that composite runscheck-contractthrough$/at its own commit, and fetchescheck-contract/run.shat that SHA as before. Two cases added to its test.git diff --numstat): workflow 32 removed, 42 added;pr-section-drift.mjs5 removed, 11 added; its test 14 added.Verification
actionlint .github/workflows/pr-require-checks.yml: no findings.node --test .github/scripts/pr-section-drift.test.mjs: 29 passed.node .github/scripts/pr-section-drift.mjson this branch: "local mirrors match melodic-software/ci-workflows@ebd0e3b section_report calls [Summary, Fix, Verification, Related]".Related
🤖 Generated with Claude Code
https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C