Skip to content

fix(cursor): match install.sh tool pins to CI - #274

Merged
kyle-sexton merged 1 commit into
mainfrom
fix/cursor-install-tool-pins
Nov 19, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
fix/cursor-install-tool-pins

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: install.sh tool pins drifted behind the CI action defaults.

Summary

.cursor/environment.json runs .cursor/install.sh to give Cursor cloud agents the same hygiene toolchain CI uses. CI in this repository calls the melodic-software/ci-workflows actions at ebd0e3bed99ae1365fcb4ef47ce97cfa745fcf2f (v0.76.0) with no version overrides, but five of the eight tool pins in install.sh were behind those actions' defaults, and actionlint was downloaded from rhysd/actionlint releases while CI installs the kjanat/actionlint fork. A local .cursor/check.sh run could therefore disagree with CI.

Fix

Every version, URL and SHA-256 below is copied from the action files at that commit (typos/action.yml:46,51; editorconfig-checker/action.yml:35,40,57; actionlint/action.yml:25,67):

  • Header authority: v0.29.1 -> v0.76.0.
  • markdownlint-cli2: 0.23.2 -> 0.23.3.
  • typos: 1.50.1 -> 1.50.3, new SHA-256.
  • editorconfig-checker: 3.11.2 -> 4.0.2, new SHA-256; the release asset is now editorconfig-checker-linux-amd64.tar.gz with member editorconfig-checker. It is still installed as ec (install_release ec ... installs the member as $BIN_DIR/ec), which is what .cursor/check.sh calls.
  • actionlint: rhysd/actionlint 1.7.12 -> kjanat/actionlint 1.17.0, new URL and SHA-256.
  • check-jsonschema: 0.38.0 -> 0.38.2.

gitleaks, lychee and shellcheck already matched and are unchanged.

Verification

  • bash -n .cursor/install.sh: exit 0.
  • shellcheck .cursor/install.sh: exit 0, no findings.
  • bash .cursor/install-prefix.test.sh: printed ok.
  • The typos, editorconfig-checker and actionlint tarballs were downloaded from the new URLs: sha256sum matches each pin, and tar -tzf lists the member each install_release call extracts (./typos, editorconfig-checker, actionlint).
  • An earlier check got HTTP 200 from the five changed download URLs; it was not re-run here.
  • No install was run: the binaries were not executed, and the npm and PyPI version bumps were not installed.

Not in this change

Nothing in this repository checks install.sh against the CI pins, so it can drift again. An earlier check reported that the standards repository guards its own copy with .cursor/install.test.sh; adding such a check here is not part of this change.

Related

No related issues or PRs.

🤖 Generated with Claude Code

CI runs the ci-workflows actions at ebd0e3b (v0.76.0); install.sh still
pinned the v0.29.1 defaults. Copy each action's version, asset URL,
archive member and SHA-256:

- markdownlint-cli2 0.23.2 -> 0.23.3
- typos 1.50.1 -> 1.50.3
- editorconfig-checker 3.11.2 -> 4.0.2 (asset ec-linux-amd64.tar.gz ->
  editorconfig-checker-linux-amd64.tar.gz)
- actionlint rhysd 1.7.12 -> kjanat fork 1.17.0
- check-jsonschema 0.38.0 -> 0.38.2

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 19, 2026 08:56
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T08:57:51.676980Z 7ae6941 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-review reviewed 7ae6941cfd8fec2aaa0c3a9e3c991a8af1a48e53: 0 finding(s), 0 as inline comments.

Review of #274: match .cursor/install.sh tool pins to CI

No findings reported.

What I checked (read the files myself):

  • install_ec now fetches editorconfig-checker-linux-amd64.tar.gz and extracts the member editorconfig-checker. install_release ec ... then installs $WORK/editorconfig-checker as $BIN_DIR/ec. .cursor/check.sh:147 calls ec, so the installed name still matches. The ensure editorconfig-checker ... ec --version check also still matches.
  • The install_actionlint URL change is consistent with the unchanged actionlint actionlint member arguments and the ensure actionlint ... actionlint --version check.
  • The CI workflow .github/workflows/pr-require-checks.yml pins the ci-workflows actions at ebd0e3b... (v0.76.0). That matches the new header authority line.
  • gitleaks, lychee and shellcheck are unchanged, as the PR states.

Not verified by me (author-claimed):

  • That the new versions and SHA-256 values equal the defaults in the ci-workflows action files. I could not read those files here.
  • That the new tarballs download, hash correctly and contain the stated members. I did not download or run anything.
  • That kjanat/actionlint 1.17.0 prints a version string containing 1.17.0 for actionlint --version. If it did not, ensure would reinstall on every run, though the install itself would still succeed.

No closing issue is linked ("No related issue" is stated). The path-scoped rule .claude/rules/pr-body-contract.md covers PR bodies. The body follows it: it has No related issue: plus Summary, Fix, Verification and Related sections.

Loosened-check verdict: not provided by the wrapper, so fail with no consumer entries was assumed. Nothing in the diff loosens a check.

Verifier dropped 0 of 0 candidates.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 7ae6941cfd8fec2aaa0c3a9e3c991a8af1a48e53: 0 finding(s), 0 as inline comments.

Security review: PR #274 (head 7ae6941)

No security findings. critical-findings: 0

Scope. One file changed: .cursor/install.sh. It is the local toolchain installer for developer and Cloud Agent workstations. It is not a CI workflow, a trusted-path file, a token or kill-switch control, a merge hold, or a plugin manifest, so none of the trust-control or manifest rules apply.

What the diff does.

  • Bumps the pins for markdownlint-cli2, typos, editorconfig-checker, actionlint and check-jsonschema.
  • Updates the editorconfig-checker asset name and tar member for v4.
  • Moves the actionlint download from rhysd/actionlint to kjanat/actionlint.

The actionlint source change.

  • The move to a third-party fork is the one item that looked risky, because a different publisher is now the download source.
  • The repo's own records say this is what CI already installs: .claude/ecosystems/yaml.yaml:29 ("the fork and release CI's actionlint composite installs") and .claude/ecosystems/cross-cutting.yaml:40.
  • The download still goes through install_release. That function uses HTTPS only (--proto '=https') and aborts on any SHA-256 mismatch (verify_sha, .cursor/install.sh:101-110, called at line 127). The hash is pinned in the script, so the fork cannot swap the artifact after the pin without the install failing.
  • The pin values come from ci-workflows v0.76.0, which this PR names as its authority. That repo is the trust root for the pins and is outside this PR.
  • The trust decision to use the fork was made upstream. The PR only aligns the local installer with CI, and the installer runs on a developer workstation, not in a credentialed CI lane. This is not a finding.

Pin checks.

  • Every new SHA-256 is 64 hex characters, so none is truncated or malformed. I confirmed this for the typos hash.
  • I could not compare the new hashes against ci-workflows v0.76.0, because the gh api call needed approval and did not run. A wrong hash fails closed with a hard install error rather than installing an unverified binary.

Dropped as out of scope. The version-bump and drift concerns are quality items, not security items. Action pin hygiene is zizmor's lane.

@kyle-sexton
kyle-sexton merged commit 1923187 into main Nov 19, 2026
19 checks passed
@kyle-sexton
kyle-sexton deleted the fix/cursor-install-tool-pins branch November 19, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant