Skip to content

chore(ci): remove superseded pr-automerge-dependabot.yml - #285

Merged
kyle-sexton merged 1 commit into
mainfrom
chore/remove-legacy-dependabot-automerge
Nov 21, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
chore/remove-legacy-dependabot-automerge

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Refs: melodic-software/control-hub#17

Summary

Removes the superseded hand-maintained .github/workflows/pr-automerge-dependabot.yml now that standards-sync (melodic-software/standards#1089) manages .github/workflows/pr-automerge-dependabot-hosted.yml for this public repository.

Fix

  • Deleted .github/workflows/pr-automerge-dependabot.yml so only the sync-managed .github/workflows/pr-automerge-dependabot-hosted.yml runs on pull requests.

Verification

  • Confirmed .github/workflows/pr-automerge-dependabot-hosted.yml is present on main and invokes melodic-software/ci-workflows/.github/workflows/pr-automerge-dependabot.yml@main on ubuntu-24.04.
  • CI checks run on this PR.

Related

  • melodic-software/control-hub#17 (Row 5)
  • melodic-software/standards#1089

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T22:14:46.219033Z 3a7edcc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 3a7edccc18bc23a90bc778a7d4d3e4cee51977d6: read 0 of 0 changed file(s); 0 finding(s), 0 as inline comments.

Security review: PR #285

No security issues found.

The pull request deletes one file, .github/workflows/pr-automerge-dependabot.yml, a caller workflow. The diff's file list is empty because the file is deleted whole, so the count of files read is 0. I still read the full deletion hunk (lines 1–39 of the diff).

What I checked:

  • The replacement is already in place. The sync-managed .github/workflows/pr-automerge-dependabot-hosted.yml is present at head. It has the same on: pull_request, the same top-level permissions: {}, and the same job-level contents: write / pull-requests: write. It calls the same reusable workflow, melodic-software/ci-workflows/.github/workflows/pr-automerge-dependabot.yml@main, with runner: ubuntu-24.04 and the same job name, PR Automerge Dependabot. Removing the duplicate caller only stops the auto-merge arming job from running twice on each pull request. It takes away nothing that the remaining caller still provides.
  • Trust controls. The deleted file is not under .github/actions/. It is not one of the merge-hold scripts or steps and not a trusted-actor, CODEOWNERS or .gitmodules path. It touches no token broker or kill-switch path. Deleting it widens no token scope, admits no new actor and lets no extra untrusted text reach a lane.
  • Dangling references. Nothing in the tree still references the deleted file by path. The comment in .github/dependabot.yml (line 5) names the reusable workflow in ci-workflows, not this caller. The surviving caller keeps the same job name, so any check that matches on the job name still sees it.
  • Instruction surface and manifests. The pull request deletes no standing instruction and touches no plugin manifest.

critical-findings: 0

@github-actions

Copy link
Copy Markdown

claude-review reviewed 3a7edccc18bc23a90bc778a7d4d3e4cee51977d6: read 0 of 0 changed file(s); 0 finding(s), 0 as inline comments.

Code review: no findings

This PR deletes one file, .github/workflows/pr-automerge-dependabot.yml. Its whole section in the diff (all 32 removed lines) was read. The changed-files list is empty because the only change is a whole-file deletion, so files_read is 0.

What I checked against the head tree

  • The replacement exists and does the same thing. .github/workflows/pr-automerge-dependabot-hosted.yml has the same pull_request trigger, the same permissions: {} default and the same concurrency group. Its job is also called pr-automerge-dependabot with the name PR Automerge Dependabot, it has the same contents: write / pull-requests: write grant, and it calls the same reusable workflow (melodic-software/ci-workflows/.github/workflows/pr-automerge-dependabot.yml@main) with runner: ubuntu-24.04.
  • Check-run names stay the same. A reusable-workflow check is named <caller job name> / <called job name>, and the caller job name is the same in both files. A required-check rule that matches on that name still finds it.
  • Removing the old file also stops two identical auto-merge-arming runs from starting on every pull request.
  • Nothing else in the repository references the deleted path. The pr-automerge-dependabot.yml in .github/dependabot.yml names the ci-workflows reusable workflow, which still exists, so that comment is still accurate.
  • The PR's verification bullets are author-claimed and I did not verify them. I confirmed the hosted caller's contents only by reading the file at this head.

Closing issue: the PR context lists no Closing issue section (the body only says Refs: melodic-software/control-hub#17), so there are no acceptance criteria to check.

Loosened checks: I applied the criterion to the deletion and found no loosening. The deleted workflow arms auto-merge; it is not a gate that accepts or rejects a change, and an identical caller is still in place, so no check is removed or relaxed. The prompt had no loosened_check_verdict:, loosened_check_patterns: or loosened_check_decision_record: lines, so I used fail with no consumer patterns and did not check the citation requirement.
Loosened checks would be marked: fail (plugin default); patterns: 0

Prior findings: this lane has not reviewed an earlier head and the review is not blocking-only, so no prior findings applied.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton merged commit a854c6e into main Nov 21, 2026
29 checks passed
@kyle-sexton
kyle-sexton deleted the chore/remove-legacy-dependabot-automerge branch November 21, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant