Skip to content

ci: show the gate as CI Status and mirror it as ci-status - #131

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/ci-status-alias
Nov 12, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/ci-status-alias

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: owner decision D3 (rename the required gate to CI Status), step A for this repository.

Summary

The ci-status job now displays as CI Status. A new report-ci-status job, named ci-status, reports its conclusion under the old name. Until the ci-gate org ruleset requires CI Status, both contexts are on every head.

Fix

Verification

  • actionlint is clean.
  • This PR's own checks report both CI Status and ci-status.

Related

🤖 Generated with Claude Code

https://claude.ai/code/session_01VQb9Q2ceZLXhTR4d1vkTCe

The ci-status job displays as `CI Status`, and a new report-ci-status
job reports its conclusion under the old name `ci-status`, the context
the ci-gate org ruleset requires today. aggregate-results moves to the
ci-workflows commit with the alias-jobs input and names the mirror, so
contract-only runs still read as contract-only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VQb9Q2ceZLXhTR4d1vkTCe
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T06:09:37.364969Z 5c98f6a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kyle-sexton
kyle-sexton enabled auto-merge (squash) November 12, 2026 06:08
@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 5c98f6aa00fea0dccc31ee3115095e03144b2aa3: 0 finding(s), 0 as inline comments.

Security review: no findings

critical-findings: 0

Scope: one file, .github/workflows/pr-require-checks.yml. This is not a prose-only change, because it touches the required-check gate (ci-status). I read the whole diff and the ci-status job it gates.

  • Gate rename and mirror job. The aggregate job is now named CI Status. A new job, report-ci-status, is named ci-status and mirrors it. The mirror runs with permissions: {} and if: always(). It reads needs.ci-status.result through env:, not by interpolating into the script, so there is no expression injection. It exits non-zero unless the result is exactly success. A failed, cancelled or skipped aggregate therefore produces a red ci-status, so the required check fails closed. No path turns a red aggregate into a green ci-status. The gate does not weaken.
  • Pin bump of aggregate-results. The uses: pin moves from v0.39.8 (594987a…) to ac4d878…, which is a SHA pin with a date comment. It is still a full-SHA pin on the org's own ci-workflows repo, and token: ${{ github.token }} is unchanged. Pin and repin changes are zizmor's lane and one of the owner's named friction holds, so I raised no finding. Two things I could not check: I could not read ac4d878 in ci-workflows, so I did not confirm that it is on that repo's default branch or that the alias-jobs input exists there, and I did not check what the new action version does. Neither was in scope for this diff. The new alias-jobs: ci-status input only tells the run-shape reads to ignore the mirror job.
  • Manifests, trusted paths, instruction surface. No plugin manifest changed. No trusted-path, kill-switch or token-broker file changed. No standing instruction was deleted or softened.
  • Prior and settled threads. None were supplied.

@github-actions

Copy link
Copy Markdown

claude-review reviewed 5c98f6aa00fea0dccc31ee3115095e03144b2aa3: 0 finding(s), 0 as inline comments.

No findings. I read the full diff, which touches only .github/workflows/pr-require-checks.yml, and the surrounding workflow.

  • The ci-status job now has name: CI Status, and its job id is unchanged. report-ci-status is named ci-status, needs the gate job, and runs under always(). It fails unless the gate's result is success, so a skipped, failed or cancelled gate shows red under the old name. permissions: {} is right for a step that only reads a needs result.
  • The aggregate-results pin moves from v0.39.8 to ac4d878 and adds alias-jobs: ci-status. The comment says the mirror job runs on contract-only events too, so the run-shape reads need to ignore it. I did not check that SHA or the alias-jobs input against ci-workflows, because the remote lookup was not run. The alias-jobs behaviour and the claim that the new inputs default to the old behaviour rest on the PR text and the linked ci-workflows#1072. The other check-contract and lychee-offline pins stay on v0.39.8, so the repository now mixes two action versions. The PR says this is intentional.
  • The remaining ci-status mentions are in comments (pr-automerge-dependabot.yml, dependabot.yml, pr-check-managed-files-hosted.yml) and REVIEW.md. They still name a context that exists, because the mirror keeps the old name on every head during the transition.
  • The PR body follows the required shape: it opens with the "No related issue:" escape and has non-empty Summary, Fix, Verification and Related sections. The PR context file names no closing issue, so there are no acceptance criteria to check. The "actionlint is clean" claim and the claim that this PR's own checks report both contexts are author-claimed and not independently verified.
  • No plugin manifests changed, so there are no manifest lines to report.
  • The change is pure CI configuration with no security surface.

@kyle-sexton
kyle-sexton merged commit 9f23add into main Nov 12, 2026
9 checks passed
@kyle-sexton
kyle-sexton deleted the ci/ci-status-alias branch November 12, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant