Skip to content

ci: remove the ci-status mirror job now that CI Status is required - #133

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/remove-ci-status-mirror
Nov 13, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/remove-ci-status-mirror

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: step C of the owner-approved ci-status to CI Status required-check rename (owner decision "go w/ recommendations": remove the mirror jobs after a day of merges under the new requirement).

Summary

The org ci-gate ruleset has required CI Status since 2026-11-12T17:07Z. This removes the report-ci-status mirror job, which repeated the gate's conclusion under the old check name ci-status, and the alias-jobs: ci-status input that made the aggregate ignore it. Text that named ci-status as the required check now names CI Status.

Fix

  • .github/workflows/pr-require-checks.yml: the report-ci-status job and the alias-jobs: ci-status input with its comment are removed. The header comment says job ci-status, displayed CI Status, is the required check (it said "one of the four required contexts"), and the concurrency note names the CI Status check run. The job key ci-status is unchanged.
  • AGENTS.md: CI Status is the single required check.
  • .github/dependabot.yml and .github/workflows/pr-automerge-dependabot.yml: the comments name CI Status.

Verification

  • actionlint on both edited workflows: no findings.
  • alias-jobs is optional in the pinned aggregate-results (ac4d878): default: ''.
  • No test or script in this repository references report-ci-status, alias-jobs or the job list (git grep).

Related

Follow-ups

Managed by the standards sync; they need a melodic-software/standards change:

  • Pre-existing (advisory): REVIEW.md:89,91 (component review-instructions) name ci-status as the check a Dependabot pull request merges on.
  • Pre-existing (advisory): .github/workflows/pr-check-managed-files-hosted.yml:21 (component managed-files-guard-caller) says the check is not aggregated into ci-status; it should name CI Status.

🤖 Generated with Claude Code

https://claude.ai/code/session_01RMa43ySvw2yzRFMu7Kekcu

The org ci-gate ruleset has required `CI Status` since
2026-11-12T17:07Z. Remove the `report-ci-status` job, which repeated the
gate's conclusion under the old name `ci-status`, and the
`alias-jobs: ci-status` input that made the aggregate ignore it. Comments
and AGENTS.md that named `ci-status` as the required check now name
`CI Status`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RMa43ySvw2yzRFMu7Kekcu
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T20:41:09.964223Z 4d1bd81 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 4d1bd81e1d1d6f6ee009221a98b405a7dad5d500: 0 finding(s), 0 as inline comments.

No security findings in PR #133 at 4d1bd81.

I read the whole 4-file diff. Most of it is comment and doc renames from ci-status to CI Status in .github/dependabot.yml, .github/workflows/pr-automerge-dependabot.yml and AGENTS.md.

The one change that touches a trust control is in .github/workflows/pr-require-checks.yml, a ci-status hold-step file. I read its whole change and what it gates:

  • Removed report-ci-status job. It only echoed the CI Status result and failed unless it was success, with permissions: {}. It was a mirror, not a gate. The real ci-status job (name: CI Status) is unchanged and still carries needs: [check-scripts-and-manifests, lychee] and if: ${{ !cancelled() }}. It also still runs check-contract and aggregate-results with treat-skipped-as: fail, yield-to-full-run and rerun-contract-only-siblings.
  • Removed alias-jobs: ci-status input. It existed only so the run-shape reads would ignore the mirror job. The mirror no longer exists, and a grep finds no remaining references to alias-jobs or report-ci-status in the repository.
  • No widening. Neither removal widens who is trusted, what a token may do, or what the merge gate lets through. The job's permissions: block is unchanged, and the pinned action SHAs are unchanged.
  • Outside the diff. Whether the org ruleset's required-check context now matches CI Status is a ruleset setting, not code in this PR. The commit message says it is already required.

No instruction-surface deletion: the AGENTS.md change is a rename only, and no rule is removed or softened. No plugin manifests changed. The PR context, settled-threads and prior-findings files were not supplied, so nothing was dropped as settled or already posted.

critical-findings: 0

@github-actions

Copy link
Copy Markdown

claude-review reviewed 4d1bd81e1d1d6f6ee009221a98b405a7dad5d500: 0 finding(s), 0 as inline comments.

No findings. I read the full diff and the PR context, and I checked the rest of the repo for leftover references to the removed pieces. I ran no actionlint or workflow execution myself, so the PR's actionlint and alias-jobs default claims are author-claimed and unverified.

What I checked

  • Removed job: Removing report-ci-status and the alias-jobs: ci-status input is consistent. alias-jobs existed only so the aggregate would ignore the mirror job, and that job is gone. Nothing else in the repo references report-ci-status or alias-jobs.
  • Remaining job: The remaining ci-status job (key ci-status, name: CI Status) is unchanged in needs, if, permissions and the aggregate-results inputs, so the required check keeps reporting under the name the ruleset requires.
  • Comment and doc edits: These match the job's display name. The ci-status mentions that remain inside pr-require-checks.yml (lines 20, 23, 66, 123, 130, 135, 160) refer to the job key, which the PR says it keeps.
  • Closing issue: The PR uses the "No related issue:" escape, so there are no acceptance criteria to check.
  • Manifests: The diff changes no plugin manifests, so there are no manifest <field> lines.
  • Settled threads and prior findings: Neither file was supplied.

Pre-existing (advisory):

Both predate this change, and no changed line calls them.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton merged commit 6e2c360 into main Nov 13, 2026
8 checks passed
@kyle-sexton
kyle-sexton deleted the ci/remove-ci-status-mirror branch November 13, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant