Skip to content

fix: keep the local gitleaks scan in the cross-cutting record - #139

Merged
kyle-sexton merged 1 commit into
mainfrom
fix/ecosystem-records-restore-gitleaks
Nov 14, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
fix/ecosystem-records-restore-gitleaks

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Refs: melodic-software/claude-code-plugins#15725

Summary

Puts the local gitleaks secret scan back into .claude/ecosystems/cross-cutting.yaml. The record merged in #137 set no gitleaks command because no CI job here runs one, and that switched off the scan the bundled toolchain default would run for this repository. The owner had not approved removing a secret scan.

Fix

  • check-cmd gains gitleaks dir . --config .gitleaks.toml --no-banner --redact as its last check; it contributes to the status like every other line. No existing check changes.
  • The notes state the line as a deviation from CI: no CI job here runs gitleaks. The command, version (8.30.1) and checksum are those of the gitleaks composite at melodic-software/ci-workflows v0.39.8, which this repository does not call.
  • opt-in, install-hint and tool-pin name gitleaks.
  • One cite into pr-automerge-dependabot.yml was a line short; it is corrected.

Verification

  • The record validates against the ecosystem-commands schema.
  • gitleaks dir 8.30.1 over this branch's tree: no leaks found.
  • An independent review read every cite the change adds or moves, compared the record key by key with the version on main, and ran the command shape with stub tools: exit 0 when clean, exit 1 when gitleaks finds something, errors or is missing. READY, no blocking finding.
  • A probe in this worktree (a token-shaped line in a git-ignored file under .work/, since deleted) showed gitleaks dir also reads untracked and git-ignored files, as the notes say.

Remaining

Issue melodic-software/claude-code-plugins#15725 stays open after this pull request; its baseline steps and recorded /toolchain:check all output are still owed.

Whether a record should keep other bundled checks that CI does not run (typos, for example) is an open owner question; this pull request changes only the secret scan.

Related

session: GitHub Support

🤖 Generated with Claude Code

The cross-cutting record set no gitleaks command because no CI job here
runs one, which switched off the secret scan the bundled toolchain
default ran for this repository. Add the scan back as a stated deviation
from CI, with the command, version and checksum of the gitleaks composite
at ci-workflows v0.39.8, and correct one line cite that moved when the
job display names changed.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T15:33:05.015021Z 9cb525f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 9cb525ff4064d0f8c465cec36aea57aab5aacbb0: 0 finding(s), 0 as inline comments.

Security review: PR #139 (head 9cb525f)

No security findings.

The pull request changes only .claude/ecosystems/cross-cutting.yaml. It adds a local gitleaks secret-scan line to check-cmd, plus the matching opt-in, install-hint, tool-pin and notes text.

  • Command content: the added command is fixed: gitleaks dir . --config .gitleaks.toml --no-banner --redact || rc=1. It uses no interpolation and no <files> or other user-controlled input, so there is no injection surface.
  • Secrets handling: --redact keeps any detected secret out of the output. The change adds a secret scan to a lint step that had none, so it narrows nothing.
  • Pinned install: the install hint pins gitleaks 8.30.1 and a SHA-256 checksum for the linux_x64 archive. The pin and checksum are copied from the ci-workflows@594987a composite. The change installs and fetches nothing itself.
  • Trust controls: it touches no trusted-actor check, token scope, kill switch, merge hold or CODEOWNERS file. It adds no workflow, and no plugin or marketplace manifest, so no userConfig or manifest flags apply.
  • Instruction surface: it deletes no standing rule. The old notes text about gitleaks and typos is rewritten to say gitleaks now runs locally, with the same deviation recorded. I did not read the protected-class register (docs/contracts/instruction-exception-register/README.md); nothing was removed that needs it.

critical-findings: 0

@github-actions

Copy link
Copy Markdown

claude-review reviewed 9cb525ff4064d0f8c465cec36aea57aab5aacbb0: 0 finding(s), 0 as inline comments.

No findings. The PR changes one file, .claude/ecosystems/cross-cutting.yaml, and I found nothing a reviewer would block on.

  • check-cmd: the new gitleaks dir . --config .gitleaks.toml --no-banner --redact || rc=1 line follows the existing rc accumulator pattern. It runs before the final test "$rc" -eq 0, so a gitleaks failure fails the command like the other checks.
  • Opt-in file: .gitleaks.toml exists at the repository root, so the opt-in text matches the tree.
  • Consistency: opt-in, install-hint and tool-pin all name gitleaks 8.30.1. The header comment and the notes both describe it as a deviation from CI, which matches the change.
  • Cite correction: I checked .github/workflows/pr-automerge-dependabot.yml. It has 29 lines, and the :21-29 range now covers the whole pr-automerge-dependabot job, so the correction is right.
  • Closing issue: the PR says "Refs", not "Closes", and names no closing issue, so there were no acceptance criteria to check.
  • Not verified: I did not run gitleaks, and I could not check the ci-workflows line cites or the checksum against the pinned composite. The PR's verification claims are author-claimed and unverified by me.
  • Manifests, settled threads, prior findings: no plugin manifests changed, and there were no settled-thread or prior-finding files.
  • Other lanes: this is not a security-lane concern. I did not fan out subagents.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton merged commit 455a89f into main Nov 14, 2026
8 checks passed
@kyle-sexton
kyle-sexton deleted the fix/ecosystem-records-restore-gitleaks branch November 14, 2026 15:34
kyle-sexton added a commit that referenced this pull request Nov 16, 2026
…the cross-cutting record (#147)

Refs: melodic-software/claude-code-plugins#15725

## Summary

Since #137 and #139, #145 moved the check-managed-files pin to
ci-workflows v0.74.0 (`944d346`), and #144 added a header line to
`pr-automerge-dependabot.yml`. The cross-cutting record's notes still
named v0.71.0 and line ranges one line short. This change corrects those
three citations and nothing else.

## Fix

- `check-managed-files@8e1076f v0.71.0` becomes `@944d346 v0.74.0`,
matching `pr-check-managed-files-hosted.yml:118`.
- `pr-automerge-dependabot.yml:21-29` becomes `:22-30` (the job), and
`:3-7` becomes `:3-8` (the header sentence).

No command, version or checksum changes. #143 also moved the
lychee-offline composite to v0.74.0. I diffed it against v0.39.8
(`594987a`): its version (0.24.2), sha256 and argument defaults are
unchanged. It moved its run step into `run.sh` unchanged, and it now
falls back to a bundled `lychee.toml` only when the caller has none;
this repository has one. The other records' citations still hold: apart
from that header line, every CI edit since #139 changed lines in place.

## Verification

- Schema: `check-jsonschema --schemafile
docs/contracts/ecosystem-commands/ecosystem.schema.json`
(claude-code-plugins `origin/main`) over all four records printed `ok --
validation done`.
- Range: from #139's merge `455a89f` to this commit, covering #140
through #146 plus this fix: 8 files (workflows, dependabot, policy.json,
REVIEW.md, the record). Every tool runs with `env -C <checkout>`.
Toolchain skill text is 1.4.0.
- Run 1, `/toolchain:check all`, 11:38 PM to 11:39 PM EST 2026-11-15.
Overall line: `Overall: PASS (1 of 1 ecosystems passed)`.

| Ecosystem | Build | Test | Lint | Status |
|---|---|---|---|---|
| bash | — | — | pass | PASS |
| markdown | — | — | — | — |

- bash: `shellcheck .claude/cloud-bootstrap.sh .cursor/install.sh` and
`bash -n` on each exited 0.
  - markdown: every command is null.
  - No other ecosystem's files exist.
  - The output contains no `skip (unresolved`.
- Run noise: the first attempt ran in a clone nested under another
repository. With no `.shellcheckrc` here, shellcheck took that
repository's rc and reported 9 optional SC2310 infos. The record's
command run from this branch's own checkout exits 0, as on CI's runner.
- Run 2, `/toolchain:lint`, 11:39 PM EST. Overall line: `Overall: PASS
(1 of 1 ecosystems passed)`.
- cross-cutting passed: `jq empty` on both files, lychee with 0 errors,
and `gitleaks dir . --config .gitleaks.toml --no-banner --redact` with
no leaks.
  - markdown and yaml are all null.
  - The installed lychee 0.24.2 and gitleaks 8.30.1 match the pins.
- The verify gate passed on this commit: schema validation plus the
cross-cutting check-cmd.

## Remaining

melodic-software/claude-code-plugins#15725 stays open after this pull
request. Its baseline steps are still owed: a `/toolchain:check all` and
a `/toolchain:lint` with the bundled defaults (records removed) on one
range, then the comparison of their command lists with the record runs
above. This pass had a two-run budget, which went to the record runs.

## Related

- #137 and #139, which merged the records this change corrects
- melodic-software/claude-code-plugins#15725,
melodic-software/claude-code-plugins#15703 (parent)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant