Repository navigation
fix: keep the local gitleaks scan in the cross-cutting record - #139
Conversation
The cross-cutting record set no gitleaks command because no CI job here runs one, which switched off the secret scan the bundled toolchain default ran for this repository. Add the scan back as a stated deviation from CI, with the command, version and checksum of the gitleaks composite at ci-workflows v0.39.8, and correct one line cite that moved when the job display names changed. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review: PR #139 (head 9cb525f)No security findings. The pull request changes only
critical-findings: 0 |
|
claude-review reviewed No findings. The PR changes one file,
Verifier dropped 0 of 0 candidates. |
…the cross-cutting record (#147) Refs: melodic-software/claude-code-plugins#15725 ## Summary Since #137 and #139, #145 moved the check-managed-files pin to ci-workflows v0.74.0 (`944d346`), and #144 added a header line to `pr-automerge-dependabot.yml`. The cross-cutting record's notes still named v0.71.0 and line ranges one line short. This change corrects those three citations and nothing else. ## Fix - `check-managed-files@8e1076f v0.71.0` becomes `@944d346 v0.74.0`, matching `pr-check-managed-files-hosted.yml:118`. - `pr-automerge-dependabot.yml:21-29` becomes `:22-30` (the job), and `:3-7` becomes `:3-8` (the header sentence). No command, version or checksum changes. #143 also moved the lychee-offline composite to v0.74.0. I diffed it against v0.39.8 (`594987a`): its version (0.24.2), sha256 and argument defaults are unchanged. It moved its run step into `run.sh` unchanged, and it now falls back to a bundled `lychee.toml` only when the caller has none; this repository has one. The other records' citations still hold: apart from that header line, every CI edit since #139 changed lines in place. ## Verification - Schema: `check-jsonschema --schemafile docs/contracts/ecosystem-commands/ecosystem.schema.json` (claude-code-plugins `origin/main`) over all four records printed `ok -- validation done`. - Range: from #139's merge `455a89f` to this commit, covering #140 through #146 plus this fix: 8 files (workflows, dependabot, policy.json, REVIEW.md, the record). Every tool runs with `env -C <checkout>`. Toolchain skill text is 1.4.0. - Run 1, `/toolchain:check all`, 11:38 PM to 11:39 PM EST 2026-11-15. Overall line: `Overall: PASS (1 of 1 ecosystems passed)`. | Ecosystem | Build | Test | Lint | Status | |---|---|---|---|---| | bash | — | — | pass | PASS | | markdown | — | — | — | — | - bash: `shellcheck .claude/cloud-bootstrap.sh .cursor/install.sh` and `bash -n` on each exited 0. - markdown: every command is null. - No other ecosystem's files exist. - The output contains no `skip (unresolved`. - Run noise: the first attempt ran in a clone nested under another repository. With no `.shellcheckrc` here, shellcheck took that repository's rc and reported 9 optional SC2310 infos. The record's command run from this branch's own checkout exits 0, as on CI's runner. - Run 2, `/toolchain:lint`, 11:39 PM EST. Overall line: `Overall: PASS (1 of 1 ecosystems passed)`. - cross-cutting passed: `jq empty` on both files, lychee with 0 errors, and `gitleaks dir . --config .gitleaks.toml --no-banner --redact` with no leaks. - markdown and yaml are all null. - The installed lychee 0.24.2 and gitleaks 8.30.1 match the pins. - The verify gate passed on this commit: schema validation plus the cross-cutting check-cmd. ## Remaining melodic-software/claude-code-plugins#15725 stays open after this pull request. Its baseline steps are still owed: a `/toolchain:check all` and a `/toolchain:lint` with the bundled defaults (records removed) on one range, then the comparison of their command lists with the record runs above. This pass had a two-run budget, which went to the record runs. ## Related - #137 and #139, which merged the records this change corrects - melodic-software/claude-code-plugins#15725, melodic-software/claude-code-plugins#15703 (parent) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Refs: melodic-software/claude-code-plugins#15725
Summary
Puts the local gitleaks secret scan back into
.claude/ecosystems/cross-cutting.yaml. The record merged in #137 set no gitleaks command because no CI job here runs one, and that switched off the scan the bundled toolchain default would run for this repository. The owner had not approved removing a secret scan.Fix
check-cmdgainsgitleaks dir . --config .gitleaks.toml --no-banner --redactas its last check; it contributes to the status like every other line. No existing check changes.opt-in,install-hintandtool-pinname gitleaks.pr-automerge-dependabot.ymlwas a line short; it is corrected.Verification
gitleaks dir8.30.1 over this branch's tree: no leaks found..work/, since deleted) showedgitleaks diralso reads untracked and git-ignored files, as the notes say.Remaining
Issue melodic-software/claude-code-plugins#15725 stays open after this pull request; its baseline steps and recorded
/toolchain:check alloutput are still owed.Whether a record should keep other bundled checks that CI does not run (typos, for example) is an open owner question; this pull request changes only the secret scan.
Related
session: GitHub Support
🤖 Generated with Claude Code