Skip to content

ci: call the ci-workflows reusable workflows at main - #141

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/float-ci-workflows-callers
Nov 14, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/float-ci-workflows-callers

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: found by listing every caller of a melodic-software/ci-workflows reusable workflow that is pinned below its main.

Summary

This repository called a ci-workflows reusable workflow at an old pinned commit, so its checks still reported that workflow's earlier job names (for example PR Automerge Dependabot / Arm auto-merge for safe Dependabot bumps). The caller now references @main, the form the org's first-party callers use. CI Status stays the only required check.

Fix

  • Each uses: melodic-software/ci-workflows/.github/workflows/<file>.yml@<sha> # <version> becomes @main. Pins of composite actions under .github/actions/ are unchanged.

Verification

  • Compared each reusable workflow's workflow_call interface between the old pin and ci-workflows v0.74.0: inputs were only added, both optional; no input was removed, renamed or made required, and no secret or job permission changed. The caller's with: and permissions: blocks still fit.
  • The org runner policy accepts a ci-workflows reusable workflow at @main (melodic-software/standards components/runner-policy/runner-policy.mjs).
  • Behaviour that arrives with the newer workflow: pr-automerge-dependabot.yml also arms patch and minor uv updates and checks the pull request's title and body against the update metadata.
  • Left out: a local run; CI on this pull request exercises the caller.

Related

🤖 Generated with Claude Code

The callers were pinned to an old ci-workflows commit, so their checks
still reported the reusable jobs' earlier names. The org's first-party
callers float on main; composite action pins are unchanged.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 14, 2026 20:01
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T20:02:25.211197Z f9b8b47 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-review reviewed f9b8b4793e0379b442bb124f1cb53d037948bca4: 0 finding(s), 0 as inline comments.

No findings. I reviewed the whole diff, which changes one uses: line in .github/workflows/pr-automerge-dependabot.yml from a pinned commit to @main.

  • Consistency: The two other reusable-workflow callers here, pr-review-hosted.yml and pr-review-security-hosted.yml, already use @main. The composite-action pins are untouched, as the PR says.
  • Interface fit: The caller's with: runner: input and its permissions: block are unchanged. I did not re-check the old-versus-v0.74.0 workflow_call comparison; it is the author's claim and I treat it as unverified.
  • Header comment: The workflow's header says it arms auto-merge only for allowlisted GitHub Actions publishers. The PR says the newer workflow also arms uv updates. dependabot.yml configures only the github-actions ecosystem, so the comment is still accurate for this repository.
  • Floating ref: Calling a workflow at a floating ref with contents: write and pull-requests: write is a trust-boundary question. It belongs to the security lane, and the org's other first-party callers already do the same.
  • Closing issue: The PR states "No related issue" with a reason, so there are no acceptance criteria to check.
  • Manifests, paved paths, rules: None of these apply to this diff.

I ran no commands beyond reading the diff, the PR context and the repository files.

Verifier dropped 0 of 0 candidates.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed f9b8b4793e0379b442bb124f1cb53d037948bca4: 0 finding(s), 0 as inline comments.

No security findings. critical-findings: 0

The PR changes one line, in .github/workflows/pr-automerge-dependabot.yml. It moves the melodic-software/ci-workflows reusable workflow from the commit pin d223a64… (v0.50.0) to @main.

  • Permissions: The caller's grants are unchanged: top-level permissions: {}, and job-level contents: write and pull-requests: write. The change does not widen any token scope, trusted-actor check, kill switch or merge hold.
  • Pin loosening: Moving to a floating ref is the supply-chain pin risk that zizmor's advisory lane covers, so I did not re-report it. It is also the owner's "pin or repin ceremony" friction hold under the throughput-phase threat model, so I did not treat it as a finding.
  • Trust boundary: The new ref is an org-owned repository, melodic-software/ci-workflows, not an outside source. The pull request's author cannot change what @main resolves to. The other hosted review workflows in this repo already call the same repository at @main: pr-review-hosted.yml:85 and pr-review-security-hosted.yml:78. The repo's HEAD commit message says the move is intentional.
  • Remaining effect: Changes merged to ci-workflows main now run here with contents: write and pull-requests: write on Dependabot pull requests. Only the owner's org can make such a change, so I found no outside path to it.
  • Manifests: No plugin.json or marketplace.json files changed.
  • Instruction surface: The diff deletes or softens no standing instruction.

@kyle-sexton
kyle-sexton merged commit e51f872 into main Nov 14, 2026
10 checks passed
@kyle-sexton
kyle-sexton deleted the ci/float-ci-workflows-callers branch November 14, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant