Skip to content

ci: run every shared git hook through the aggregate lefthook remote - #158

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/lefthook-aggregate-remote
Nov 18, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/lefthook-aggregate-remote

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: org-wide rollout of the shared git hooks (every repository gets the same hook set from one source).

Summary

Switches this repository's lefthook remote from the guardrails-only config to claude-code-plugins' root lefthook-remote.yml, which extends all 11 hook plugins' remote configs: guardrails, code-tidying, actionlint, bash-format, go-format, instruction-placement, javascript-format, markdown-format, powershell-format, python-format and spelling.

Fix

lefthook.yml: configs: names lefthook-remote.yml. ref: main and refetch_frequency: 24h are unchanged. Formatters act only where this repository has the tool's config; the lint jobs block only on findings in lines a commit adds.

Verification

  • Formatter dry run over the whole tree (throwaway clone, aggregate installed, every tracked file staged, each formatter job alone): no file rewritten, so no cleanup PR is needed.
  • This commit ran the aggregate's pre-commit, commit-msg and pre-push jobs.
  • The same switch landed first in control-hub#15, where all 16 pre-commit jobs ran on a real commit.

Related

🤖 Generated with Claude Code

Name claude-code-plugins' root lefthook-remote.yml, which extends all 11
hook plugins' remote configs, in place of the guardrails-only config.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T10:00:09.235976Z 2b0b805 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 2b0b805c2003a1bf834f4cad2c642647a85da974: 0 finding(s), 0 as inline comments.

Security review: PR #158 (head 2b0b805)

No security findings.

The diff is one line in lefthook.yml. The remote config path in the melodic-software/claude-code-plugins remote changes from plugins/guardrails/git-hooks/lefthook-remote.yml to the repo-root lefthook-remote.yml, the aggregate config.

  • Remote and pin: the remote is unchanged. It is the same org-owned repo (git_url), the same ref: main, and the same refetch_frequency: 24h. The unpinned ref: main was already there, and this diff does not loosen it. Pin hygiene is zizmor's lane in any case.
  • Trust controls: the change touches none of the listed controls. It is not the trusted-trigger check, token scope, kill switch, token broker, a merge hold, or any other action under .github/actions/. It does not touch CODEOWNERS, .gitmodules, or a plugin manifest.
  • Consumers: the only workflow I found that mentions lefthook is .github/workflows/pr-check-managed-files-hosted.yml. It lists .lefthook/* paths and does not read this config.
  • Attacker path: a PR author cannot reach the remote's content through this diff. Hooks run on developer machines from the org's own repository, so the trust boundary is the same as before.
  • Not verified: I could not read the remote's lefthook-remote.yml, so I have not checked what the extra hooks run. The commit message says it extends all 11 hook plugins' remote configs. That is a wider set of org-owned hooks from the same unpinned main, which is the existing trust model and not a new finding.
  • Instruction-surface lens: no standing instruction or guardrail is deleted or softened in the diff. The protected-class register was not consulted because the change is not an instruction deletion.

No manifest lines apply. The diff touches no plugin manifest.

critical-findings: 0

@github-actions

Copy link
Copy Markdown

claude-review reviewed 2b0b805c2003a1bf834f4cad2c642647a85da974: 0 finding(s), 0 as inline comments.

No findings. The diff is one line: lefthook.yml now points the claude-code-plugins remote at lefthook-remote.yml instead of plugins/guardrails/git-hooks/lefthook-remote.yml. The ref: main and refetch_frequency: 24h settings are unchanged.

  • Remote path unverified: I could not confirm that lefthook-remote.yml exists at the root of claude-code-plugins main. My gh api call was blocked by a permission prompt in this lane. The PR says the same switch already ran in control-hub#15 and that this commit ran the aggregate's pre-commit, commit-msg and pre-push jobs. Those statements are author-claimed and I did not verify them.
  • Closing issue: none. The PR uses the "No related issue" escape and gives a reason, so there are no acceptance criteria to check.
  • PR body: it has the required opening line and the ## Summary, ## Fix, ## Verification and ## Related sections.
  • Loosened-check verdict: the wrapper supplied no loosened_check_verdict: line, so I used fail with no consumer entries. The one-line config change loosens no check, so the criterion raised nothing.
  • Manifests: the diff touches no plugin manifests.
  • Settled and prior findings: the wrapper supplied no settled-threads or prior-findings files, so nothing was treated as settled or already posted.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton merged commit 4822945 into main Nov 18, 2026
8 checks passed
@kyle-sexton
kyle-sexton deleted the ci/lefthook-aggregate-remote branch November 18, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant