Skip to content

ci: run ci-status through the report-ci-status composite - #159

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/report-ci-status
Nov 18, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/report-ci-status

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: a rollout step of melodic-software/ci-workflows#1138, which stays open until every repository has moved.

Summary

Rollout of ci-workflows#1138: the ci-status job now runs the shared report-ci-status composite (ci-workflows#1139, v0.76.0, pinned at ebd0e3b) instead of its own check-contract and aggregate-results steps. CI Status stays the job's name and the single required check, and its behavior is unchanged.

Fix

  • ci-status steps: one report-ci-status step named Aggregate lane results (id: report), then "Fail on the contract or draft policy", which fails on any contract or draft outcome other than success (fails closed).
  • Kept: draft: allow (the job had no draft refusal and no ready_for_review trigger), no exempt authors (none before), treat-skipped-as at the default fail (the old step set fail), the job's if: ${{ !cancelled() }}, needs, permissions, runner, timeout and the merge_group trigger.
  • The composite fixes yield-to-full-run: 'true' and carry-forward-wait-seconds: '0' (action.yml L128-L129) and keeps rerun-contract-only-siblings at true: the values this job set before. Comments now describe the composite instead of inputs the file no longer sets.
  • Concurrency: unchanged; a push already falls back to github.run_id.
  • Lines: 33 removed, 37 added (git diff --numstat); the added lines are comments recording the composite's fixed behavior.

Verification

  • actionlint .github/workflows/pr-require-checks.yml: no findings.
  • CI Status on this PR's head: see the checks. The label proof (do-not-merge fails, removal passes with no push) was run once for the rollout, on agent-automations#73.

Related

🤖 Generated with Claude Code

https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C

The ci-status job now runs the shared report-ci-status composite
(ci-workflows v0.76.0) instead of its own contract and aggregation
steps, then fails on the contract or draft outputs. CI Status keeps its
name and behavior: drafts are allowed, as before.

Refs: melodic-software/ci-workflows#1138

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 18, 2026 20:23
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T20:25:07.291001Z 436ea67 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 436ea67a376afc0ff9dd6219d2f07ba560a0ecfd: 0 finding(s), 0 as inline comments.

Security review: PR #159 (head 436ea67)

No security findings.

The PR changes one file, .github/workflows/pr-require-checks.yml. It replaces the pinned check-contract and aggregate-results composites (v0.75.0) with the single report-ci-status composite (v0.76.0). It also adds a follow-up step that fails the job on a contract or draft failure. The ci-status hold steps are a listed merge-hold control, so I read the whole change against that criterion.

  • Hold behavior: the old step passed treat-skipped-as: fail, and the PR keeps that as the composite's default. The old step passed yield-to-full-run: 'true' and carry-forward-wait-seconds: '0'. The PR comments say the composite now fixes both values, which the diff does not show. The default for rerun-contract-only-siblings is likewise stated only in a comment.
  • Contract and draft gate: the new Fail on the contract or draft policy step fails unless both steps.report.outputs.contract and steps.report.outputs.draft equal success. An empty or renamed output therefore fails the job. That is fail-closed, so the gate is not weakened. draft: allow matches the old behavior, because this workflow has no ready_for_review trigger and a draft already passed.
  • Token and permissions: the permissions: block (contents: read, pull-requests: write, statuses: write, actions: write) is unchanged, so no token scope grows. The explicit token: ${{ github.token }} inputs are dropped. That can only make the composite fail if it has no default, not widen anything.
  • Action pin: the new uses: is a full 40-character SHA with a version comment, and it is in the same org's ci-workflows repository. Pin hygiene is zizmor's lane, so I did not re-report it.
  • Not checked: I could not read the upstream composite's action.yml or confirm that the SHA matches the v0.76.0 tag. Those commands needed approval that the sandbox did not grant. The conclusion above rests on the diff and its comments, and on no path in the diff that widens trust, token scope or untrusted input.
  • Instruction surface: none of the changes delete or soften a standing instruction.
  • Owner threat model: no named friction holds were removed.

critical-findings: 0

@github-actions

Copy link
Copy Markdown

claude-review reviewed 436ea67a376afc0ff9dd6219d2f07ba560a0ecfd: 0 finding(s), 0 as inline comments.

Code review: PR #159 (head 436ea67)

No findings. The PR changes one file, .github/workflows/pr-require-checks.yml. It replaces the check-contract and aggregate-results steps in ci-status with one report-ci-status composite step (v0.76.0, pinned at ebd0e3b). A follow-up step fails the job on any contract or draft outcome other than success.

What I checked from the diff and the file at head:

  • Job gating: needs, the job if: !cancelled(), permissions (actions, statuses and pull-requests write), the 3-minute timeout and the job name CI Status are all unchanged.
  • Step if-condition: the composite step no longer has its own if: !cancelled(). That is fine because the job-level if still gates the job and no earlier step can fail now.
  • Fail-closed step: "Fail on the contract or draft policy" runs under !cancelled() && (contract != 'success' || draft != 'success'). An empty or renamed output is not success, so it fails closed.
  • Step name: the step keeps the name Aggregate lane results. The comment says a contract-only run finds the full run's writer step by that name, and the name is preserved.
  • Draft handling: draft: allow matches the old behavior. The workflow has no ready_for_review trigger and the old job had no draft refusal.
  • Comments: they now describe the composite's fixed behavior, not inputs the file no longer sets.

Not verified: I could not read the composite's action.yml at the pinned SHA, so I did not confirm that the input names (step-name, results, draft) or the outputs (contract, draft) exist, or that yield-to-full-run and carry-forward-wait-seconds are fixed to the values the PR claims. Those, and the author's actionlint result, are author-claimed and unverified by me.

  • Closing issue: none; the PR uses the no-issue escape ("No related issue: …"), so there are no criteria to check.
  • Loosened-check verdict: no wrapper loosened_check_verdict: line was supplied, so I used fail with no consumer entries. The change loosens no settings or guards.
  • Manifests: the diff touches no plugin manifests.
  • Prior and settled threads: no prior-findings or settled-threads files were supplied.
  • Path-scoped rules: there is no .claude/rules/ directory.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton merged commit 1ad8fcb into main Nov 18, 2026
10 checks passed
@kyle-sexton
kyle-sexton deleted the ci/report-ci-status branch November 18, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant