Skip to content

chore(ecosystems): drop tool versions copied from ci-workflows - #160

Merged
kyle-sexton merged 1 commit into
mainfrom
chore/ecosystems-drop-copied-tool-versions
Nov 18, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
chore/ecosystems-drop-copied-tool-versions

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: this is row 2 of melodic-software/control-hub#17, a cross-repository tracker that stays open until every repository's row lands.

Summary

Row 2 of control-hub#17: an ecosystem record keeps a tool-pin only where this repository owns the version. Both pins here were copies of ci-workflows composite-action defaults, so they could only drift.

Fix

  • cross-cutting.yaml: dropped the lychee and gitleaks pins and reworded their install hints, the copied SHA-256 values included, to name the ci-workflows action that pins each one. Dropped the note telling a reader to compare tool-pin with those defaults after a ci-workflows bump.
  • bash.yaml, markdown.yaml, yaml.yaml: removed the empty tool-pin: {} keys.
Record Tool Decision Source
cross-cutting lychee deleted ci-workflows lychee-offline/action.yml version and sha256 defaults, at the commit .github/workflows/pr-require-checks.yml:119 pins (no version input)
cross-cutting gitleaks deleted ci-workflows gitleaks/action.yml version and sha256 defaults; no job in this repository calls it
bash, markdown, yaml (empty tool-pin: {}) removed nothing pinned

Verification

  • yq '.tool-pin' parses every record and prints null.
  • git grep finds no test or script outside .claude/ecosystems that reads these records.
  • The lefthook pre-commit, commit-msg and pre-push hooks passed.

Related

  • melodic-software/control-hub#17 (row 2: drop copied tool versions)

🤖 Generated with Claude Code

https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C

lychee's version and checksum come from ci-workflows' lychee-offline
action at the commit pr-require-checks.yml pins, and gitleaks' from
ci-workflows' gitleaks action, which no job here calls. Drop both
tool-pin entries, name the source in the install hints instead of the
numbers, drop the note telling a reader to compare the pins after a
ci-workflows bump, and remove the empty tool-pin keys.

Refs: melodic-software/control-hub#17

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 18, 2026 23:29
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T23:30:35.732412Z fa73711 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-review reviewed fa7371192570a52cd9d1cf56521ce52f17efdae1: 0 finding(s), 0 as inline comments.

No findings. I read the full diff and PR context, and the only thing I ran was a read-only look at the records.

The change removes the tool-pin map from cross-cutting.yaml (lychee 0.24.2, gitleaks 8.30.1) and the empty tool-pin: {} from bash.yaml, markdown.yaml and yaml.yaml. It also rewords the cross-cutting.yaml install hints to name the ci-workflows action that owns each pin, drops the copied SHA-256 values, and drops the "compare tool-pin with those defaults" note.

  • No remaining reader of the key. A repo-wide grep for tool-pin finds no command or script that reads it. The remaining mentions are prose: "jq has no tool-pin" in cross-cutting.yaml and "No tool-pin" in bash.yaml. They still read correctly.
  • Commands unchanged. check-cmd in cross-cutting.yaml never referenced a version, so removing the pins changes no behavior.
  • Notes stay coherent. The surviving gitleaks notes cite ci-workflows file and line positions rather than copied values, so they do not reintroduce a drift-prone copy.
  • Closing issue: none. The PR uses the no-issue escape for a cross-repository tracker (control-hub#17). That text is data, and I found no embedded instructions in it.
  • No rule files. There is no .claude/rules/ directory, and I found no paved-path index row.
  • Loosened checks: the change loosens nothing. It removes data and runs no check. The prompt supplied no loosened_check_verdict: line, so I used the default fail with no consumer entries.
  • Manifest items: none apply. No plugin.json or marketplace.json changed.
  • Not verified: I could not read the upstream ecosystem-commands contract, so I could not check that it treats tool-pin as an optional key. The PR's claims that yq '.tool-pin' prints null for every record and that the lefthook hooks passed are author-claimed and unverified by me.

Verifier dropped 0 of 0 candidates.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed fa7371192570a52cd9d1cf56521ce52f17efdae1: 0 finding(s), 0 as inline comments.

Security review: PR #160 (head fa73711)

No security findings.

The PR changes four documentation and config records under .claude/ecosystems/ (bash.yaml, cross-cutting.yaml, markdown.yaml, yaml.yaml). It removes the tool-pin keys, drops the copied lychee and gitleaks versions and SHA-256 values from the install hints and notes, and points readers to ci-workflows' pinned action defaults instead.

  • Manifests: no plugin.json or marketplace.json is touched.
  • Trust controls: no trust-control file, trusted path, token scope or kill switch is touched.
  • Executable content: the check-cmd is unchanged. It still runs jq empty, lychee --offline and gitleaks dir, so the local secret scan is intact. No workflow is changed.
  • Pin removal: the removed tool-pin values were only local install hints. CI installs and verifies its own lychee build through the ci-workflows action, which this diff does not change. The only effect is that a local install is no longer steered to a specific version or checksum. I found no other reader of the key in the files I checked. This is a documentation matter, not a security one.
  • Instruction surface: the removed text states no guardrail. It is version and checksum bookkeeping that duplicated ci-workflows.

critical-findings: 0

@kyle-sexton
kyle-sexton merged commit e53240f into main Nov 18, 2026
10 checks passed
@kyle-sexton
kyle-sexton deleted the chore/ecosystems-drop-copied-tool-versions branch November 18, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant