Skip to content

chore: remove unnecessary comments under ADR 0110 - #169

Merged
kyle-sexton merged 2 commits into
mainfrom
chore/remove-unnecessary-comments
Nov 21, 2026
Merged

kyle-sexton merged 2 commits into
mainfrom
chore/remove-unnecessary-comments

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

Refs: melodic-software/control-hub#12

Summary

Comment-removal sweep of melodic-software/agent-plugins under ADR 0110 (necessary posture) and REVIEW.md. Code-file count: 17 tracked code files (8 sync-managed from standards including pr-review*-hosted.yml, 4 under .claude/ecosystems/, and 5 locally-owned files reviewed).

Fix

Removed 9 lines of redundant function/command restatement comments in .cursor/install.sh:

  • Removed the four obvious --version / version restatement lines above tool_report() while preserving the upstream issue note (DavidAnson/markdownlint-cli2#289).
  • Removed restatement comments above place(), link(), fetch(), and the signature line above extract_first() while preserving the tarball-layout constraint comment.

Preserved untouched:

  • The opening script-purpose header, tool-to-config mapping, and Design: rationale block in .cursor/install.sh.
  • All shebangs, lint/schema directives, SHA-pin version comments (# v7.0.1, # v0.78.0), sync-managed files, .github/workflows/pr-review*.yml, .claude/ecosystems/*.yaml, and all decision/constraint/quirk comments across .cursor/install.sh, .github/dependabot.yml, and .github/workflows/pr-require-checks.yml.

Verification

  • git diff verified strictly comment deletions (1 file changed, 9 deletions(-)), zero code tokens modified.
  • bash -n .cursor/install.sh exited 0.
  • Full CI and review lanes verified on this PR.

Related

  • Refs: melodic-software/control-hub#12

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T19:55:37.855902Z 309dd7a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

claude-security-review reviewed f96e241d1c8f9f2518ae9e46db7fee4be1a97c9a: 0 finding(s), 0 as inline comments.

Incremental security review of PR #169 at f96e241, covering only the change to .cursor/install.sh since 309dd7a.

The change adds a 10-line comment header describing the script's purpose and the tool-to-config mapping. It adds or modifies no executable code. It does not touch a manifest, a trust control, a trusted path, or any standing instruction such as CLAUDE.md or AGENTS.md. Under the skip gate, the change has no security-relevant surface. No findings.

critical-findings: 0

Comment thread .cursor/install.sh Resolved
@github-actions

github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

claude-review reviewed f96e241d1c8f9f2518ae9e46db7fee4be1a97c9a: 0 finding(s), 0 as inline comments.

Incremental review of .cursor/install.sh (309dd7a → f96e241): no findings.

The change only adds a 9-line comment header. It restores the script-purpose line and the tool-to-config mapping that the earlier comment sweep removed. No code tokens changed.

I checked the header's claims against the repo. All five root configs it names exist: .markdownlint-cli2.jsonc, .editorconfig-checker.json, _typos.toml, lychee.toml and .gitleaks.toml. The five tools it lists match the pinned version variables in the script. The header also fits the ADR 0110 "necessary" comment posture the PR describes, since it records purpose and mapping rather than restating code.

I could not run bash -n on the script in this sandbox. The author reports it exited 0, but I did not confirm that. The change is comment-only.

Closing issue: the PR only references melodic-software/control-hub#12 with Refs: and has no closing issue, so there are no acceptance criteria to check. Loosened-check, plugin-manifest and path-scoped-rule items are not hit by this diff.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton merged commit 44b5574 into main Nov 21, 2026
13 of 14 checks passed
@kyle-sexton
kyle-sexton deleted the chore/remove-unnecessary-comments branch November 21, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant