Skip to content

revert(ci-status): re-run contract-only siblings from draft full runs again - #70

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/revert-draft-rerun
Oct 5, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/revert-draft-rerun

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Summary

Reverts the draft-conditional rerun-contract-only-siblings value from #69 back to 'true'.

This repo's pull_request trigger omits ready_for_review (pr-require-checks.yml line 35), and no lane is gated on draft. A draft full run therefore runs every lane, and its sibling re-runs are safe. Skipping them on a draft can leave a yielded red contract-only ci-status stuck after the PR is marked ready, because nothing re-runs it. The same reasoning closed cursor-plugins#85 (Codex review P2).

Related

Follow-up to #69.

🤖 Generated with Claude Code

… again

This repo's pull_request trigger omits ready_for_review and gates no lane
on draft, so a draft full run runs every lane. Skipping its sibling
re-runs could strand a yielded red contract-only ci-status after the PR
is marked ready, since nothing would re-run it. Reverts the
draft-conditional value from #69.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T01:46:44.092727Z 59ab129 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@claude

claude Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 1m 17s —— View job


Security review — PR #70

  • Gather context (diff, trigger-config comments in pr-require-checks.yml)
  • Run /review:security-review criteria against the changed file
  • Post results

Skip gate: no security-relevant surface.

The entire diff is a one-line revert in .github/workflows/pr-require-checks.yml:

-          rerun-contract-only-siblings: ${{ github.event.pull_request.draft && 'false' || 'true' }}
+          rerun-contract-only-siblings: 'true'

Checked against this lane's criteria:

  • Permissions / trust boundary — unchanged. The job's permissions: block (lines 115–126) already grants actions: write for this exact purpose; the revert doesn't add or widen any scope.
  • Fork safety — unaffected. Per the file's own comment (lines 29–31), a fork pull request's token is read-only on pull_request and is never contract-only, so sibling re-runs under this flag only ever touch same-repo runs, draft or not.
  • Injection / secrets — no new expression or context interpolation introduced; the replaced ternary and the literal 'true' are both static values, neither derived from attacker-controlled input.
  • Instruction-surface deletion lens — not applicable. This is a workflow parameter value, not a guardrail in CLAUDE.md/AGENTS.md/a rules file, and the repo has no docs/conventions/instruction-exception-register/ to cross-check against regardless.
  • Actions hardening (zizmor's lane) — no trigger, permissions:, or pin changes here, so nothing in scope for this lane to re-report.

This restores the behavior from before #69 and the stated rationale holds: this repo's pull_request trigger (line 35) omits ready_for_review, and no job's if: gates on draft, so a draft's full run already executes every lane — making the sibling re-run unconditionally safe, exactly as it was prior to #69.

No security issues found.

@claude

claude Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 1m 40s —— View job


CI code review — PR #70

Todo

  • Gather context (diff, PR body, workflow file)
  • Understand request (CI code-review lane via /review:code-review)
  • Review the change
  • Post results

Scope: .github/workflows/pr-require-checks.yml, 1 line changed — reverts rerun-contract-only-siblings from the draft-conditional ternary introduced in #69 back to the unconditional 'true'.

Verification performed:

  • Confirmed the pull_request trigger's types: list (line 35) omits ready_for_review, so marking a draft PR ready never fires a new event on this workflow.
  • Confirmed neither check-scripts-and-manifests nor ci-status gates on github.event.pull_request.draft — grepped the full file for draft post-revert and found zero remaining references, so the revert leaves no stale draft-specific comments or dead logic behind.
  • These two facts support the PR's stated premise: a draft full run already executes every lane, so re-running red contract-only siblings from it is safe, and skipping that rerun risks stranding a red contract-only ci-status with no later event to fix it once the PR goes ready.

No correctness, maintainability, or alignment issues found — the change is a clean, well-justified single-value revert with no leftover dead code or stale comments from the reverted conditional. No inline findings to post.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

PR body contract — issue linkage

This PR body does not yet satisfy the issue-linkage contract:

  • Missing a "## Fix" section. State the concrete change and how it addresses the problem.
  • Missing a "## Verification" section. Record concrete evidence the change works (commands, gates, output).
  • Missing a native closing keyword (Closes/Fixes/Resolves #N). If this PR references an issue it must not close, put "Refs: #N" (or "Relates to: #N") on its own line. If it relates to no GitHub issue at all, state "No linked issue" (or "No related issue:") in the body instead.

Edit the body and this comment updates itself on the next run.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

claude-security-review has reviewed this pull request through 59ab129; a later push is reviewed from there.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

claude-review has reviewed this pull request through 59ab129; a later push is reviewed from there.

@kyle-sexton
kyle-sexton merged commit 9cb52e0 into main Oct 5, 2026
7 checks passed
@kyle-sexton
kyle-sexton deleted the ci/revert-draft-rerun branch October 5, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant