Skip to content

ci: run the offline lychee link check - #87

Merged
kyle-sexton merged 1 commit into
mainfrom
lychee-offline-lane
Oct 11, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
lychee-offline-lane

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: part of the org-wide lychee rollout that makes a broken local link or anchor block merge.

Summary

Adds an Offline links job to pr-require-checks.yml and feeds it into ci-status, the context the org ci-gate ruleset requires on the default branch.

Fix

  • New lychee job runs the pinned melodic-software/ci-workflows lychee-offline composite (v0.39.8) against the synced lychee.toml, offline, over **/*.md.
  • ci-status now needs the job; its aggregation passes needs.*.result with treat-skipped-as: fail, so a red or skipped lychee job fails ci-status.
  • The workflow header comment names the new lane.

Verification

  • Local: lychee 0.24.2 --offline --config lychee.toml '**/*.md' reports 0 errors.
  • CI: the Offline links job on this PR runs on Linux, which also catches case-sensitive path mismatches.

Related

  • Shared ruleset: lychee.toml, synced from melodic-software/standards (not edited here).

🤖 Generated with Claude Code

Add an `Offline links` lane that runs the pinned ci-workflows
lychee-offline composite against the synced lychee.toml, and feed it
into ci-status so a broken local link or anchor fails the gate.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review October 11, 2026 14:37
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T14:40:20.905228Z ff626b0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@claude

claude Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 2m 30s —— View job


Code review complete ✅

  • Gather context (PR diff, CLAUDE.md/AGENTS.md, /review:code-review skill)
  • Review pr-require-checks.yml changes
  • Post findings

No blocking findings. The change is a small, well-scoped infra addition and matches the existing conventions in this file closely:

  • The new lychee job's if: condition (line 109) is copied verbatim from check-scripts-and-manifests (line 85), matching the header comment's own description of the contract-only predicate being "repeated verbatim ... in every job's if: except ci-status."
  • The action pin melodic-software/ci-workflows/.github/actions/lychee-offline@594987a... (line 118) uses the same commit SHA (tagged v0.39.8) already trusted elsewhere in this file for check-contract/aggregate-results, so it isn't introducing a new, unvetted supply-chain dependency.
  • ci-status's needs list and treat-skipped-as: fail aggregation correctly pick up the new lane (line 123), so a red or skipped lychee job fails the required check as intended.
  • I checked the composite action's actual action.yml (available in this runner's local actions cache) to confirm what files get scanned, since the job only passes config: lychee.toml and not an explicit glob: globs defaults to **/*.md and config defaults to lychee.toml, so the job's implicit defaults line up with the PR's described local verification (lychee --offline --config lychee.toml '**/*.md'). No mismatch there.
  • lychee.toml itself is unchanged in this diff, consistent with the PR body's claim that it's synced from melodic-software/standards and not edited here.

Note: the PR body's local verification command and output (0 errors) is the author's own claimed verification — I did not independently re-run it, and have not treated it as something I confirmed myself.
· Branch

@claude

claude Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 58s —— View job


Security review — /review:security-review

  • Gather context (diff against origin/main, read full pr-require-checks.yml)
  • Understand the request (CI security review of PR ci: run the offline lychee link check #87 per custom instructions)
  • Review changed file for security-relevant issues
  • Post findings

Scope: single file, .github/workflows/pr-require-checks.yml (+20/-5): adds a lychee job running the pinned melodic-software/ci-workflows lychee-offline@594987a… (v0.39.8) composite against lychee.toml, and wires it into ci-status's needs.

Findings: none.

  • The new job checks out with persist-credentials: false and inherits the workflow's permissions: contents: read — no write token is exposed to the job or to the third-party composite action.
  • The composite action is pinned to a full commit SHA (not a mutable tag), and it only runs an offline link check (--offline) against a local, repo-synced config — no network egress, no secrets, no untrusted input reaches a run: block or shell interpolation.
  • The job's if: condition is the same contract-only predicate already used by the sibling check-scripts-and-manifests job, copied verbatim and consistently — no new gap in the contract-only/full-run branching this workflow relies on.
  • ci-status now needs: [check-scripts-and-manifests, lychee], and aggregation already treats skipped as fail, so the new lane can't silently pass by being skipped.
  • Pin freshness, action supply-chain trust, and other GitHub Actions hardening questions are zizmor's advisory lane per this skill's scope and aren't re-reported here.
  • No instruction-surface deletion: the header comment is only expanded (describes the new lane), not narrowed.

No code changes made (review only, as requested).

@github-actions

Copy link
Copy Markdown

claude-security-review has reviewed this pull request through ff626b0; a later push is reviewed from there.

@github-actions

Copy link
Copy Markdown

claude-review has reviewed this pull request through ff626b0; a later push is reviewed from there.

@kyle-sexton
kyle-sexton merged commit fe79b59 into main Oct 11, 2026
10 checks passed
@kyle-sexton
kyle-sexton deleted the lychee-offline-lane branch October 11, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant