Repository navigation
ci: move ci-status onto the report-ci-status composite - #588
Conversation
The ci-status job's check-contract and aggregate-results steps become one report-ci-status step (still named "Aggregate lane results", id report) pinned at ci-workflows v0.76.3, plus a step that fails the job when the contract or draft output is anything but success. Kept: draft allow (the job had no "Refuse a draft" step), exempt-authors, treat-skipped-as pass, rerun-contract-only-siblings true, step-name, and the job's if, needs, permissions, runner and timeout. The pin inventory test now names report-ci-status in place of the two replaced composites, skips full-line YAML comments that link a ci-workflows file, and asserts the fail-closed step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed Review of #588: move ci-status onto the report-ci-status compositeI found no findings. I read the full diff and PR context, the What I checked:
Loosened-check verdict: fail (default, no wrapper settings line was supplied); patterns: 0. The decision-record line was not supplied, so I did not check the citation requirement. No loosening found. Closing issue: the PR uses Verifier dropped 0 of 0 candidates. |
|
claude-security-review reviewed Security review: PR #588 (head 41f3331)No security findings. The change touches the
Manifest lines: none. No plugin manifests changed. critical-findings: 0 |
Refs: melodic-software/ci-workflows#1138
Summary
Moves the
ci-statusjob in.github/workflows/pr-require-checks.ymlonto ci-workflows'report-ci-statuscomposite (design: ci-workflows#1138), following the worked examples songwriting#75 and codex-plugins#208. The composite is pinned at9c5bedfbfdbdfe733b9ce4cd7ca80c1574bd4cb8 # v0.76.3, the same commit every other ci-workflows action in this file uses since #587, so the one-pin inventory still holds.Fix
report-ci-statusstep that keeps the nameAggregate lane results(nowid: report), so a contract-only run still finds the full run's writer step by that name.steps.report.outputs.contractor.draftis anything butsuccess(fails closed).draft: allow(the job had no "Refuse a draft" step),exempt-authors: 'dependabot[bot],melodic-standards-sync[bot]',treat-skipped-as: pass(the composite defaults tofail),rerun-contract-only-siblings: 'true',step-name, and the job'sif: always(),needs, permissions, runner andtimeout-minutes: 3. The composite fixesyield-to-full-run: 'true'andcarry-forward-wait-seconds: '0'(action.yml L128-L129);tokenandenforce-hold-labelfall to defaults equal to the old ones (github.token,false).github.run_id..github/scripts/workflow-pin-metadata.test.cjs: the caller inventory namesreport-ci-statusin place ofaggregate-resultsandcheck-contract; the pin scan skips full-line YAML comments, since the composite link above is a comment that calls nothing; a new test asserts theid: reportstep keeps its name and that a later step fails on any contract or draft outcome butsuccess.Lines changed (
git diff --numstat): workflow +43/-33, test +20/-3.Verification
node --test ".github/scripts/**/*.test.cjs": 39 passed, 0 failed. The new fail-closed test failed when the gate's condition was changed to== 'failure', then passed once it was restored.pwsh ./scripts/Test-ReleasePins.ps1: "Release and workflow pins are internally consistent."actionlinton the workflow: no findings; lefthook pre-commit and pre-push hooks passed.Related
🤖 Generated with Claude Code
https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C