Skip to content

ci: move ci-status onto the report-ci-status composite - #588

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/report-ci-status
Nov 19, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/report-ci-status

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Refs: melodic-software/ci-workflows#1138

Summary

Moves the ci-status job in .github/workflows/pr-require-checks.yml onto ci-workflows' report-ci-status composite (design: ci-workflows#1138), following the worked examples songwriting#75 and codex-plugins#208. The composite is pinned at 9c5bedfbfdbdfe733b9ce4cd7ca80c1574bd4cb8 # v0.76.3, the same commit every other ci-workflows action in this file uses since #587, so the one-pin inventory still holds.

Fix

  • The "Check the pull-request contract" and "Aggregate lane results" steps become one report-ci-status step that keeps the name Aggregate lane results (now id: report), so a contract-only run still finds the full run's writer step by that name.
  • A new step, "Fail on the contract or draft policy", fails the job when steps.report.outputs.contract or .draft is anything but success (fails closed).
  • Behavior kept: draft: allow (the job had no "Refuse a draft" step), exempt-authors: 'dependabot[bot],melodic-standards-sync[bot]', treat-skipped-as: pass (the composite defaults to fail), rerun-contract-only-siblings: 'true', step-name, and the job's if: always(), needs, permissions, runner and timeout-minutes: 3. The composite fixes yield-to-full-run: 'true' and carry-forward-wait-seconds: '0' (action.yml L128-L129); token and enforce-hold-label fall to defaults equal to the old ones (github.token, false).
  • Concurrency: unchanged. The push fallback is already github.run_id.
  • .github/scripts/workflow-pin-metadata.test.cjs: the caller inventory names report-ci-status in place of aggregate-results and check-contract; the pin scan skips full-line YAML comments, since the composite link above is a comment that calls nothing; a new test asserts the id: report step keeps its name and that a later step fails on any contract or draft outcome but success.

Lines changed (git diff --numstat): workflow +43/-33, test +20/-3.

Verification

  • node --test ".github/scripts/**/*.test.cjs": 39 passed, 0 failed. The new fail-closed test failed when the gate's condition was changed to == 'failure', then passed once it was restored.
  • pwsh ./scripts/Test-ReleasePins.ps1: "Release and workflow pins are internally consistent."
  • actionlint on the workflow: no findings; lefthook pre-commit and pre-push hooks passed.

Related

🤖 Generated with Claude Code

https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C

The ci-status job's check-contract and aggregate-results steps become one
report-ci-status step (still named "Aggregate lane results", id report)
pinned at ci-workflows v0.76.3, plus a step that fails the job when the
contract or draft output is anything but success.

Kept: draft allow (the job had no "Refuse a draft" step), exempt-authors,
treat-skipped-as pass, rerun-contract-only-siblings true, step-name, and
the job's if, needs, permissions, runner and timeout.

The pin inventory test now names report-ci-status in place of the two
replaced composites, skips full-line YAML comments that link a
ci-workflows file, and asserts the fail-closed step.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 19, 2026 11:06
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T11:07:34.966195Z 41f3331 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-review reviewed 41f333187a4923de12bfee5778ff870e1d860563: 0 finding(s), 0 as inline comments.

Review of #588: move ci-status onto the report-ci-status composite

I found no findings. I read the full diff and PR context, the .claude/rules/pr-body-contract.md rule, and the jobBlock helper the new test relies on. I ran nothing: no tests, no actionlint, and no check of the composite's inputs or outputs against the pinned ci-workflows commit. The verification figures in the PR body are the author's claims and I did not confirm them.

What I checked:

  • Fail-closed gate: The new step Fail on the contract or draft policy uses !cancelled() && (steps.report.outputs.contract != 'success' || steps.report.outputs.draft != 'success'). An empty or renamed output therefore fails the job rather than passing it. This matches the old behaviour, where a failing contract step failed the job.
  • Step name: The merged step keeps name: Aggregate lane results and now carries id: report. This preserves the lookup a contract-only run uses to find the full run's writer step.
  • Inputs: treat-skipped-as: pass, rerun-contract-only-siblings, exempt-authors and step-name are all carried over. draft: allow replaces a draft step the job never had. The dropped yield-to-full-run and carry-forward-wait-seconds inputs are fixed by the composite at the same values, per the permalink in the diff.
  • New test: jobBlock returns the job's lines, and the exact-match assertions fit the YAML as edited. The assertions check that the id: report step follows the writer step, that the gate comes after it, and that the gate exits 1.
  • Pin scan: The scan now skips full-line YAML comments. A real uses: line is never a full-line comment, so the check does not accept anything it previously rejected. This is a rewording of the check rather than a loosening.
  • Stale references: The remaining check-contract and aggregate-results mentions, in docs/standards/issue-tracker.md and release/dependency-drift-review.json, are synced documentation and historical rationale. This PR does not need to touch them.

Loosened-check verdict: fail (default, no wrapper settings line was supplied); patterns: 0. The decision-record line was not supplied, so I did not check the citation requirement. No loosening found.

Closing issue: the PR uses Refs: melodic-software/ci-workflows#1138 and closes no issue, so there are no acceptance criteria to check.

Verifier dropped 0 of 0 candidates.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 41f333187a4923de12bfee5778ff870e1d860563: 0 finding(s), 0 as inline comments.

Security review: PR #588 (head 41f3331)

No security findings.

The change touches the ci-status hold steps in pr-require-checks.yml, so I read it as a trust-control change. I read only the diff and the two changed files. I did not fetch the pinned report-ci-status composite, so its behavior below is taken from the workflow's own comments.

  • Pin: the ci-workflows pin is unchanged at 9c5bedfbfdbdfe733b9ce4cd7ca80c1574bd4cb8 (v0.76.3). The composite is swapped from check-contract and aggregate-results to report-ci-status at the same SHA. No new unpinned or outside source is introduced.
  • Permissions: the job's permissions: block (contents: read, actions: write, pull-requests: write, statuses: write) is unchanged. Nothing widens the token's scope.
  • Token handling: the explicit token: ${{ github.token }} inputs are dropped, so the composite uses its own default. That default is not visible in the diff. No secret is exposed, and the job still runs with the same GITHUB_TOKEN permissions.
  • Contract and draft gate: the composite reports the contract and draft results as outputs instead of failing itself. The new step Fail on the contract or draft policy (if: !cancelled() && (steps.report.outputs.contract != 'success' || steps.report.outputs.draft != 'success'), then exit 1) restores the failure. It treats anything other than success as a failure, so an empty, renamed or missing output fails closed. If the report step itself fails, the job fails on its own exit code. The new test asserts the gate's position after the report step and its exit 1.
  • Weakened-hold check: the contract check keeps its failure on non-Conventional-Commits titles and do-not-merge labels, and the lane aggregation, yield-to-full-run and rerun-contract-only-siblings behavior is unchanged. exempt-authors is unchanged and still matches bot logins by exact equality. The only new setting is draft: allow. The workflow has no ready_for_review trigger and had no draft check before, so this does not weaken an existing hold.
  • Test file change: workflow-pin-metadata.test.cjs now skips full-line YAML comments when matching ci-workflows references. This is a test-only change. The expected-caller list is updated to match the new composite.

Manifest lines: none. No plugin manifests changed.

critical-findings: 0

@kyle-sexton
kyle-sexton merged commit f736251 into main Nov 19, 2026
30 checks passed
@kyle-sexton
kyle-sexton deleted the ci/report-ci-status branch November 19, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant