Skip to content

chore(dotnet): upgrade .NET SDK pin and fixture to 11.0.100 - #1175

Merged
kyle-sexton merged 1 commit into
mainfrom
chore/upgrade-dotnet-11
Nov 21, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
chore/upgrade-dotnet-11

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: fleet-wide .NET 11.0.100 SDK upgrade across shared standards and CI repositories.

Summary

Upgrade the pinned .NET SDK version, conforming .NET fixture target framework, and ecosystem metadata in ci-workflows from .NET 10 (10.0.400 / net10.0) to .NET 11 (11.0.100 / net11.0).

Fix

  • global.json: bump sdk.version from 10.0.400 to 11.0.100.
  • fixtures/dotnet/good/good.csproj: update <TargetFramework> from net10.0 to net11.0.
  • .claude/ecosystems/dotnet.yaml: update tool-pin.dotnet-sdk and install-hint to 11.0.100.

Verification

  • dotnet build fixtures/dotnet/good/good.csproj --configuration Release --nologo -p:RestoreLockedMode=true succeeded with 0 warnings and 0 errors under SDK 11.0.100.
  • dotnet format whitespace fixtures/dotnet/good/good.csproj --verify-no-changes and dotnet format style fixtures/dotnet/good/good.csproj --diagnostics IDE0055 --verify-no-changes exited 0 under SDK 11.0.100.
  • node --test .github/scripts/dotnet-sdk-required.test.cjs passed (2/2).

Related

  • Coordinated with the fleet .NET 11.0.100 upgrade in melodic-software/standards and downstream .NET repositories.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T19:35:46.897214Z 639438d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 639438d5c6cbc2783aae9a68080ee0fe705669b2: read 3 of 3 changed file(s); 0 finding(s), 0 as inline comments.

Security review: no security issues found

I read the whole diff for all 3 changed files. The pull request moves the .NET SDK version from 10.0.400 to 11.0.100 in three places: global.json, the target framework in the fixtures/dotnet/good/good.csproj test fixture (net10.0 → net11.0), and the version pin and install hint in .claude/ecosystems/dotnet.yaml. That matches what the PR description says.

What I checked:

  • SDK pin. The new value is still an exact version number, not a floating range. CI's setup-dotnet reads it from global.json and installs Microsoft's official SDK. The pin is no looser than before, and it is not a third-party or unpinned dependency. Pin hygiene belongs to the zizmor lane anyway, and there is nothing for it to flag here.
  • Trust controls and workflows. None of the files is on a trusted path. No workflow, action, permissions: block, token scope, trusted-actor list, kill switch or merge hold changed.
  • Instructions. No standing instruction was deleted, narrowed or weakened. dotnet.yaml changes only two version strings, and its commands and notes are unchanged.
  • Plugin manifests. None were touched.

No CRITICAL findings, so no hold.

critical-findings: 0

@github-actions

Copy link
Copy Markdown

claude-review reviewed 639438d5c6cbc2783aae9a68080ee0fe705669b2: read 3 of 3 changed file(s); 0 finding(s), 0 as inline comments.

Code review: .NET SDK pin upgrade to 11.0.100

No findings. This PR changes the .NET 10 pin to .NET 11 in three places that agree with each other:

  • global.json changes sdk.version from 10.0.400 to 11.0.100.
  • fixtures/dotnet/good/good.csproj changes TargetFramework from net10.0 to net11.0.
  • .claude/ecosystems/dotnet.yaml changes tool-pin.dotnet-sdk and install-hint to 11.0.100.

What I checked:

  • Leftover references. A search of the repository for 10.0.400, net10.0 and hardcoded dotnet-version values found none outside the changed lines.
  • Composite actions. The dotnet-build and dotnet-format actions keep dotnet-version empty by default, so actions/setup-dotnet reads the new pin from global.json (dotnet-build/action.yml#L16-L25). Neither action needs a change.
  • Lock file. The fixture has no packages.lock.json, so -p:RestoreLockedMode=true has no lock file keyed to the old target framework that could break the build.

Not independently verified. The PR's Verification section says the dotnet build, dotnet format and node --test commands passed under SDK 11.0.100. That is the author's claim. This lane has no shell, so I did not run them.

Closing issue. The PR says "No related issue", so I had no acceptance criteria to check against.

Loosened checks. Changing an SDK pin is a pin or repin, which the criterion treats as a friction hold. That is not a loosening. Loosened checks would be marked: fail (default; the prompt had no loosened_check_verdict: line); patterns: 0 (the prompt had no loosened_check_patterns: line). The prompt also had no loosened_check_decision_record: line, so the citation requirement was not checked.

Not applicable here:

  • Path-scoped rules: the only rule file, .claude/rules/pr-body-contract.md, has no paths: frontmatter that matches a changed file.
  • Plugin manifests: none changed.
  • Paved paths: I did not resolve the standards index. None of the changed files adds a second way to do something.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 21, 2026
Merged via the queue into main with commit 98d9f35 Nov 21, 2026
38 checks passed
@kyle-sexton
kyle-sexton deleted the chore/upgrade-dotnet-11 branch November 21, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant