Skip to content

ci(dependabot): let Dependabot bump the ci-workflows action pins - #457

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/dependabot-first-party-actions
Nov 15, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/dependabot-first-party-actions

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: the first-party action pin work, tracked in the owner's audit session.

Summary

This repository's melodic-software/ci-workflows composite-action pins sat on v0.39.8 and on one untagged commit,
and Dependabot ignored every ci-workflows reference, so the pins moved only by hand. After this change Dependabot
keeps them on the newest release and the auto-merge caller merges that bump with nobody opening, marking ready or
merging a pull request.

Fix

  • .github/workflows/pr-require-checks.yml: the three locally owned pins (lychee-offline,
    pr-require-checks/check-contract, pr-require-checks/aggregate-results) move to the v0.74.0 release commit
    944d346c487c79eaf85dff752586fb59b0f5c539, each with a # v0.74.0 comment.
  • .github/dependabot.yml, the github-actions entry: the ignore of melodic-software/ci-workflows/* becomes an
    ignore of the one pin in the sync-managed pr-check-managed-files-hosted.yml; first-party releases are excluded
    from the cooldown; a first-party-actions group moves every ci-workflows pin in one pull request. The
    dotnet-sdk and nuget entries are unchanged.

The reusable-workflow callers stay at @main. The ignore's stated reason, a lockstep for pinned reusable callers,
ended when those callers moved to @main (standards runner-policy README, "Contract revision lockstep"). The
auto-merge caller arms the bump from the synced Dependabot policy copy (fastTrack.own), present here since #456.

Verification

  • This pull request's own CI Status runs the three actions at v0.74.0.
  • standards components/dependabot-policy/dependabot-policy.mjs --root .: Dependabot policy passed.
  • No file outside .github/workflows names the moved pins; the synced runner-policy copy lists reusable-workflow
    commits only.
  • The same change is merged in agent-plugins (chore: sync standards components #143 there) and provisioning (#1028, #1031 there).

Related

🤖 Generated with Claude Code

The three ci-workflows action pins in pr-require-checks.yml move to the
v0.74.0 release commit with a `# v0.74.0` comment. Dependabot then keeps them
current: the blanket ignore of melodic-software/ci-workflows becomes an ignore
of the one pin in the sync-managed pr-check-managed-files-hosted.yml,
first-party releases skip the cooldown, and they move together in a
`first-party-actions` group that the auto-merge caller arms.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T18:36:37.346610Z ed7baa8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed ed7baa8b3db652fc0ba5766ab4e09fc3315d2e1f: 0 finding(s), 0 as inline comments.

Security review, PR #457 at ed7baa8

No security findings.

critical-findings: 0

I read the whole diff (.github/dependabot.yml and .github/workflows/pr-require-checks.yml) and the files it touches. I did not review the rest of the repository.

What the change does

  • It moves the melodic-software/ci-workflows composite-action pins in pr-require-checks.yml to the 944d346… SHA, commented # v0.74.0. The three pins are lychee-offline, check-contract and aggregate-results. All three are still full-SHA pins.
  • aggregate-results was previously pinned to an untagged SHA (ac4d878). It now sits on a tagged release, which is a slight improvement.
  • dependabot.yml stops ignoring all ci-workflows/* refs. It adds a first-party-actions group (melodic-software/*), drops the 3-day cooldown for those refs, and still ignores the sync-managed check-managed-files pin.

Checked, not a finding

  • Trust controls. The change touches none of the controls this lane lists. pr-automerge-dependabot.yml is unchanged. It still calls the org reusable @main, and that reusable alone decides which Dependabot PRs get auto-merge armed. Token scopes, permissions: blocks, the trusted-trigger check, the kill switch and merge-hold scripts are all untouched. This repository has no .github/actions/ or merge-holds.mjs.
  • Widened auto-merge surface. After the change, Dependabot PRs for first-party ci-workflows pins can be auto-merged without a soak. The only actor who can influence that is the owner's own ci-workflows releases. Under the owner-only threat model (the "Owner threat model: throughput phase" section of this skill) that is not an outside attacker. A required CI Status check and the reusable's tier logic still gate the merge.
  • Whether first-party-actions auto-merges majors. The new group has no update-types restriction, so a major bump could land in it. The workflow header says the arming reusable arms only minor and patch bumps. The arming logic lives in the external reusable, so I could not verify it from this diff. Worth confirming against the standards dependabot-policy.
  • Cooldown removal for first-party refs. This loosens the supply-chain soak. It is deliberate, per the fastTrack.own comment, and is the Actions pin-hardening area deferred to zizmor and the owner's policy.
  • SHA existence. I could not confirm over the network that 944d346c… is the commit behind tag v0.74.0, because the gh api call was not approved in this session. This is verification I did not do, not a finding.

No instruction-surface deletions and no plugin manifests are in the diff. The lane footer applies only to inline comments, and I posted none.

@github-actions

Copy link
Copy Markdown

claude-review reviewed ed7baa8b3db652fc0ba5766ab4e09fc3315d2e1f: 0 finding(s), 0 as inline comments.

Review of PR #457: ci(dependabot): let Dependabot bump the ci-workflows action pins

No findings. I read the diff, the PR context and the full .github/dependabot.yml. I also read the synced policy copy at .github/standards/dependabot-policy/policy.json and grepped the repo's uses: lines. I did not run the standards policy checker or CI myself, so the PR body's "Dependabot policy passed" and "own CI Status runs v0.74.0" lines are author-claimed and unverified by me.

What I checked:

  • Dependabot config shape. cooldown.exclude sits at the right indent, under cooldown beside default-days. The ignore entry now covers only melodic-software/ci-workflows/.github/actions/check-managed-files. That is the one pin still in pr-check-managed-files-hosted.yml:118, at v0.71.0 and owned by the standards sync. The first-party-actions group comes before vendor-actions and github-actions, so first-match grouping is correct.
  • Consistency with the synced policy. The policy copy has cooldownDays.own: 0 and fastTrack.own: ["melodic-software/*"]. Its basis text (owner decision 2026-11-15) covers auto-merging own releases below 1.0 with only the second or third component changed. autoMerge.excludeSemverMajor is true, so a future major of ci-workflows would not auto-merge even though the first-party-actions group has no update-types filter. The config comment and the policy agree.
  • Pin moves. The three pins in pr-require-checks.yml (lines 155, 188, 204) now share the commit 944d346c487c79eaf85dff752586fb59b0f5c539 with a # v0.74.0 comment. A grep shows no other pinned melodic-software/* actions that the new group would sweep up. The reusable-workflow callers stay at @main.
  • PR body contract. The body opens with No related issue: <reason> and has Summary, Fix, Verification and Related sections. I saw no line that would start with committer after the 72-column wrap.
  • Skipped criteria. I found no closing issue, no plugin manifests, no settled threads and no prior findings. I did not resolve a standards index for paved paths.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton merged commit ec1ac9d into main Nov 15, 2026
10 checks passed
@kyle-sexton
kyle-sexton deleted the ci/dependabot-first-party-actions branch November 15, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant