Skip to content

ci(dependabot): correct the auto-merge lane comments for first-party actions - #458

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/automerge-first-party-comments
Nov 15, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/automerge-first-party-comments

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: the first-party action pin work, tracked in the owner's audit session.

Summary

Two comments described the Dependabot auto-merge lane as it was before the first-party pins moved to Dependabot.
This change corrects them. Comments only: no trigger, permission, group or pin changes.

Fix

  • .github/workflows/pr-automerge-dependabot.yml, header: the lane also arms melodic-software/* bumps, through
    the synced Dependabot policy copy (fastTrack.own), not only the vendor publishers.
  • .github/dependabot.yml: a pull request the lane does not arm takes the review tier (an AI review lane's merge
    verdict), where the comment said a person merges it; and, where the comment covers majors, a first-party major
    stays in first-party-actions instead of falling through to the catch-all group.

Verification

  • ci-workflows pr-automerge-dependabot.yml header on main: with the synced copy at
    .github/standards/dependabot-policy/policy.json, the allowlist is the copy's tier: auto publishers plus its
    fastTrack github-actions and own globs; "a grouped PR with one major bump ... is skipped".
  • standards components/dependabot-policy/policy.json on main: fastTrack.own is melodic-software/*.
  • standards components/dependabot-policy/README.md:183 on main: "No Dependabot pull request waits on a human."
  • git diff touches comment lines only.

Related

🤖 Generated with Claude Code

…actions

The auto-merge caller also arms melodic-software/* bumps when the base
holds the synced Dependabot policy copy, and a first-party major stays in
the first-party-actions group, where the lane does not arm it.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T21:38:32.007085Z d4230f8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-review reviewed d4230f8caa9cf94c3bf14ff9e2e5f286bc54c6d7: 0 finding(s), 0 as inline comments.

No findings. The PR changes comment lines only, in .github/dependabot.yml and .github/workflows/pr-automerge-dependabot.yml.

I checked the new comment text against the config in the repo, and each statement matches it:

  • First-party major: first-party-actions has no update-types filter, so a first-party major stays in that group, as the new comment says.
  • Vendor major: vendor-actions is limited to [minor, patch], so a vendor major falls through to github-actions, as the comment says.
  • Own releases: the melodic-software/* pattern and the cooldown exclusion for melodic-software/ci-workflows/* match the workflow header's wording about the organization's own releases.
  • Synced policy copy: .github/standards/dependabot-policy exists in the repo, so the header's reference to it is valid.

I could not read the ci-workflows or standards repos from here. I did not check the claims that the lane skips a grouped PR with a major bump, or that fastTrack.own is melodic-software/*. The PR body states both; I treated them as author-claimed and unverified.

  • PR body contract: the body has No related issue: <reason> plus the Summary, Fix, Verification and Related sections. No committer-leading line.
  • Closing issues: none to check.
  • Plugin manifests: none touched.
  • Settled threads / prior findings: none supplied.

Verifier dropped 0 of 0 candidates.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed d4230f8caa9cf94c3bf14ff9e2e5f286bc54c6d7: 0 finding(s), 0 as inline comments.

No security findings.

The PR changes only comment text in two files, .github/dependabot.yml and .github/workflows/pr-automerge-dependabot.yml. It does not touch any trigger, permissions: block, uses: pin, group definition, token request, trusted-actor list or merge-hold script. The dependabot groups and the automerge caller are as they were, so the automerge lane's reach is unchanged.

I read the new comments as a description of existing behavior. They say first-party major bumps stay in first-party-actions and are not armed for auto-merge, and that the synced policy copy also covers the organization's own releases. Neither comment changes what is armed. I did not check the reusable workflow or the policy in melodic-software/standards that enforce this. If the comments are wrong, the fix belongs there, not in this diff.

critical-findings: 0

@kyle-sexton
kyle-sexton merged commit 0c76e8a into main Nov 15, 2026
10 checks passed
@kyle-sexton
kyle-sexton deleted the ci/automerge-first-party-comments branch November 15, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant