Skip to content

ci: run ci-status through the report-ci-status composite - #483

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/report-ci-status
Nov 18, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/report-ci-status

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Refs: melodic-software/ci-workflows#1138

Summary

Rollout of ci-workflows#1138: the ci-status job now runs the shared report-ci-status composite (ci-workflows#1139, v0.76.0, pinned at ebd0e3b) instead of its own check-contract and aggregate-results steps. CI Status stays the job's name and the single required check, and its behavior is unchanged. No product code, CHANGELOG or release surface changes.

Fix

  • ci-status steps: one report-ci-status step named Aggregate lane results (id: report), then "Fail on the contract or draft policy", which fails on any contract or draft outcome other than success (fails closed).
  • Kept: the job's if: always(), draft: allow (the job never refused a draft; ready_for_review stays in the triggers), exempt-authors: 'dependabot[bot],melodic-standards-sync[bot]', treat-skipped-as at the default fail (the old step set fail), results from join(needs.*.result, ' '), needs, permissions, runner and timeout.
  • The composite fixes yield-to-full-run: 'true' and carry-forward-wait-seconds: '0' (action.yml L128-L129) and keeps rerun-contract-only-siblings at true: the values this job set before. Comments now describe the composite instead of inputs the file no longer sets.
  • Concurrency: unchanged; a push already falls back to github.run_id.
  • Lines: 42 removed, 44 added (git diff --numstat); the added lines are comments recording the composite's fixed behavior.

Verification

  • actionlint .github/workflows/pr-require-checks.yml: no findings.
  • CI Status on this PR's head: see the checks. The label proof was run once for the rollout, on agent-automations#73.

Related

🤖 Generated with Claude Code

https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C

The ci-status job now runs the shared report-ci-status composite
(ci-workflows v0.76.0) instead of its own contract and aggregation
steps, then fails on the contract or draft outputs. CI Status keeps its
name and behavior: drafts are allowed, as before.

Refs: melodic-software/ci-workflows#1138

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 18, 2026 20:28
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T20:29:36.817841Z 398bf92 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-review reviewed 398bf926fa6719e5930f3ecd24224fad47074738: 0 finding(s), 0 as inline comments.

No findings. I reviewed the one changed file, .github/workflows/pr-require-checks.yml.

What the change does. The ci-status job drops its check-contract and aggregate-results steps and runs a single report-ci-status composite at v0.76.0, pinned by full SHA ebd0e3b. A new final step, "Fail on the contract or draft policy", fails the job unless the composite's contract and draft outputs are both success.

What I checked in the diff.

  • The job keeps if: always(), the needs list, results: join(needs.*.result, ' '), the permissions block, the runner and the timeout.
  • The step keeps the name Aggregate lane results. The comment explains that a contract-only run finds the full run's writer step by that name.
  • exempt-authors is unchanged and still matches bots by exact name.
  • The new draft: allow input matches the old behaviour, where the job never refused a draft.
  • The follow-up step uses !cancelled() and compares both outputs to 'success'. An empty or renamed output therefore fails closed.
  • treat-skipped-as is now left at its default of fail. The old step set fail explicitly, so behaviour is the same, assuming the composite's default is fail as the PR states.
  • The yield-to-full-run and carry-forward-wait-seconds inputs are no longer set here. The PR says the composite fixes them at the values this job used before.

Not verified. I could not read the composite's action.yml. These claims are author-stated and unconfirmed by me:

  • the composite's input names (step-name, results, exempt-authors, draft);
  • its output names (contract, draft);
  • its default for treat-skipped-as;
  • its fixed values for yield-to-full-run and carry-forward-wait-seconds.

The author's actionlint run and the CI Status result on this head are also unconfirmed by me.

Other checks.

  • PR body contract (.claude/rules/pr-body-contract.md): the body uses Refs: plus the Summary, Fix, Verification and Related sections, as the rule asks. No body line would start with committer after the squash wrap.
  • Closing issue: none. The PR links ci-workflows#1138 with Refs: and closes nothing, so there are no acceptance criteria to check.
  • Loosened check: the prompt gave no loosened_check_* lines, so I used the default of fail with no consumer entries, and the citation requirement was not checked. The diff makes no change that loosens a check. Skipped lanes still fail by default, and the job still fails on the contract and draft outputs.
  • Manifest items: no plugin manifest is changed.
  • Settled threads and prior findings: neither file was provided.

Verifier dropped 0 of 0 candidates.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 398bf926fa6719e5930f3ecd24224fad47074738: 0 finding(s), 0 as inline comments.

Security review: PR #483, head 398bf92

No security findings. The diff changes only .github/workflows/pr-require-checks.yml. That file is on the hold paths, so I judged the change as a trust-control touch and found no widening.

  • Pinning: the report-ci-status composite is pinned to a full commit SHA (ebd0e3bed99ae1365fcb4ef47ce97cfa745fcf2f, labelled v0.76.0), the same kind of pin as before. It replaces check-contract and aggregate-results, and all three come from the same melodic-software/ci-workflows repository. No unpinned or off-repository source was added.
  • Token scope: the job's permissions: block is unchanged (contents: read, actions: write, pull-requests: write, statuses: write). The explicit token: ${{ github.token }} input was removed, so the composite must default to the job's GITHUB_TOKEN. I could not read the composite's source (the gh api call was refused), so I could not confirm that default. The job permissions bound any token it uses, and no secret or wider credential is passed.
  • Gate behaviour: the gate stays fail-closed.
    • results is still derived from needs.*.result.
    • treat-skipped-as stays at its default fail.
    • The new "Fail on the contract or draft policy" step fails the job unless both steps.report.outputs.contract and steps.report.outputs.draft equal exactly success, so an empty or renamed output also fails.
    • The old !cancelled() guard on the aggregation step is no longer needed because the contract and aggregation now run in one step. The new follow-up step has its own !cancelled() guard.
  • Draft policy: draft: allow matches the old behaviour, since the comment says the job never refused drafts. Under the owner's throughput-phase threat model, a weakened friction hold would not be a finding in any case.
  • Composite-fixed values: yield-to-full-run: 'true' and carry-forward-wait-seconds: '0' are now fixed inside the composite, per the comment's link to its source. I did not verify them. The step name "Aggregate lane results" is kept so a contract-only run can find the full run's writer step. A mismatch there would break carry-forward and make runs go red; it would not let a bad run through.
  • Untrusted input: none reaches a shell. The only run: step echoes a fixed string. exempt-authors is a literal list of two bot logins, matched by equality as before.

critical-findings: 0

@kyle-sexton
kyle-sexton merged commit 5ab8220 into main Nov 18, 2026
12 of 17 checks passed
@kyle-sexton
kyle-sexton deleted the ci/report-ci-status branch November 18, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant