Skip to content

chore: remove unnecessary section-divider comments under ADR 0110 - #501

Merged
kyle-sexton merged 1 commit into
mainfrom
chore/remove-unnecessary-comments
Nov 21, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
chore/remove-unnecessary-comments

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Refs: melodic-software/control-hub#12

Summary

Comment-removal sweep of melodic-software/claude-code-account-rotation under ADR 0110 (necessary posture) and REVIEW.md. Code-file count: 358 tracked code files (13 sync-managed code files including pr-review*-hosted.yml, 6 under .claude/, and 339 locally-owned C#, JS, shell, and workflow files reviewed).

Fix

Removed 7 # --- ... --- section-divider banners (14 deleted lines including adjacent empty # / blank lines) from tests/acceptance/wsl-switch-acceptance.sh while keeping every explanatory prose block directly below them intact.

Preserved untouched:

  • All shebangs, lint/schema directives, SHA-pin version comments, C# XML docs (///), sync-managed files, .github/workflows/pr-review*.yml, .claude/**, and all concurrency/security/UI/single-holder rationale comments across C# source/tests, src/ClaudeCodeAccountRotation.App/wwwroot/app.js, tests/acceptance/check-single-holder.sh, and workflows.

Verification

  • git diff verified strictly comment/blank-line deletions (1 file changed, 14 deletions(-)), zero code tokens modified.
  • bash -n tests/acceptance/wsl-switch-acceptance.sh exited 0.
  • Full CI and review lanes verified on this PR.

Related

  • Refs: melodic-software/control-hub#12

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T20:17:54.816409Z b9bc0ca PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed b9bc0ca3513c7b6239ba49bb286488640ef04337: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Security review: PR #501

No security issues found.

This pull request changes one file, tests/acceptance/wsl-switch-acceptance.sh. It deletes 14 lines: seven # --- ... --- section-divider banners plus the empty # and blank lines beside them. No executable line changed. Every explanatory comment below the dividers is still there, including the warning that nothing is ever killed by name (so the operator's own instance survives) and the note that only SHA-256 fingerprints of the seeded test credentials are compared or printed.

  • Instruction-surface lens: the deleted lines are section labels with no rules in them. No standing instruction is deleted, narrowed or softened.
  • Trust controls / trusted paths: the file is not a trust control or a merge-hold path and matches no trusted-path glob.
  • Plugin manifests: none touched.
  • Prior findings: none (first review, not blocking only).

critical-findings: 0

@github-actions

Copy link
Copy Markdown

claude-review reviewed b9bc0ca3513c7b6239ba49bb286488640ef04337: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Code review: no findings

The pull request deletes 7 # --- <name> --- section-divider banners (14 lines, counting the empty # and blank lines next to them) from tests/acceptance/wsl-switch-acceptance.sh. I read every hunk. Each one removes only a divider line and its blank or empty # line. No code changed. Every rationale comment block below a divider is still there, such as the one explaining why nothing is killed by name and the one explaining why fingerprints are SHA-256 only. So the REVIEW.md rule about deleted comments that recorded a "why" is not broken: the banners only labelled sections and recorded no reasoning.

  • Closing issue: none. The body only references melodic-software/control-hub#12 with a Refs: line, so there are no acceptance criteria to check.
  • Path-scoped rules: .claude/rules/pr-body-contract.md concerns the PR body. The body opens with a Refs: line and has the Summary, Fix, Verification and Related sections, so it complies.
  • Loosened checks: nothing was loosened. The file is an acceptance test, but no assertion, threshold or step changed. Loosened checks would be marked: fail (default: the prompt had no loosened_check_verdict: line); patterns: 0 (the prompt had no loosened_check_patterns: line). The prompt also had no loosened_check_decision_record: line, so I did not check the citation requirement.
  • Verification: the PR's bash -n run and its git diff stat are the author's claims. I did not run them myself (this lane has no shell). I did read the diff and confirmed it only deletes comments and blank lines.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton merged commit 9095d06 into main Nov 21, 2026
22 checks passed
@kyle-sexton
kyle-sexton deleted the chore/remove-unnecessary-comments branch November 21, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant