Skip to content

feat(planning): hand a design principle worth codifying to /corrections:codify #17174

Description

@kyle-sexton

Parent

Refs #15703
Source: #16029, part 2 of #15729. The list recorded in #16602 gives /planning:design ("suggests codifying principles in the project's own rules files (SKILL.md:294, :424-425)") the route "call /corrections:codify, presence-gated, with the strongest-first fallback".

Depends on

Outcome

When design discussion surfaces a project-wide principle, /planning:design today suggests "codifying" it in the project's own rules files, which picks the instruction rung for every principle. After this change it hands each principle to /corrections:codify when it is available, which picks the strongest rung that can decide it, with the shared strongest-first fallback when it is not. When to suggest it (during the review round and as discussion surfaces it) does not change.

Demo: with a corrections stand-in plugin loaded, a design session that settles "the domain layer never imports the persistence layer" ends with the principle handed to /corrections:codify, not with a suggested line in a rules file.

Where the text changes

Line numbers as read on main at a483a2c1; they may move.

File and lines Present wording Change
plugins/planning/skills/design/SKILL.md:294-295 (review action, step 4) "When discussion surfaces project-wide principles, suggest codifying them in the project's own rules." Hand each principle to /corrections:codify (gate plus shared fallback)
same file, :424-426 ("Codify rules when discovered") "When discussion surfaces a project-wide principle, suggest codifying it immediately in the project's own rules files" Same hand-off; keep "immediately"

Call form: /corrections:codify "<the principle>". A boundary principle may also suit /architecture:enforce-boundaries, which codify's own ladder routes to; this item adds no second route.

Decisions

Key interfaces

  • "A skill that carries no ladder copy calls /corrections:codify, presence-gated, with a two-sentence strongest-first fallback. Only a skill that applies its own selection rule holds a synced copy and gets a row in the ladder's Selection rules table." (List enforcement-placing skills and give each one route to the ladder #15729)
  • The seam-phrasing convention: an availability gate, a stated fallback beside it, the plugin named and never the marketplace.

Done when

  • Both sites hand a project-wide principle to /corrections:codify behind the availability gate, followed by the shared fallback, and no longer send it to rules files by default.
  • The skill gains no ladder copy or Selection rules row, and no rung list is restated.
  • The pull request body names the existing case whose run reads the changed text, or says none does (no current design-* case appears to). The lane runs no eval.
  • A changelog fragment under .changes/planning/ describes the change.
  • AC10: no new enforcement-placing skill is added here.
  • Open the pull request with Closes this issue in its body, then stop: the lane adds no label.

Host steps (eval case, tracker-output quote) are tracked in #17200.

After the pull request opens (host session, not the lane)

The pull request stays held with do-not-merge for the eval; a host session runs only the eval and posts its record; the merge lane releases the hold when the record matches the head.

  • Hold line: the hub's sweep (or a host session) adds do-not-merge and posts, from a listed human's account, a comment with the line <!-- pr-hold reason=eval --> on a line of its own.
  • Run budget. List enforcement-placing skills and give each one route to the ladder #15729 asks for "that skill's cases on the opus and sonnet aliases, three runs per side, and no more than 240 runs per plugin". The owner decision of 2026-11-16 in the owner-decisions record (hop 4 Q15, which names List enforcement-placing skills and give each one route to the ladder #15729, amended by hop 7 Q3) replaces the run counts: per changed skill, one targeted before-and-after case on sonnet at 3 runs a side; opus runs only to confirm a sonnet loss; a new case gets a 1 to 3 run smoke first. Select cases with --case, use --runs 3 and a --max-cost-usd ceiling, and start no batch after a usage-limit error. Ceiling for this plugin: 1 skill x (3 smoke + 6 sonnet + 6 opus confirm) = 15 runs, under the parent's 240.
  • Control: the replaced wording is a partial cut, so the pull request body carries a detection-control result. No paired no-loss compare (#15703 comment 6906800940).
  • On a LOSS reading: a trace read of each dropped case and an opus confirm; only a loss traced to the changed text counts.
  • Record: the verdict and the control result go into the pull request body. When the run is VALID and shows no loss, the host session posts, from a listed human's account, a comment with the line <!-- eval-pair verdict=no-loss validity=VALID head=<40-hex head SHA> --> naming the current head, keeping "do not merge" and do-not-merge out of that comment (docs/contracts/loop-lane/README.md, "Cross-lane PR hold"). A loss or a run that is not VALID leaves the hold in place; say so on the pull request.
  • Release: pr-merge's scheduled step "Release eval holds whose record matches the head" removes do-not-merge once that record names the current head and no other hold stands. A push after the record needs a new record.

Out of scope

Related

Activity

  1. added
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Nov 18, 2026
  2. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 18, 2026
  3. github-actions commented on Nov 18, 2026

    @github-actions
    Contributor

    Size: Small
    Complexity: Low
    Uncertainty: Known
    Flags: none
    Blocked by: none
    Blast radius: two passages in plugins/planning/skills/design/SKILL.md plus one changelog fragment under .changes/planning/; read by anyone running /planning:design.
    Reversible: yes; revert the text edit and the fragment.
    Open questions: none
    Understood: at the two sites where /planning:design suggests codifying a project-wide principle in rules files, hand it to /corrections:codify behind the availability gate, followed by the shared fallback wording. The skill gets no ladder copy or Selection rules row. The issue text pins the outcome, the wording and the done-when. The eval and tracker-output host steps now sit in #17200, so the remaining items are lane-checkable. Related open siblings: #17175, #17162, #17160, #17159 and #17158. They apply the same hand-off to other skills and are not duplicates. No merged pull request fixes this yet.

    Automated triage. A maintainer reviews it.

  4. removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 18, 2026
  5. melodic-automation-lanes commented on Nov 18, 2026

    @melodic-automation-lanes
    Contributor

    Not admitted to the issue lane: its done-when asks for what an unattended lane run cannot perform: item 3 (tracker-output: "The pull request body quotes the sentence that picked a mechanism from a priv..."), item 4 (eval: "One new eval case loads a corrections stand-in plugin, in the shape of sessio..."); recommended split: keep the other items here as the admissible issue and move these to a child issue for the host queue (host-run). Admission takes the issue once each of those is met, when intake triages it again (.github/actions/resolve-config/admission-rules.json).

  6. melodic-automation-lanes commented on Nov 18, 2026

    @melodic-automation-lanes
    Contributor

    {"v":1,"actor_id":337595936,"title_sha256":"6ac4306bbbc354d088e43be7a6f6629c7d3379be0e86fdb568edfe214d3387d0","body_sha256":"16fcd03d07b2d0d13128f0fdecfce73dc7aa861a477d0856beebc0ced090b81a"}

  7. melodic-automation-lanes commented on Nov 18, 2026

    @melodic-automation-lanes
    Contributor

    {"v":1,"actor_id":337595936,"title_sha256":"6ac4306bbbc354d088e43be7a6f6629c7d3379be0e86fdb568edfe214d3387d0","body_sha256":"16fcd03d07b2d0d13128f0fdecfce73dc7aa861a477d0856beebc0ced090b81a"}

  8. github-actions commented on Nov 18, 2026

    @github-actions
    Contributor
    No description provided.
  9. melodic-automation-lanes commented on Nov 19, 2026

    @melodic-automation-lanes
    Contributor

    This records a re-fire of an earlier refusal, not a new refusal. The lanes kill switch stopped run 44424239090, the work-resolve-issue run that agent-ready started, before it finished; that run ended at 2026-11-19T00:51:30Z. work-unblock has now removed and added agent-ready back to start a fresh run. A kill-switch refusal is no fault in this issue or the lanes, so it never counts against later re-fires; after limits.limit-stops-per-issue of them since a person last added agent-ready or a run last reported, work-unblock waits the same limits.stranded-backoff-hours kill-switch hours after each refused run before re-firing it, never longer.

  10. melodic-automation-lanes commented on Nov 19, 2026

    @melodic-automation-lanes
    Contributor

    This records a re-fire of an earlier stop, not a new one. The start gate stopped run 44553347509, the work-resolve-issue run that agent-ready started, before any model turn, because the GITHUB_TOKEN budget was under its start-gate share, or the window was projected to have under its start-project share of the header's limit left by the run's expected end (github-token start-gate, start-project and start-run-minutes in rate-limits.json; the run's start-gate notice names which); that run ended at 2026-11-19T15:20:42Z. work-unblock has now removed and added agent-ready back to start a fresh run. A budget stop is the lanes' load, not a fault in this issue: it never counts toward limits.limit-stops-per-issue or the kill-switch wait.

  11. github-actions commented on Nov 19, 2026

    @github-actions
    Contributor
    No description provided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.

    Type

    Fields

    Work status

    needs-triage

    Priority

    medium

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions