Repository navigation
Closed
Copy link
Description
Part 2 of 5 of #16755. Refs #15703.
Problem
testing:diagnose and testing:plan give .NET-only traps, name single runners' filter and shuffle flags as the next step, and use .NET/Blazor rows as examples of neutral rules.
Rows (5: all R11)
| Row | Rule | Kind | Cited at (as of 5b66a7f) | Fact |
|---|---|---|---|---|
| F0436 | R11 | K4 | plugins/testing/skills/diagnose/SKILL.md:96 |
.NET framework-traps gotcha (MTP options, exit codes, global.json) |
| F0437 | R11 | K4 | plugins/testing/skills/diagnose/context/investigate.md:11-19 |
WebApplicationFactory singleton, MTP --nologo/--no-banner, sync-over-async rows |
| F0438 | R11 | K5 | plugins/testing/skills/diagnose/context/investigate.md:21,25 |
xUnit filter, pytest -k, vitest, pytest-randomly, go test -shuffle with links |
| F0439 | R11 | K7 | plugins/testing/skills/diagnose/context/loop.md:58-66 |
Step 5 dotnet test block "illustrative (.NET)" |
| F0440 | R11 | K7 | plugins/testing/skills/plan/SKILL.md:59-63,70-86 |
WebApplicationFactory, Testcontainers/Docker Compose, Blazor rows and .NET/xUnit name placeholders |
Files
- Cut:
plugins/testing/skills/diagnose/SKILL.md,plugins/testing/skills/diagnose/context/investigate.md,plugins/testing/skills/diagnose/context/loop.md,plugins/testing/skills/plan/SKILL.md. - Outside references at d46efa9: none by full path.
Rules this part follows (from #16755, rules revision 5)
- R11 (shipped knowledge): model-read K2, K3, K4, K5 or K7 text. Generic text replaces it only at a routing site where the skill still takes a language-specific step; anywhere else it is deleted with no replacement. An item kept only because a removed item consumes it goes in the same pull request.
- R4 (consumer default): the value picks a tool or library for the consumer. It goes: no bundled default survives (ADR 0101 decision 2, "Ship no bundled default"); the choice is resolved from the consumer through
docs/contracts/ecosystem-resolution/. - R8 (measured fact): cut it like the other rows and mark it in the pull request body as pending its targeted case; the host session's eval (below) decides whether it comes back, annotated
portability-ok: measured <case-id>. - AC1's named exceptions are the kept classes of ADR 0101 (
docs/adr/0101-resolve-ecosystem-specifics-from-the-consumer-repository.md, Decision and the 2026-11-17 amendment). Bundled defaults that pick a tool, command or library are retired wherever they appear (Interview Q32, D4 of the Brief). - Line numbers below were read at
5b66a7faand may have moved; find each row by its cited text.
After the pull request opens (host session, not the lane)
The lane opens the pull request with Closes this issue and stops; it adds no label. The pull request stays held for the eval:
- Hold line: a sweep or host session adds
do-not-mergeand posts, from a listed human's account, a comment with<!-- pr-hold reason=eval -->on a line of its own. - Targeted case per changed skill: one before-and-after case on
sonnetat 3 runs a side,--case,--runs 3, a--max-cost-usdceiling;opusonly to confirm a sonnet loss; a new case gets a 1 to 3 run smoke first; start no batch after a usage-limit error (owner decision of 2026-11-16). - Controls: the owner's Q53 decision of 2026-11-17 (owner-decisions.md L202) reads: "each cut pull request is gated on a no-loss compare alone, with no wrong-text side". It supersedes Cut the model-read ecosystem specifics from testing #16755's Controls line and its AC7 sentence ("each partial cut carries a detection-control result"). A whole-page deletion still states its predicted outcome in the pull request body before the first batch, and the record says the case cannot detect wrong text.
- On a LOSS reading: a trace read of each dropped case and an
opusconfirm; only a loss traced to the changed text counts. - R8 rows: the row's targeted case with and without it; on a
case dropor a mean fall of 0.15 or more without it, restore the row annotatedportability-ok: measured <case-id>; a deterministic grader states before the run in how many of n runs it must fail. - Record: on a VALID no-loss run, post from a listed human's account
<!-- eval-pair verdict=no-loss validity=VALID head=<40-hex head SHA> -->naming the current head, with no "do not merge" text (docs/contracts/loop-lane/README.md, "Cross-lane PR hold"). pr-merge's "Release eval holds whose record matches the head" step (.github/scripts/pr-merge/release-eval-hold.mjs) then removesdo-not-merge; a later push needs a new record.
Out of scope
Rows outside this part's table, the parent's kept rows, every other plugin, toolchain's bundled defaults (#15733), and widening the portability gate (#15732).
Done when
- Every row in this part's table is cut or replaced at a routing site; a row whose cited text is already gone on
mainis listed as GONE. - The pull request body states this part's row count (5) and lists every row id with its rule and outcome.
- Each R11 row's script-reader search is quoted in the pull request body; a row whose file a script reads is not cut, and is listed in the pull request body under a
Script readersheading. - The pull request body names, for diagnose and plan, the existing eval case that reads the cut text, or says none does.
- The pull request body says, for each changed file, whether the cut deletes the whole page or part of it.
- AC10: no new enforcement-placing skill is added.
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Work status
needs-triage
Priority
medium
Activity
github-actions commentedon Nov 21, 2026
Size: Medium
Complexity: Low
Uncertainty: Known
Flags: none
Blocked by: none
Blast radius: four testing-plugin skill and context pages (diagnose SKILL.md, investigate.md, loop.md, plan SKILL.md), read by models running testing:diagnose and testing:plan.
Reversible: yes; revert the pull request, or restore a row with a
portability-ok: measured <case-id>annotation.Open questions: none
This is part 2 of 5 of #16755. It asks to cut or replace the five R11 rows (F0436 to F0440) at routing sites, with the pull request body listing the row count, script-reader searches, eval cases and whole-or-part deletion per file. The table, rules and done-when are exact. The host-session eval after the pull request opens is outside the lane and does not hold triage. No duplicate or merged fix found; sibling parts such as #17740 cover other files.
Automated triage. A maintainer reviews it.
melodic-automation-lanes commentedon Nov 21, 2026
{"v":1,"actor_id":337595936,"title_sha256":"22a2d23a56fb17b8bf536742afce922ad9eb990fef1db9bb7a5bb3ecd1160ce0","body_sha256":"cbe6aef27b6a303139b8330c0842c129c0eed93da1072f248cf47c86346062d4"}
github-actions commentedon Nov 21, 2026
github-actions commentedon Nov 21, 2026