Repository navigation
Closed
Copy link
Description
Part 4 of 5 of #16755. Refs #15703.
Problem
run-e2e's non-UI page names per-runtime live-test patterns and picks a harness (vitest, xUnit, pytest) for the consumer's runtime.
Rows (2: all R11)
| Row | Rule | Kind | Cited at (as of 5b66a7f) | Fact |
|---|---|---|---|---|
| F0446 | R11 | K4 | plugins/testing/skills/run-e2e/context/non-ui.md:17-28 |
surface table: WebApplicationFactory, Aspire AppHost, bats, pytest via uv, PSScriptAnalyzer, Pester, script -q |
| F0447 | R11 | K4 | plugins/testing/skills/run-e2e/context/non-ui.md:50-59 |
per-runtime spawn table (node/npm, dotnet run, uv run) and harness choice |
Files
- Cut:
plugins/testing/skills/run-e2e/context/non-ui.md. - Outside references at d46efa9: none by full path.
Rules this part follows (from #16755, rules revision 5)
- R11 (shipped knowledge): model-read K2, K3, K4, K5 or K7 text. Generic text replaces it only at a routing site where the skill still takes a language-specific step; anywhere else it is deleted with no replacement. An item kept only because a removed item consumes it goes in the same pull request.
- R4 (consumer default): the value picks a tool or library for the consumer. It goes: no bundled default survives (ADR 0101 decision 2, "Ship no bundled default"); the choice is resolved from the consumer through
docs/contracts/ecosystem-resolution/. - R8 (measured fact): cut it like the other rows and mark it in the pull request body as pending its targeted case; the host session's eval (below) decides whether it comes back, annotated
portability-ok: measured <case-id>. - AC1's named exceptions are the kept classes of ADR 0101 (
docs/adr/0101-resolve-ecosystem-specifics-from-the-consumer-repository.md, Decision and the 2026-11-17 amendment). Bundled defaults that pick a tool, command or library are retired wherever they appear (Interview Q32, D4 of the Brief). - Line numbers below were read at
5b66a7faand may have moved; find each row by its cited text.
After the pull request opens (host session, not the lane)
The lane opens the pull request with Closes this issue and stops; it adds no label. The pull request stays held for the eval:
- Hold line: a sweep or host session adds
do-not-mergeand posts, from a listed human's account, a comment with<!-- pr-hold reason=eval -->on a line of its own. - Targeted case per changed skill: one before-and-after case on
sonnetat 3 runs a side,--case,--runs 3, a--max-cost-usdceiling;opusonly to confirm a sonnet loss; a new case gets a 1 to 3 run smoke first; start no batch after a usage-limit error (owner decision of 2026-11-16). - Controls: the owner's Q53 decision of 2026-11-17 (owner-decisions.md L202) reads: "each cut pull request is gated on a no-loss compare alone, with no wrong-text side". It supersedes Cut the model-read ecosystem specifics from testing #16755's Controls line and its AC7 sentence ("each partial cut carries a detection-control result"). A whole-page deletion still states its predicted outcome in the pull request body before the first batch, and the record says the case cannot detect wrong text.
- On a LOSS reading: a trace read of each dropped case and an
opusconfirm; only a loss traced to the changed text counts. - R8 rows: the row's targeted case with and without it; on a
case dropor a mean fall of 0.15 or more without it, restore the row annotatedportability-ok: measured <case-id>; a deterministic grader states before the run in how many of n runs it must fail. - Record: on a VALID no-loss run, post from a listed human's account
<!-- eval-pair verdict=no-loss validity=VALID head=<40-hex head SHA> -->naming the current head, with no "do not merge" text (docs/contracts/loop-lane/README.md, "Cross-lane PR hold"). pr-merge's "Release eval holds whose record matches the head" step (.github/scripts/pr-merge/release-eval-hold.mjs) then removesdo-not-merge; a later push needs a new record.
Out of scope
Rows outside this part's table, the parent's kept rows, every other plugin, toolchain's bundled defaults (#15733), and widening the portability gate (#15732).
Done when
- Both rows are cut or replaced at a routing site; a row whose cited text is already gone on
mainis listed as GONE. - The pull request body states this part's row count (2) and lists both row ids with their rule and outcome.
- Each row's script-reader search is quoted in the pull request body; a row whose file a script reads is not cut, and is listed in the pull request body under a
Script readersheading. - The pull request body names, for run-e2e, the existing eval case that reads the cut text, or says none does.
- The pull request body says whether the cut deletes the whole page or part of it.
- AC10: no new enforcement-placing skill is added.
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Work status
needs-triage
Priority
medium
Activity
github-actions commentedon Nov 21, 2026
Size: Small
Complexity: Low
Uncertainty: Known
Flags: none
Blocked by: none
Blast radius: one skill context page (plugins/testing/skills/run-e2e/context/non-ui.md) and whoever loads the run-e2e skill; the PR is held for a host-session eval.
Reversible: yes; revert the PR.
Open questions: none
Understood: cut or replace the two R11 rows (F0446, F0447) in run-e2e's non-UI page, with the PR-body reporting listed in the done-when. The host-session eval is not a lane step. Related open issue: #17743-style sibling part (browser driver guidance) is a different row set, not a duplicate. No merged PR in the list appears to already fix this.
Automated triage. A maintainer reviews it.
melodic-automation-lanes commentedon Nov 21, 2026
{"v":1,"actor_id":337595936,"title_sha256":"3e3e8bb90559936c8e11c6a757c983b6e4ca4438ae0ab70ef07d4c2d44171895","body_sha256":"df0c275a3cffb47295cf118f43fd657a94750a888eddd7fb7708adc5b94e109d"}
github-actions commentedon Nov 21, 2026
github-actions commentedon Nov 21, 2026