Skip to content

Cut the model-read ecosystem specifics from testing: test-value, property, characterization, visual parity and cleanup #17754

Description

@kyle-sexton

Part 5 of 5 of #16755. Refs #15703.

Problem

Five testing skills point at single tools' documentation or illustrate neutral rules with .NET-only guidance and examples.

Rows (6: all R11)

Row Rule Kind Cited at (as of 5b66a7f) Fact
F0427 R11 K5 plugins/testing/skills/write/context/property.md:94-106,143-148 Hypothesis @example and fast-check examples mechanics and doc links
F0432 R11 K5 plugins/testing/skills/write/context/characterization.md:72-77 Sources links for Scientist, Verify scrubbers, Jest snapshots, ApprovalTests (paper and author citations on the same lines are R9 and stay)
F0433 R11 K4 plugins/testing/skills/test-value/SKILL.md:107-112 EF Core carve-out (DbContext, DbSet, MS Learn pointers)
F0434 R11 K5 plugins/testing/skills/test-value/SKILL.md:76-85 Pact and vcrpy links in the canned-response record (author citations stay)
F0450 R11 K4 plugins/testing/skills/check-visual-parity/SKILL.md:35-58 capture-route step names Playwright toHaveScreenshot, Storybook, Playwright CLI
F0452 R11 K7 plugins/testing/skills/cleanup/SKILL.md:206,342 C# using note and ".NET suite, 3 of 42" anecdote

Files

  • Cut: plugins/testing/skills/write/context/property.md, .../write/context/characterization.md, plugins/testing/skills/test-value/SKILL.md, plugins/testing/skills/check-visual-parity/SKILL.md, plugins/testing/skills/cleanup/SKILL.md.
  • Outside references at d46efa9: scripts/docs-anchor-baseline.txt:127 (test-value SKILL.md), :128 (characterization.md).

Rules this part follows (from #16755, rules revision 5)

  • R11 (shipped knowledge): model-read K2, K3, K4, K5 or K7 text. Generic text replaces it only at a routing site where the skill still takes a language-specific step; anywhere else it is deleted with no replacement. An item kept only because a removed item consumes it goes in the same pull request.
  • R4 (consumer default): the value picks a tool or library for the consumer. It goes: no bundled default survives (ADR 0101 decision 2, "Ship no bundled default"); the choice is resolved from the consumer through docs/contracts/ecosystem-resolution/.
  • R8 (measured fact): cut it like the other rows and mark it in the pull request body as pending its targeted case; the host session's eval (below) decides whether it comes back, annotated portability-ok: measured <case-id>.
  • AC1's named exceptions are the kept classes of ADR 0101 (docs/adr/0101-resolve-ecosystem-specifics-from-the-consumer-repository.md, Decision and the 2026-11-17 amendment). Bundled defaults that pick a tool, command or library are retired wherever they appear (Interview Q32, D4 of the Brief).
  • Line numbers below were read at 5b66a7fa and may have moved; find each row by its cited text.

After the pull request opens (host session, not the lane)

The lane opens the pull request with Closes this issue and stops; it adds no label. The pull request stays held for the eval:

  • Hold line: a sweep or host session adds do-not-merge and posts, from a listed human's account, a comment with <!-- pr-hold reason=eval --> on a line of its own.
  • Targeted case per changed skill: one before-and-after case on sonnet at 3 runs a side, --case, --runs 3, a --max-cost-usd ceiling; opus only to confirm a sonnet loss; a new case gets a 1 to 3 run smoke first; start no batch after a usage-limit error (owner decision of 2026-11-16).
  • Controls: the owner's Q53 decision of 2026-11-17 (owner-decisions.md L202) reads: "each cut pull request is gated on a no-loss compare alone, with no wrong-text side". It supersedes Cut the model-read ecosystem specifics from testing #16755's Controls line and its AC7 sentence ("each partial cut carries a detection-control result"). A whole-page deletion still states its predicted outcome in the pull request body before the first batch, and the record says the case cannot detect wrong text.
  • On a LOSS reading: a trace read of each dropped case and an opus confirm; only a loss traced to the changed text counts.
  • R8 rows: the row's targeted case with and without it; on a case drop or a mean fall of 0.15 or more without it, restore the row annotated portability-ok: measured <case-id>; a deterministic grader states before the run in how many of n runs it must fail.
  • Record: on a VALID no-loss run, post from a listed human's account <!-- eval-pair verdict=no-loss validity=VALID head=<40-hex head SHA> --> naming the current head, with no "do not merge" text (docs/contracts/loop-lane/README.md, "Cross-lane PR hold"). pr-merge's "Release eval holds whose record matches the head" step (.github/scripts/pr-merge/release-eval-hold.mjs) then removes do-not-merge; a later push needs a new record.

Out of scope

Rows outside this part's table, the parent's kept rows, every other plugin, toolchain's bundled defaults (#15733), and widening the portability gate (#15732).

Done when

  • Every row in this part's table is cut or replaced at a routing site; a row whose cited text is already gone on main is listed as GONE.
  • The pull request body states this part's row count (6) and lists every row id with its rule and outcome.
  • Each R11 row's script-reader search is quoted in the pull request body; a row whose file a script reads (check-visual-parity has scripts/visual-compare.sh) is not cut, and is listed in the pull request body under a Script readers heading.
  • The pull request body names, for each changed skill (write, test-value, check-visual-parity, cleanup), the existing eval case that reads the cut text, or says none does.
  • The pull request body says, for each changed file, whether the cut deletes the whole page or part of it.
  • scripts/docs-anchor-baseline.txt:127-128 match the remaining anchors.
  • AC10: no new enforcement-placing skill is added.

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 21, 2026
  2. github-actions commented on Nov 21, 2026

    @github-actions
    Contributor

    Size: Medium
    Complexity: Low
    Uncertainty: Known
    Flags: none
    Blocked by: none
    Blast radius: five testing plugin skill pages (write/context property.md and characterization.md, test-value, check-visual-parity, cleanup) plus two lines of scripts/docs-anchor-baseline.txt. Anyone who loads these skills reads the changed text.
    Reversible: yes; revert the pull request, or restore a single row with a portability-ok: measured <case-id> annotation.
    Open questions: none
    I read this as part 5 of #16755: cut or replace the six R11 rows (F0427, F0432, F0433, F0434, F0450, F0452) at routing sites. The issue gives exact rows, rules and a done-when, so no owner decision is needed. check-visual-parity has a script reader (scripts/visual-compare.sh), so that row goes under Script readers and is not cut. The eval steps after the pull request opens belong to a host session, not this lane. Related open issues cover other testing parts (e.g. the write skill's naming and placement pages) but not these rows, so I found no duplicate or merged fix.

    Automated triage. A maintainer reviews it.

  3. removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 21, 2026
  4. melodic-automation-lanes commented on Nov 21, 2026

    @melodic-automation-lanes
    Contributor

    {"v":1,"actor_id":337595936,"title_sha256":"bf2fdb7d145e9252804ecf00bab1a1ed2b862c9166e8a299ef7bed82f16613d7","body_sha256":"51e5392d7c1475f98fbaf86373abf8e3058e9e56b454a73589c08ba0d0aa2b16"}

  5. melodic-automation-lanes commented on Nov 21, 2026

    @melodic-automation-lanes
    Contributor

    {"v":1,"actor_id":337595936,"title_sha256":"bf2fdb7d145e9252804ecf00bab1a1ed2b862c9166e8a299ef7bed82f16613d7","body_sha256":"51e5392d7c1475f98fbaf86373abf8e3058e9e56b454a73589c08ba0d0aa2b16"}

  6. github-actions commented on Nov 21, 2026

    @github-actions
    Contributor
    No description provided.
  7. github-actions commented on Nov 21, 2026

    @github-actions
    Contributor
    No description provided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Work status

    needs-triage

    Priority

    medium

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions