Repository navigation
Closed
Task
Copy link
Description
Part 2 of 5 of #16756. Refs #15703.
Problem
code-tidying:tidy and its exclusions and tidyings references use one-stack examples and one-tool pointers, and tidy's description names no language.
Rows (5: all R11)
| Row | Rule | Kind | Cited at (as of 5b66a7f) | Fact |
|---|---|---|---|---|
| F0108 | R11 | K7 | plugins/code-tidying/skills/tidy/SKILL.md:93, :176 |
node --test scope example and shellcheck/shfmt commit-title example |
| F0116 | R11 | K7 | plugins/code-tidying/skills/tidy/reference/exclusions.md:25 |
Directory.Build.props, Directory.Packages.props as "Typical examples" |
| F0117 | R11 | K7 | .../tidy/reference/exclusions.md:131-139 |
ruff.toml in the overrides-file example |
| F0118 | R11 | K5 | .../tidy/reference/tidyings.md:23 |
Roslyn, ruff F841, biome as candidate surfacers |
| F0119 | R11 | K7 | .../tidy/reference/tidyings.md:55, :92, :176 |
C#/TS/Python/C list, OrderValidationRules.cs, npx markdownlint-cli2 |
Files
- Cut:
plugins/code-tidying/skills/tidy/SKILL.md,.../tidy/reference/exclusions.md,.../tidy/reference/tidyings.md. - Outside references at d46efa9: none by full path (
em-dash-purged-paths.txt:184-189are globs).
Rules this part follows (from #16756, rules revision 5)
- R11 (shipped knowledge): model-read K2, K3, K4, K5 or K7 text. Generic text replaces it only at a routing site where the skill still takes a language-specific step; anywhere else it is deleted with no replacement. An item kept only because a removed item consumes it goes in the same pull request.
- R4 (consumer default): the value picks a tool or library for the consumer. It goes: no bundled default survives (ADR 0101 decision 2, "Ship no bundled default"); the choice is resolved from the consumer through
docs/contracts/ecosystem-resolution/. - R8 (measured fact): cut it like the other rows and mark it in the pull request body as pending its targeted case; the host session's eval (below) decides whether it comes back, annotated
portability-ok: measured <case-id>. - AC1's named exceptions are the kept classes of ADR 0101 (
docs/adr/0101-resolve-ecosystem-specifics-from-the-consumer-repository.md, Decision and the 2026-11-17 amendment). Bundled defaults that pick a tool, command or library are retired wherever they appear (Interview Q32, D4 of the Brief). - Line numbers below were read at
5b66a7faand may have moved; find each row by its cited text.
After the pull request opens (host session, not the lane)
The lane opens the pull request with Closes this issue and stops; it adds no label. The pull request stays held for the eval:
- Hold line: a sweep or host session adds
do-not-mergeand posts, from a listed human's account, a comment with<!-- pr-hold reason=eval -->on a line of its own. - Targeted case per changed skill: one before-and-after case on
sonnetat 3 runs a side,--case,--runs 3, a--max-cost-usdceiling;opusonly to confirm a sonnet loss; a new case gets a 1 to 3 run smoke first; start no batch after a usage-limit error (owner decision of 2026-11-16). - Controls: the owner's Q53 decision of 2026-11-17 (owner-decisions.md L202) reads: "each cut pull request is gated on a no-loss compare alone, with no wrong-text side". It supersedes Cut the model-read ecosystem specifics from code-tidying #16756's Controls line and its AC7 sentence ("each partial cut carries a detection-control result"). A whole-page deletion still states its predicted outcome in the pull request body before the first batch, and the record says the case cannot detect wrong text.
- On a LOSS reading: a trace read of each dropped case and an
opusconfirm; only a loss traced to the changed text counts. - R8 rows: the row's targeted case with and without it; on a
case dropor a mean fall of 0.15 or more without it, restore the row annotatedportability-ok: measured <case-id>; a deterministic grader states before the run in how many of n runs it must fail. - Record: on a VALID no-loss run, post from a listed human's account
<!-- eval-pair verdict=no-loss validity=VALID head=<40-hex head SHA> -->naming the current head, with no "do not merge" text (docs/contracts/loop-lane/README.md, "Cross-lane PR hold"). pr-merge's "Release eval holds whose record matches the head" step (.github/scripts/pr-merge/release-eval-hold.mjs) then removesdo-not-merge; a later push needs a new record.
Out of scope
Rows outside this part's table, the parent's kept rows, every other plugin, toolchain's bundled defaults (#15733), and widening the portability gate (#15732).
Done when
- Every row in this part's table is cut or replaced at a routing site; a row whose cited text is already gone on
mainis listed as GONE. - The pull request body states this part's row count (5) and lists every row id with its rule and outcome.
- Each R11 row's script-reader search is quoted in the pull request body; a row whose file a script reads is not cut, and is listed in the pull request body under a
Script readersheading. - The pull request body names, for the tidy skill, the existing eval case that reads the cut text, or says none does.
- The pull request body says, for each changed file, whether the cut deletes the whole page or part of it.
- AC10: no new enforcement-placing skill is added.
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Work status
needs-triage
Priority
medium
Activity
github-actions commentedon Nov 21, 2026
Size: Small
Complexity: Low
Uncertainty: Known
Flags: none
Blocked by: none
Blast radius: three files under plugins/code-tidying/skills/tidy (SKILL.md and two reference pages), read by the model when the tidy skill runs; the pull request body carries the row accounting.
Reversible: yes; revert the pull request, or restore a row annotated
portability-ok: measured <case-id>if its eval shows a loss.Open questions: none
I read this as part 2 of 5 of #16756. It asks for the 5 listed rows (F0108, F0116, F0117, F0118, F0119) to be cut from the tidy skill and its exclusions and tidyings pages. The done-when items and the eval hold are exact, so I found nothing missing. The host-session eval after the pull request opens is a separate step. I found no open duplicate and no merged pull request that already does this. #17755 covers the sibling skills in the same plugin and is separate work.
Automated triage. A maintainer reviews it.
melodic-automation-lanes commentedon Nov 21, 2026
{"v":1,"actor_id":337595936,"title_sha256":"0a78816f10bc9210edbd13ea69f9cf7a7037840987fab1f364e06efe71d7b993","body_sha256":"2cf65d6a19cbc1cbe32fb964dd140cb148198d862c78bdb2e15345e50f0ccbfc"}
github-actions commentedon Nov 21, 2026
github-actions commentedon Nov 21, 2026