Repository navigation
Description
Part 3 of 5 of #16756. Refs #15703.
Problem
Two bundled tidy lanes pick the consumer's check tools (shellcheck, shfmt, PSScriptAnalyzer; markdownlint-cli2) and carry the tool-specific guidance those picks serve.
Rows (6: R11 4, R4 2)
| Row | Rule | Kind | Cited at (as of 5b66a7f) | Fact |
|---|---|---|---|---|
| F0110 | R11 | K3 | plugins/code-tidying/skills/tidy/lanes/shell-tooling.md:5-16 |
bundled Scope globs (tools/**/*.sh, scripts/**/*.ps1) |
| F0111 | R11 | K4 | .../tidy/lanes/shell-tooling.md:31-49 |
ShellCheck SC2086/SC2292/SC2230/SC2034 and PowerShell idiom watch-for list |
| F0113 | R4 | K3 | .../tidy/lanes/shell-tooling.md:60-79 |
verification commands pick shellcheck, shfmt, PSScriptAnalyzer |
| F0114 | R11 | K5 | .../tidy/lanes/shell-tooling.md:88-99 |
Bash/PowerShell research sources (ShellCheck, BashFAQ) |
| F0120 | R11 | K5 | plugins/code-tidying/skills/tidy/lanes/docs-prose.md:30-36 |
P-1 names markdownlint-cli2 for dead links |
| F0121 | R4 | K3 | .../tidy/lanes/docs-prose.md:49-55 |
verification command npx markdownlint-cli2 <changed .md files> |
F0113 with F0110/F0111/F0114 and F0121 with F0120 stay together: each default and the guidance that serves it go in one pull request. If the cut leaves a lane file with no content, the pull request says so and treats it as a whole-page deletion.
Files
- Cut:
plugins/code-tidying/skills/tidy/lanes/shell-tooling.md,plugins/code-tidying/skills/tidy/lanes/docs-prose.md(and any lane index intidy/SKILL.mdthat lists a lane the cut empties). - Outside references at d46efa9: none by full path.
Rules this part follows (from #16756, rules revision 5)
- R11 (shipped knowledge): model-read K2, K3, K4, K5 or K7 text. Generic text replaces it only at a routing site where the skill still takes a language-specific step; anywhere else it is deleted with no replacement. An item kept only because a removed item consumes it goes in the same pull request.
- R4 (consumer default): the value picks a tool or library for the consumer. It goes: no bundled default survives (ADR 0101 decision 2, "Ship no bundled default"); the choice is resolved from the consumer through
docs/contracts/ecosystem-resolution/. - R8 (measured fact): cut it like the other rows and mark it in the pull request body as pending its targeted case; the host session's eval (below) decides whether it comes back, annotated
portability-ok: measured <case-id>. - AC1's named exceptions are the kept classes of ADR 0101 (
docs/adr/0101-resolve-ecosystem-specifics-from-the-consumer-repository.md, Decision and the 2026-11-17 amendment). Bundled defaults that pick a tool, command or library are retired wherever they appear (Interview Q32, D4 of the Brief). - Line numbers below were read at
5b66a7faand may have moved; find each row by its cited text.
After the pull request opens (host session, not the lane)
The lane opens the pull request with Closes this issue and stops; it adds no label. The pull request stays held for the eval:
- Hold line: a sweep or host session adds
do-not-mergeand posts, from a listed human's account, a comment with<!-- pr-hold reason=eval -->on a line of its own. - Targeted case per changed skill: one before-and-after case on
sonnetat 3 runs a side,--case,--runs 3, a--max-cost-usdceiling;opusonly to confirm a sonnet loss; a new case gets a 1 to 3 run smoke first; start no batch after a usage-limit error (owner decision of 2026-11-16). - Controls: the owner's Q53 decision of 2026-11-17 (owner-decisions.md L202) reads: "each cut pull request is gated on a no-loss compare alone, with no wrong-text side". It supersedes Cut the model-read ecosystem specifics from code-tidying #16756's Controls line and its AC7 sentence ("each partial cut carries a detection-control result"). A whole-page deletion still states its predicted outcome in the pull request body before the first batch, and the record says the case cannot detect wrong text.
- On a LOSS reading: a trace read of each dropped case and an
opusconfirm; only a loss traced to the changed text counts. - R8 rows: the row's targeted case with and without it; on a
case dropor a mean fall of 0.15 or more without it, restore the row annotatedportability-ok: measured <case-id>; a deterministic grader states before the run in how many of n runs it must fail. - Record: on a VALID no-loss run, post from a listed human's account
<!-- eval-pair verdict=no-loss validity=VALID head=<40-hex head SHA> -->naming the current head, with no "do not merge" text (docs/contracts/loop-lane/README.md, "Cross-lane PR hold"). pr-merge's "Release eval holds whose record matches the head" step (.github/scripts/pr-merge/release-eval-hold.mjs) then removesdo-not-merge; a later push needs a new record.
Out of scope
Rows outside this part's table, the parent's kept rows, every other plugin, toolchain's bundled defaults (#15733), and widening the portability gate (#15732).
Done when
- Every row in this part's table is cut or replaced at a routing site, and no bundled check-tool default survives in either lane; a row whose cited text is already gone on
mainis listed as GONE. - The pull request body states this part's row count (6) and lists every row id with its rule and outcome.
- Each R11 row's script-reader search is quoted in the pull request body; a row whose file a script reads is not cut, and is listed in the pull request body under a
Script readersheading. - The pull request body names, for the tidy skill, the existing eval case that reads the cut text, or says none does.
- The pull request body says, for each changed file, whether the cut deletes the whole page or part of it.
- AC10: no new enforcement-placing skill is added.
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Work status
needs-triage
Priority
medium
Activity
github-actions commentedon Nov 21, 2026
Size: Small
Complexity: Low
Uncertainty: Known
Flags: none
Blocked by: none
Blast radius: two tidy lane files in plugins/code-tidying (shell-tooling.md, docs-prose.md) plus any lane index in tidy/SKILL.md; read by the tidy skill's model and by consumers running it.
Reversible: yes; revert the pull request, or restore a row annotated portability-ok if the eval shows a loss.
Open questions: none
I understood this as part 3 of 5 of #16756: cut or replace six listed rows (F0110, F0111, F0113, F0114, F0120, F0121) so neither lane keeps a bundled check-tool default. The rules and done-when are exact, and the eval gating happens after the pull request opens, in a host session. Open issues #15703's siblings with similar titles cover other parts of the cut (the lane templates, the tidy skill and reference pages, batch-simplify/tidy-diff/audit-dead-code) and are not duplicates. I found no merged pull request that already does this.
Automated triage. A maintainer reviews it.
melodic-automation-lanes commentedon Nov 21, 2026
{"v":1,"actor_id":337595936,"title_sha256":"6a187a609eac1b30e0b564213f2e14c819a18d38756e286ee56432eb1a7b3672","body_sha256":"b7044bdc53393d025acd7e7dfdfd4f258e1aa7749366cf8f0065674bfe4102f1"}
github-actions commentedon Nov 21, 2026
github-actions commentedon Nov 21, 2026