Skip to content

Cut the model-read ecosystem specifics from code-tidying: tidy lane templates #17760

Description

@kyle-sexton

Part 4 of 5 of #16756. Refs #15703.

Problem

The tidy lane templates fill their placeholders with .NET, JS, Python and Rust examples.

Rows (4: all R11)

Row Rule Kind Cited at (as of 5b66a7f) Fact
F0123 R11 K7 plugins/code-tidying/skills/tidy/templates/dependency-root-lane.template.md:12, :24-25, :37-39 .Tests glob, dotnet build / npm run build / cargo build, biome comments
F0124 R11 K7 .../tidy/templates/polyglot-services-lane.template.md:10-11, :16-19, :34-35 ruff F401/F841, biome, biome check && npm test, ruff check . && pytest
F0125 R11 K7 .../tidy/templates/apps-lane.template.md:11, :27 <app-name>.Tests/**, **/*.razor
F0126 R11 K7 .../tidy/templates/host-wiring-lane.template.md:18 "one extension method" (C#-flavored)

Files

  • Cut: the four plugins/code-tidying/skills/tidy/templates/*-lane.template.md files above.
  • Outside references at d46efa9: none by full path.

Rules this part follows (from #16756, rules revision 5)

  • R11 (shipped knowledge): model-read K2, K3, K4, K5 or K7 text. Generic text replaces it only at a routing site where the skill still takes a language-specific step; anywhere else it is deleted with no replacement. An item kept only because a removed item consumes it goes in the same pull request.
  • R4 (consumer default): the value picks a tool or library for the consumer. It goes: no bundled default survives (ADR 0101 decision 2, "Ship no bundled default"); the choice is resolved from the consumer through docs/contracts/ecosystem-resolution/.
  • R8 (measured fact): cut it like the other rows and mark it in the pull request body as pending its targeted case; the host session's eval (below) decides whether it comes back, annotated portability-ok: measured <case-id>.
  • AC1's named exceptions are the kept classes of ADR 0101 (docs/adr/0101-resolve-ecosystem-specifics-from-the-consumer-repository.md, Decision and the 2026-11-17 amendment). Bundled defaults that pick a tool, command or library are retired wherever they appear (Interview Q32, D4 of the Brief).
  • Line numbers below were read at 5b66a7fa and may have moved; find each row by its cited text.

After the pull request opens (host session, not the lane)

The lane opens the pull request with Closes this issue and stops; it adds no label. The pull request stays held for the eval:

  • Hold line: a sweep or host session adds do-not-merge and posts, from a listed human's account, a comment with <!-- pr-hold reason=eval --> on a line of its own.
  • Targeted case per changed skill: one before-and-after case on sonnet at 3 runs a side, --case, --runs 3, a --max-cost-usd ceiling; opus only to confirm a sonnet loss; a new case gets a 1 to 3 run smoke first; start no batch after a usage-limit error (owner decision of 2026-11-16).
  • Controls: the owner's Q53 decision of 2026-11-17 (owner-decisions.md L202) reads: "each cut pull request is gated on a no-loss compare alone, with no wrong-text side". It supersedes Cut the model-read ecosystem specifics from code-tidying #16756's Controls line and its AC7 sentence ("each partial cut carries a detection-control result"). A whole-page deletion still states its predicted outcome in the pull request body before the first batch, and the record says the case cannot detect wrong text.
  • On a LOSS reading: a trace read of each dropped case and an opus confirm; only a loss traced to the changed text counts.
  • R8 rows: the row's targeted case with and without it; on a case drop or a mean fall of 0.15 or more without it, restore the row annotated portability-ok: measured <case-id>; a deterministic grader states before the run in how many of n runs it must fail.
  • Record: on a VALID no-loss run, post from a listed human's account <!-- eval-pair verdict=no-loss validity=VALID head=<40-hex head SHA> --> naming the current head, with no "do not merge" text (docs/contracts/loop-lane/README.md, "Cross-lane PR hold"). pr-merge's "Release eval holds whose record matches the head" step (.github/scripts/pr-merge/release-eval-hold.mjs) then removes do-not-merge; a later push needs a new record.

Out of scope

Rows outside this part's table, the parent's kept rows, every other plugin, toolchain's bundled defaults (#15733), and widening the portability gate (#15732).

Done when

  • Every row in this part's table is replaced with neutral placeholder text; a row whose cited text is already gone on main is listed as GONE.
  • The pull request body states this part's row count (4) and lists every row id with its rule and outcome.
  • Each R11 row's script-reader search is quoted in the pull request body; a template a script reads or renders is not cut, and is listed in the pull request body under a Script readers heading.
  • The pull request body names, for the tidy skill, the existing eval case that reads the cut text, or says none does.
  • The pull request body says, for each changed file, whether the cut deletes the whole page or part of it.
  • AC10: no new enforcement-placing skill is added.

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 21, 2026
  2. github-actions commented on Nov 21, 2026

    @github-actions
    Contributor

    Size: Small
    Complexity: Low
    Uncertainty: Known
    Flags: none
    Blocked by: none
    Blast radius: four tidy lane template files under plugins/code-tidying/skills/tidy/templates/, read by the tidy skill's model.
    Reversible: yes; revert the pull request.
    Open questions: none
    Understood: replace the .NET/JS/Python/Rust examples in the four lane templates (rows F0123-F0126) with neutral placeholder text. The done-when is exact, and the eval hold is handled by the host session after the pull request opens. Related sibling parts of the same cut (not duplicates, since they cover different files) are #16756's other parts, including the open issues on the tidy skill and its reference pages and on the shell-tooling and docs-prose lanes. No merged pull request that fixes this was found.

    Automated triage. A maintainer reviews it.

  3. removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 21, 2026
  4. melodic-automation-lanes commented on Nov 21, 2026

    @melodic-automation-lanes
    Contributor

    {"v":1,"actor_id":337595936,"title_sha256":"91df77e0b931c45c639c35995f1d2d55f697ce0ef33461340f52c2a51e9ac316","body_sha256":"a4060501836b4aa94cfea0098e8e19e0e9aacd79dc68240310af12d276f2b873"}

  5. melodic-automation-lanes commented on Nov 21, 2026

    @melodic-automation-lanes
    Contributor

    This records a re-fire of an earlier stop, not a new one. The start gate stopped run 44853920939, the work-resolve-issue run that agent-ready started, before any model turn, because the GITHUB_TOKEN budget was under its start-gate share, or the window was projected to have under its start-project share of the header's limit left by the run's expected end (github-token start-gate, start-project and start-run-minutes in rate-limits.json; the run's start-gate notice names which); that run ended at 2026-11-21T02:50:39Z. work-unblock has now removed and added agent-ready back to start a fresh run. A budget stop is the lanes' load, not a fault in this issue: it never counts toward limits.limit-stops-per-issue or the kill-switch wait.

  6. github-actions commented on Nov 21, 2026

    @github-actions
    Contributor
    No description provided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Work status

    needs-triage

    Priority

    low

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions