Repository navigation
Closed
Task
Copy link
Description
Part 5 of 5 of #16756. Refs #15703.
Problem
remove-comments' tooling, safety and triage references record outside-tool measurements, name tools to use, fall back to an ecosystem default test runner (R4) and list per-language exempt surfaces.
Rows (6: R11 4, R4 1, R8 1)
| Row | Rule | Kind | Cited at (as of 5b66a7f) | Fact |
|---|---|---|---|---|
| F0096 | R8 | K4 | plugins/code-tidying/skills/remove-comments/reference/tooling.md:38-59 |
dated tree-sitter measurements (language-pack behind a proxy, powershell parse errors, bash base-N) |
| F0097 | R11 | K5 | .../remove-comments/reference/tooling.md:61-82 |
CS1572/CS1573, Ruff DOC, eslint-plugin-jsdoc, Vale for prose and contradiction checks |
| F0100 | R4 | K3 | .../remove-comments/reference/safety.md:110-114 |
test-net fallback runner (dotnet test, npm test, pytest, go test ./..., bats) |
| F0101 | R11 | K4 | .../remove-comments/reference/safety.md:128-152 |
exempt-surface list (docstrings, C# XML docs, JSDoc/TSDoc, GoDoc, PowerShell help, Python underscore rule) |
| F0104 | R11 | K5 | .../remove-comments/reference/triage.md:146-150 |
Vale as the optional prose linter |
| F0105 | R11 | K4 | .../remove-comments/reference/triage.md:158-167 |
doc-comment exemption section |
Files
- Cut:
plugins/code-tidying/skills/remove-comments/reference/tooling.md,.../reference/safety.md,.../reference/triage.md. - Outside references at d46efa9:
scripts/docs-anchor-baseline.txt:25(tooling.md, count 1);scripts/spoke-plugin-root-baseline.txt:27(safety.md, justified entry). remove-comments shipsscripts/detect.shandlib/comment-shapes.sh, so the script-reader search for F0101/F0105 must show whether the exempt list is also script-enforced.
Rules this part follows (from #16756, rules revision 5)
- R11 (shipped knowledge): model-read K2, K3, K4, K5 or K7 text. Generic text replaces it only at a routing site where the skill still takes a language-specific step; anywhere else it is deleted with no replacement. An item kept only because a removed item consumes it goes in the same pull request.
- R4 (consumer default): the value picks a tool or library for the consumer. It goes: no bundled default survives (ADR 0101 decision 2, "Ship no bundled default"); the choice is resolved from the consumer through
docs/contracts/ecosystem-resolution/. - R8 (measured fact): cut it like the other rows and mark it in the pull request body as pending its targeted case; the host session's eval (below) decides whether it comes back, annotated
portability-ok: measured <case-id>. - AC1's named exceptions are the kept classes of ADR 0101 (
docs/adr/0101-resolve-ecosystem-specifics-from-the-consumer-repository.md, Decision and the 2026-11-17 amendment). Bundled defaults that pick a tool, command or library are retired wherever they appear (Interview Q32, D4 of the Brief). - Line numbers below were read at
5b66a7faand may have moved; find each row by its cited text.
After the pull request opens (host session, not the lane)
The lane opens the pull request with Closes this issue and stops; it adds no label. The pull request stays held for the eval:
- Hold line: a sweep or host session adds
do-not-mergeand posts, from a listed human's account, a comment with<!-- pr-hold reason=eval -->on a line of its own. - Targeted case per changed skill: one before-and-after case on
sonnetat 3 runs a side,--case,--runs 3, a--max-cost-usdceiling;opusonly to confirm a sonnet loss; a new case gets a 1 to 3 run smoke first; start no batch after a usage-limit error (owner decision of 2026-11-16). - Controls: the owner's Q53 decision of 2026-11-17 (owner-decisions.md L202) reads: "each cut pull request is gated on a no-loss compare alone, with no wrong-text side". It supersedes Cut the model-read ecosystem specifics from code-tidying #16756's Controls line and its AC7 sentence ("each partial cut carries a detection-control result"). A whole-page deletion still states its predicted outcome in the pull request body before the first batch, and the record says the case cannot detect wrong text.
- On a LOSS reading: a trace read of each dropped case and an
opusconfirm; only a loss traced to the changed text counts. - R8 rows: the row's targeted case with and without it; on a
case dropor a mean fall of 0.15 or more without it, restore the row annotatedportability-ok: measured <case-id>; a deterministic grader states before the run in how many of n runs it must fail. - Record: on a VALID no-loss run, post from a listed human's account
<!-- eval-pair verdict=no-loss validity=VALID head=<40-hex head SHA> -->naming the current head, with no "do not merge" text (docs/contracts/loop-lane/README.md, "Cross-lane PR hold"). pr-merge's "Release eval holds whose record matches the head" step (.github/scripts/pr-merge/release-eval-hold.mjs) then removesdo-not-merge; a later push needs a new record.
Out of scope
Rows outside this part's table, the parent's kept rows, every other plugin, toolchain's bundled defaults (#15733), and widening the portability gate (#15732).
Done when
- Every row in this part's table is cut, replaced at a routing site, or (R8) cut and marked pending its targeted case; a row whose cited text is already gone on
mainis listed as GONE. - The pull request body states this part's row count (6) and lists every row id with its rule and outcome; F0096 is marked pending its targeted case.
- Each R11 row's script-reader search is quoted in the pull request body; a row whose file a script reads is not cut, and is listed in the pull request body under a
Script readersheading. - The pull request body names, for remove-comments, the existing eval case that reads the cut text, or says none does.
- The pull request body says, for each changed file, whether the cut deletes the whole page or part of it.
-
scripts/docs-anchor-baseline.txt:25andscripts/spoke-plugin-root-baseline.txt:27match the files after the cut. - AC10: no new enforcement-placing skill is added.
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Work status
needs-triage
Priority
medium
Activity
github-actions commentedon Nov 21, 2026
Size: Medium
Complexity: Medium
Uncertainty: Known
Flags: none
Blocked by: none
Blast radius: three remove-comments reference pages in the code-tidying plugin, two baseline files under scripts/, and the skill's model readers.
Reversible: yes; revert the pull request, and restore the R8 row with a portability-ok annotation if its targeted case shows a loss.
Open questions: none
I understood this as part 5 of 5 of #16756: cut the six listed rows from the remove-comments tooling, safety and triage references. Each row is cut, replaced at a routing site, or marked pending its targeted case, and the two baseline entries are updated to match. The rules and done-when list are exact. The eval-gated host session after the pull request opens is outside this lane. The sibling parts (#17755, #17758, #17759, #17760) cover other code-tidying files and are not duplicates. No merged pull request already fixes this.
Automated triage. A maintainer reviews it.
melodic-automation-lanes commentedon Nov 21, 2026
{"v":1,"actor_id":337595936,"title_sha256":"277ad7ed660c1ffbd63081e1bcb802375c6549d4bd4769ae1eba7bbadf394c9a","body_sha256":"e0e018dc20574e28fc0c8dc0c8c7df6fb6d0d35d4620d45b4627b2dbb7aac2c2"}
melodic-automation-lanes commentedon Nov 21, 2026
This records a re-fire of an earlier stop, not a new one. The start gate stopped run 44892250137, the work-resolve-issue run that
agent-readystarted, before any model turn, because the GITHUB_TOKEN budget was under its start-gate share, or the window was projected to have under its start-project share of the header's limit left by the run's expected end (github-token start-gate, start-project and start-run-minutes in rate-limits.json; the run's start-gate notice names which); that run ended at 2026-11-21T10:04:08Z. work-unblock has now removed and addedagent-readyback to start a fresh run. A budget stop is the lanes' load, not a fault in this issue: it never counts toward limits.limit-stops-per-issue or thekill-switchwait.github-actions commentedon Nov 21, 2026