Skip to content

testing: read config from the config-cascade layers, not ~/.claude #17999

Open
0 of 4 issues completed
Open

Description

@kyle-sexton

Summary

testing still reads its user-global, team fallback and personal config from ~/.claude and .claude/, and its run-e2e skill text reads two config files from .claude/testing/. Move them to the config-cascade layers.

Current behavior

plugins/testing/scripts/resolve-config.sh reads old paths as layers:

  • :251-252 ${USER_HOME_DIR:+"$USER_HOME_DIR/.claude/testing.yaml"} (user-global) beside "$ROOT/.claude/testing.local.yaml" (personal)
  • :324 TEAM_YAML="$ROOT/.claude/testing.yaml" (team fallback)
  • :334-335 "$USER_HOME_DIR/.claude/testing.yaml" and "$ROOT/.claude/testing.local.yaml"

The same paths appear in plugins/testing/hooks/judge-lib.sh, scripts/time-config.sh, scripts/check-browser-driver.sh, skills/audit/scripts/cant-fail-scan.sh, skills/check-visual-parity/scripts/visual-compare.sh and skills/setup/scripts/setup.sh.

The run-e2e skill text (model-read, no script) also reads:

  • .claude/testing/e2e.md: the recording and browser_mode layers (plugins/testing/README.md:101; evals e2e-config-layers-delegated)
  • .claude/testing/worst-case.md: the consumer extension to the worst-case catalog (plugins/testing/skills/run-e2e/SKILL.md:356; eval e2e-worst-case-consumer-file)

Desired behavior

Per the config-cascade layers:

Old path Layer
~/.claude/testing.yaml userConfig (no user-global file layer)
<root>/.claude/testing.yaml team: <home>/testing.yaml
<root>/.claude/testing.local.yaml personal: <home>/testing.local.yaml
<root>/.claude/testing/e2e.md team: <home>/testing.yaml keys, or a <home> doc the contract allows
<root>/.claude/testing/worst-case.md team: a file at <home>

Every script above reads the contract layers, ideally through the one resolve-config.sh, and the run-e2e skill text reads its two files from <home>; a file at an old path keeps being read during a dual-read window (see the acceptance criteria) and is reported with a warning. The canonical location list (docs/contracts/config-cascade/locations.md) lands in the docs/config-locations pull request.

Key interfaces

  • resolve-config.sh layer list and per-value provenance
  • The config read in the hooks and scripts named above
  • skills/run-e2e/SKILL.md and its context files for e2e.md and worst-case.md
  • setup.sh check and apply

Acceptance criteria

  • The resolver reads the config-cascade layers (the layers).
  • The run-e2e skill text reads e2e.md and worst-case.md content from <home>.
  • Dual-read window: while an old-path file exists, it is still read and its values still apply where no new-layer file supplies that layer; each run prints one warning naming the old file and the new location to move it to. No setting in an old file is silently dropped.
  • setup.sh (check and apply) names each old file it finds and offers to copy its keys into the new location after a preview and a yes, leaving the old file in place.
  • Removing the old-path read is a separate later change, made only once no old file is reported.
  • The plugin's tests (resolve-config.test.sh, setup.test.sh, cant-fail-scan.test.sh, visual-compare.test.sh, hook tests) and the run-e2e evals cover: new layer only; old file only (values apply, warning printed); both present (new wins, warning names both).

Out of scope

Other plugins' resolvers (one issue each), and the "cut model-read ecosystem specifics" work on the testing plugin.

Activity

  1. added
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Nov 21, 2026
  2. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 21, 2026
  3. github-actions commented on Nov 21, 2026

    @github-actions
    Contributor

    Size: Large
    Complexity: Medium
    Uncertainty: Known
    Flags: none
    Blocked by: none
    Blast radius: the testing plugin's resolver, hooks, six scripts, the run-e2e skill text, its README, tests and evals; every consumer of the testing plugin's config reads this.
    Reversible: yes; the old-path read stays during the dual-read window, and the change is a code revert.
    Open questions: none
    Understood: move the testing plugin's config reads (user-global, team, personal, and the run-e2e e2e.md and worst-case.md files) to the config-cascade layers. Old-path files keep being read with a one-time warning, and setup.sh offers to copy their keys. The issue gives the target layers, the done-when and the tests, so no owner decision is needed. It touches many files and needs splitting, which is why it is Large. No duplicate found: the sibling "read config from the config-cascade layers" issues (e.g. #18000, #18001, #18014) each cover a different plugin. The issue notes that docs/contracts/config-cascade/locations.md lands in the separate docs/config-locations pull request; that is not an open issue, so I list no blocker.

    Automated triage. A maintainer reviews it.

  4. removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 21, 2026
  5. melodic-automation-lanes commented on Nov 21, 2026

    @melodic-automation-lanes
    Contributor

    {"v":1,"actor_id":337595936,"title_sha256":"330ad267a130f156cb6c955e18ca8ee501929c1322faafdf0fb3e1afba9cba20","body_sha256":"2912c3ff50e47c32ea95a7731ef464f862af17c55a0dee8301803b644b98f4b2"}

  6. melodic-automation-lanes commented on Nov 21, 2026

    @melodic-automation-lanes
    Contributor

    Not admitted to the issue lane yet: Size large: the split into sub-issues at intake is pending (owner Q93).

  7. removed
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Nov 21, 2026
  8. melodic-automation-lanes commented on Nov 21, 2026

    @melodic-automation-lanes
    Contributor

    Split at intake (owner Q93). This issue is Size Large, so its done-when is split into 4 sub-issues, each holding its task-list lines as written.

    Automated split by the lanes App. Admission waits on this issue while a sub-issue is open; work-unblock closes it as completed once every sub-issue is closed as completed by a merge or a listed human and its done-when is covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Work status

    ready

    Priority

    medium

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions