Skip to content

ai-slop: read config from the config-cascade layers, not ~/.claude #18004

Open

Description

@kyle-sexton

Summary

ai-slop still reads its user-global config from ~/.claude. Move it to the config-cascade layers.

Current behavior

plugins/ai-slop/skills/audit/scripts/detect.sh:193-195:

USER_CFG="${HOME:-/nonexistent}/.claude/ai-slop.json"
CFG_LAYERS=()
[[ -f "$USER_CFG" ]] && CFG_LAYERS+=("$USER_CFG")

Desired behavior

Per the config-cascade layers, ~/.claude/ai-slop.json moves into userConfig (no user-global file layer). detect.sh reads the contract layers; a file at the old path keeps being read during a dual-read window (see the acceptance criteria) and is reported with a warning. The canonical location list (docs/contracts/config-cascade/locations.md) lands in the docs/config-locations pull request.

Key interfaces

  • detect.sh CFG_LAYERS list and the layer provenance it reports

Acceptance criteria

  • The resolver reads the config-cascade layers (the layers).
  • Dual-read window: while an old-path file exists, it is still read and its values still apply where no new-layer file supplies that layer; each run prints one warning naming the old file and the new location to move it to. No setting in an old file is silently dropped.
  • The plugin's setup (check/apply), where it has one, names each old file it finds and after a preview and a yes, moves its settings to the new location, checks the new location resolves the same values, then deletes the old file, so migration ends in one home, never two (owner 2026-11-21: "we don't have dual approaches, and that stuff gets cleaned up"); the dual-read warning names that setup command, so normal skill use leads to the migration.
  • Removing the old-path read is a separate later change, made only once no old file is reported.
  • Tests cover: new layer only; old file only (values apply, warning printed); both present (new wins, warning names both).

Placement rule (owner decisions 2026-11-21, #18000 Q1 and #18009 Q2)

For each key in the old user-global file, choose the new home by what the key is:

  • a per-repo convention (what a repository's commits, PRs or files must look like): the team file <home>/<concern>.yaml, with the personal override for one person in one repo; no new userConfig option;
  • a per-user value userConfig can hold (string, number, boolean, directory, file, list of strings): a userConfig option;
  • a per-user structure userConfig cannot hold (a list of objects, a nested map): one file-typed userConfig option naming the user's file, which keeps the structure as it is.

If a key fits none of these, stop as design-change and name the key.

Out of scope

Other plugins' resolvers (one issue each).

Activity

  1. added
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Nov 21, 2026
  2. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 21, 2026
  3. github-actions commented on Nov 21, 2026

    @github-actions
    Contributor

    Size: Medium
    Complexity: Medium
    Uncertainty: Knowable
    Flags: none
    Blocked by: none
    Blast radius: the ai-slop plugin's detect.sh config resolver, its setup command and tests; read by anyone running the ai-slop audit.
    Reversible: yes; revert the change, since the old path keeps being read during the dual-read window.
    Open questions: none
    I read this as moving ai-slop's user-global config (~/.claude/ai-slop.json) onto the config-cascade layers. The old file stays readable with a warning during a dual-read window, and setup migrates and then deletes it. The issue gives a placement rule and acceptance criteria, so I see nothing missing. I found no open duplicate and no merged pull request that already does this.

    Automated triage. A maintainer reviews it.

  4. removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 21, 2026
  5. melodic-automation-lanes commented on Nov 21, 2026

    @melodic-automation-lanes
    Contributor

    {"v":1,"actor_id":337595936,"title_sha256":"53e90bc9f7807c7444ba50a7db59f067f34b559ba4635f1266478d6ef11c223b","body_sha256":"c116e15731e75ae888c48f6df8528523c1428b93a35676d90614e15199619dbe"}

  6. melodic-automation-lanes commented on Nov 21, 2026

    @melodic-automation-lanes
    Contributor

    Not admitted to the issue lane: its body was edited after it was deferred, so the admission it was deferred from judged an older body. Admission takes the issue once each of those is met, when intake triages it again (.github/actions/resolve-config/admission-rules.json).

  7. removed
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Nov 21, 2026
  8. melodic-automation-lanes commented on Nov 21, 2026

    @melodic-automation-lanes
    Contributor

    {"v":1,"actor_id":337595936,"title_sha256":"53e90bc9f7807c7444ba50a7db59f067f34b559ba4635f1266478d6ef11c223b","body_sha256":"82ec44658f1a82abe7885efa31de4dbdc353aad752f8375f02462b6d77c6110a"}

  9. 3 remaining items

  10. github-actions commented on Nov 22, 2026

    @github-actions
    Contributor
    No description provided.
  11. melodic-automation-lanes commented on Nov 22, 2026

    @melodic-automation-lanes
    Contributor

    The work-resolve-issue lane stopped on this issue (issue-edited-trusted): the issue's title or body changed after agent-ready was added, and every change came from a listed human or one of our listed Apps, so intake triage refines and admits the edited text again.
    It set Work status to needs-triage, so the hourly triage sweep sends it back through intake triage, and it waits on no decision from a person.

    In the run's words:

    The run did not start: the issue's title or body changed after agent-ready was added, each change by a listed account, so the runner wrote no issue file for the skill and no model ran.

    Run: https://github.com/melodic-software/claude-code-plugins/actions/runs/44974062263

  12. github-actions commented on Nov 22, 2026

    @github-actions
    Contributor

    The triage sweep dispatched intake triage for this issue (dispatch 1; 2 runs that reach intake, or 6 dispatches, hand it to a maintainer).

  13. melodic-automation-lanes commented on Nov 22, 2026

    @melodic-automation-lanes
    Contributor

    {"v":1,"actor_id":337595936,"title_sha256":"53e90bc9f7807c7444ba50a7db59f067f34b559ba4635f1266478d6ef11c223b","body_sha256":"77403023843fbf60922ec849537be3445ceb788a0561f9fdf7b13c824799e9b2"}

  14. melodic-automation-lanes commented on Nov 22, 2026

    @melodic-automation-lanes
    Contributor

    {"v":1,"actor_id":337595936,"title_sha256":"53e90bc9f7807c7444ba50a7db59f067f34b559ba4635f1266478d6ef11c223b","body_sha256":"77403023843fbf60922ec849537be3445ceb788a0561f9fdf7b13c824799e9b2"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Work status

    agent-ready

    Priority

    medium

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions