Skip to content

attribution: read config from the config-cascade layers, not ~/.claude #18005

Open

Description

@kyle-sexton

Summary

attribution still reads its user-global config from ~/.claude. Move it to the config-cascade layers.

Current behavior

plugins/attribution/skills/audit/scripts/lib.sh:46:

  cfg_layer_add "${HOME:-/nonexistent}/.claude/attribution.json"

Desired behavior

Per the config-cascade layers, ~/.claude/attribution.json moves into userConfig (no user-global file layer). lib.sh reads the contract layers; a file at the old path keeps being read during a dual-read window (see the acceptance criteria) and is reported with a warning. The canonical location list (docs/contracts/config-cascade/locations.md) lands in the docs/config-locations pull request.

Key interfaces

  • lib.sh cfg_layer_add calls and the layer provenance the audit reports

Acceptance criteria

  • The resolver reads the config-cascade layers (the layers).
  • Dual-read window: while an old-path file exists, it is still read and its values still apply where no new-layer file supplies that layer; each run prints one warning naming the old file and the new location to move it to. No setting in an old file is silently dropped.
  • The plugin's setup (check/apply), where it has one, names each old file it finds and after a preview and a yes, moves its settings to the new location, checks the new location resolves the same values, then deletes the old file, so migration ends in one home, never two (owner 2026-11-21: "we don't have dual approaches, and that stuff gets cleaned up"); the dual-read warning names that setup command, so normal skill use leads to the migration.
  • Removing the old-path read is a separate later change, made only once no old file is reported.
  • Tests cover: new layer only; old file only (values apply, warning printed); both present (new wins, warning names both).

Placement rule (owner decisions 2026-11-21, #18000 Q1 and #18009 Q2)

For each key in the old user-global file, choose the new home by what the key is:

  • a per-repo convention (what a repository's commits, PRs or files must look like): the team file <home>/<concern>.yaml, with the personal override for one person in one repo; no new userConfig option;
  • a per-user value userConfig can hold (string, number, boolean, directory, file, list of strings): a userConfig option;
  • a per-user structure userConfig cannot hold (a list of objects, a nested map): one file-typed userConfig option naming the user's file, which keeps the structure as it is.

If a key fits none of these, stop as design-change and name the key.

Out of scope

Other plugins' resolvers (one issue each).

Activity

  1. added
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Nov 21, 2026
  2. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 21, 2026
  3. github-actions commented on Nov 21, 2026

    @github-actions
    Contributor

    Size: Medium
    Complexity: Medium
    Uncertainty: Known
    Flags: none
    Blocked by: none
    Blast radius: the attribution plugin's audit resolver (lib.sh), its setup flow and tests; anyone running the audit with a ~/.claude/attribution.json file.
    Reversible: yes; revert the change, since the old path stays read during the dual-read window.
    Open questions: none
    Understood: move attribution's user-global config read from ~/.claude/attribution.json to the config-cascade layers, keeping a warned dual-read window for the old file, a setup offer to copy keys, and tests for the new-only, old-only and both cases. The acceptance criteria are exact, so nothing is missing. I found no duplicate among open issues and no merged fix among recent pull requests.

    Automated triage. A maintainer reviews it.

  4. removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 21, 2026
  5. melodic-automation-lanes commented on Nov 21, 2026

    @melodic-automation-lanes
    Contributor

    {"v":1,"actor_id":337595936,"title_sha256":"b97c7be9da2868f3e74d10fb623f3e573d75f4b6c1508bb1b5a38fb31f1efb13","body_sha256":"b0473302ccd517458721b9ecb5bfc764845c131e5c70daf7632969215db6f941"}

  6. melodic-automation-lanes commented on Nov 21, 2026

    @melodic-automation-lanes
    Contributor

    Not admitted to the issue lane: its body was edited after it was deferred, so the admission it was deferred from judged an older body. Admission takes the issue once each of those is met, when intake triages it again (.github/actions/resolve-config/admission-rules.json).

  7. removed
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Nov 21, 2026
  8. melodic-automation-lanes commented on Nov 21, 2026

    @melodic-automation-lanes
    Contributor

    {"v":1,"actor_id":337595936,"title_sha256":"b97c7be9da2868f3e74d10fb623f3e573d75f4b6c1508bb1b5a38fb31f1efb13","body_sha256":"c589c6c2d28bfa37e526dfb39d04335c90b5f36d41fb5d6c30448fc867bf3d3d"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Work status

    agent-ready

    Priority

    medium

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions