Skip to content

pr-verify: trust intake-triage-briefed issues the owner has not vetoed (owner standing rule) #18093

Closed

Description

@kyle-sexton

Route: local. #18089 (open) delivers this issue; no lane build.

Problem

pr-verify and the babysit merge gate refuse an issue the lanes App filed as spec (verify:untrusted-spec), even when intake-triage has briefed it and the owner has not stopped it. Each such issue then waits for an owner confirmation (#16032 for #17926, #18063 for #18075).

The owner chose a standing rule: an issue that intake-triage has briefed and the owner has not vetoed counts as trusted spec for pr-verify, with no case-by-case confirmation. This loosens the untrusted-spec check in pr-verify (.github/scripts/pr-verify/resolve-pr.mjs) and in the babysit merge gate's verify:untrusted-spec refusal (plugins/source-control/skills/babysit-prs/scripts/babysit_verify_evidence.py).

Owner decision: https://github.com/melodic-software/architecture/blob/main/docs/owner-decisions.md?plain=1#L318

Question: "Bot-filed issues keep failing pr-verify on untrusted spec (#16032, #18063). Do you want a standing rule so one answer covers the whole class?" verbatim: "Standing rule (Recommended)"

Done when

  • pr-verify's spec resolver and the babysit merge gate both treat a lanes-App-filed issue as trusted spec only when it carries intake-triage's own brief record, written by the lanes App, and no owner veto (a hold or stop label, or a needs-info exit).
  • Tests cover four cases: a briefed issue is trusted; an unbriefed bot issue is untrusted; a briefed but vetoed issue is untrusted; a forged brief marker in a comment not written by the App is untrusted.
  • The code comment where the rule is enforced cites the owner-decisions row above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions