Repository navigation
fix(repin): keep the open re-pin PR open when a newer release re-runs it - #17333
Conversation
A re-run reset chore/repin-ci-workflows to the base before committing, which emptied the open PR's diff; GitHub closed it, and the auto-merge step then failed on the closed PR (run 44433009022, #17322). The commit is now built on a scratch branch and the PR branch moved to it in one force update. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review: PR #17333I read the whole change in What changed: the step used to reset
Checks against the trust boundary:
No trust control, kill switch, merge hold, plugin manifest or instruction surface is touched. critical-findings: 0 |
|
claude-review reviewed Code review: no findings. This is a full review: no earlier head was reviewed and the prior-findings file lists no posts. What the change does: in What I checked:
One candidate I dropped as too minor to post: the scratch name uses Verification: the PR's claims that Criteria sources: there's no closing issue ("No related issue"), so no acceptance criteria apply. No Loosened-check verdict: fail (default; the prompt carried no Verifier dropped 0 of 0 candidates. |
No related issue: defect found and fixed while re-running the ci-workflows re-pin for v0.76.1.
Summary
When a newer ci-workflows release re-runs
maintenance-repin-ci-workflows.ymlwhile its earlier re-pin PR is still open, the step resetchore/repin-ci-workflowsto the base before committing. That emptied the open PR's diff, GitHub closed the PR, and the finalgh pr merge --autofailed on the closed PR: run 44433009022 closed #17322 (GraphQL: Pull request Pull request is closed (enablePullRequestAutoMerge)).Fix
createCommitOnBranchon a scratch branchchore/repin-ci-workflows-<run id>created at the base, and the scratch branch is deleted on exit.chore/repin-ci-workflowsthen moves to that commit in one force update (or is created there), so an open PR's diff is never empty.chore/*branches (only the default branch andrelease/plugins), so the App can create and delete the scratch branch.Verification
actionlintpasses on the changed workflow.Related
🤖 Generated with Claude Code
https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C