Repository navigation
ci(lanes): keep the lane sweep's telemetry through the sealed receiver - #17400
Conversation
upload-lane-transcript takes an optional otel-file: the leg's telemetry is scanned on its own after the transcript is sealed, sealed under the payload name otel.jsonl.gz to the same run and job, and uploaded in the same artifact. A scan hit, a seal failure or an artifact past the puller's 64 MiB limit leaves the telemetry out with an annotation; the transcript still uploads. scan-upload's SCAN_WITHHOLDS names what a hit withholds. maintenance-audit-lane-runs.yml's three assess-units legs set otel-receiver: "true" and pass their otel-file to the upload. callers.test.mjs checks that every otel-file is its own leg's, from a launcher with the receiver on. Refs: #17261 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review: PR #17400 (incremental, head 8be72d4)No security issues found. This was an incremental, blocking-only review, because this lane already reviewed head
What changedWhen a scan hit withholds a file, the step-summary header now reads What I checked
critical-findings: 0 |
|
claude-review reviewed Code review, incremental (9e1c0ca → 8be72d4)No new findings. I read every hunk of both files in scope: What changed: the step-summary header in This fixes the earlier finding (discussion_r4625386841), which the owner's reply on that thread marks as fixed in this commit. What I checked by reading the code (no tests or commands run):
Closing issue: the PR says Loosened checks: none. Both test edits only add assertions. Loosened-check verdict: fail. That is the default, because the prompt had no Verifier dropped 0 of 0 candidates. |
With SCAN_WITHHOLDS set, the summary header said the whole upload was withheld while the transcript still uploads. Build the header from the same value as the annotation, and assert on it in the test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs: #17261
Summary
Opts the lane sweep (
maintenance-audit-lane-runs.yml, its threeassess-unitslegs) into run-claude-cli's sealed telemetry receiver, and teaches this repository'supload-lane-transcriptto carry the leg'sotel-filebeside the transcript.The re-pin half of the issue is already on main: the scheduled re-pin job merged #17376, which moved every
melodic-software/ci-workflowsaction pin from v0.75.0 to v0.76.3, a release after v0.76.0 that carries ci-workflows#1136. This PR does not touch a pin. The one v0.75.0 pin left,check-managed-filesinpr-check-managed-files-hosted.yml, is left to the standards sync, as the re-pin job states.Fix
upload-lane-transcripttakes an optionalotel-file(empty by default, so every other caller is unchanged). After the transcript is sealed, the telemetry gets its own scan and its own seal, bothcontinue-on-error. It is sealed under the payload nameotel.jsonl.gzto the same key, run id and job id, and uploaded in the same artifact asotel.jsonl.gz.sealed. A scan hit, a seal failure, or an artifact that would pass the puller's 64 MiB limit leaves the telemetry out with an annotation, and the transcript still uploads. This follows the ci-workflows copy of the action at v0.76.3. The local copy is extended because every lane here uploads through it, andcallers.test.mjsmatches only the local path, so switching one lane to the ci-workflows copy would add a second way to upload.scan-uploadtakes an optionalSCAN_WITHHOLDS. When the telemetry scan finds something, the error line says the telemetry is left out and the transcript still uploads, not "nothing is uploaded".The lane.
maintenance-audit-lane-runs.ymlsetsotel-receiver: "true"on its key, subscription and fallbackassess-unitslegs, and passes each leg's ownotel-fileto its upload. Only one leg judges each unit, so turning on all three keeps a handoff from silently dropping telemetry.Lane choice (the issue leaves it open; the intake triage suggests a low-traffic lane). I picked the lane with the lowest blast radius among the 13 workflows that run run-claude-cli. Its legs:
The other candidates write pull requests or comments (
maintenance-tidy-code-upkeep.yml, thepr-*lanes), or run only on an admin dispatch (maintenance-measure-skill-edit.yml,maintenance-verify-whole-map.yml).Trust boundary: unchanged. Basis: ci-workflows
run-claude-cli/lane.cjsat v0.76.3,legEnv:OTEL_*,CLAUDE_CODE_OTEL_*,BETA_TRACING_ENDPOINTandENABLE_BETA_TRACING_DETAILEDvariable, soOTEL_LOG_USER_PROMPTSandOTEL_LOG_TOOL_DETAILSstay unset and prompt and tool content stay redacted.127.0.0.1(otlp-receiver.cjs).apply-claude-managed-settingscalls pass nosettings, so no managed OTLP endpoint overrides this.Telemetry therefore leaves the runner only as ciphertext, through the same scan, key, artifact and 7-day retention as the transcript, to the same puller.
Verification
node --test --test-concurrency=4over the 11 files that read the changed actions or the lane workflow: 1353 tests, 1353 passed, 0 failed. The files:callers.test.mjs,seal-transcript.test.mjs,scan-upload.test.mjs,check-kill-switch.test.mjs,admit.test.mjs, the threemaintenance-audit-lane-runs/*.test.mjs,pr-merge/workflow.test.mjs,security-outside-actor/flag.test.mjsandlane-transcripts/pull.test.mjs.otel.jsonl.gzand its own run.SCAN_WITHHOLDSreplaces "nothing is uploaded" in the error line.callers.test.mjschecks that every upload'sotel-fileis the same leg's output, from a launcher withotel-receiver: "true", and thatotel-receiverappears only on a launcher.actionlintpasses on the lane workflow.otel-receiverbefore this PR, and the input defaults tofalse;upload-lane-transcript,scan-uploadandseal-lane-output;scripts/lane-transcripts/pull.mjs, which accepts one extra*.sealedentry in an artifact and does not open it.Not verified here: a run of the lane with the receiver on. Its jobs run only on
refs/heads/main.Remaining
scripts/lane-transcripts/pull.mjsto openotel.jsonl.gz.sealedand write the telemetry and its trace join to the sink (a follow-up PR from this session).maintenance-audit-lane-runs.ymlon main, run the pull, and confirm the sink holds the sealed telemetry and its spans join the row'strace_id.pr-pipeline-sandboxsyncsupload-lane-transcript,scan-uploadandresolve-configbyte for byte (scripts/lanes/check-sync.shthere), so it needs the same files once this merges.Related
otel-fileinput of the ci-workflows upload action.🤖 Generated with Claude Code