Repository navigation
chore(formal): move the carry-forward model to the report-ci-status sync commit - #17412
Conversation
…ync commit PR #17283 (726f82d) runs ci-status on ci-workflows' report-ci-status composite at v0.76.3 (9c5bedf). The carry-forward behavior is unchanged, only moved: - The composite fixes yield-to-full-run 'true' and carry-forward-wait-seconds '0' and calls aggregate-results through `$/` at the same commit, so RUN and ACTION are read at 9c5bedf. - Its contract and draft steps are continue-on-error, so the step the writer check reads concludes on the lanes alone, as the model's gate does. - The hold drops to 0 on a contract-only run whose job, contract or draft step failed: the Hold = FALSE case YieldNoHold.cfg already checks. - aggregate-results run.sh changed between v0.75.0 and v0.76.3 only by extracting in_flight_sibling_ids, run_attempt_of and finish_carry_forward; aggregate-results action.yml is unchanged. The model's comments re-cite WF, RUN and the new REPORT lines; the state machine is untouched. TLC at the new commit: Yield.cfg holds every rule (4,788,560 states), YieldNoHold.cfg too (880,975), the seeded break (Yield = FALSE) breaks NoStaleCarry after 5,056 and 7,972 distinct states, Yield.cfg without VIEW holds (21,746,774 states), and NoStaleCarryAtPass still breaks in the known 10 steps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed Code review: no findingsThis pull request only changes citations. It moves the I read all three changed files in full ( Workflow citations I checked against
The workflow's own comment at WF:7029-7031 says that Not verified (no shell or GitHub access):
Closing issue: none. The pull request says it follows up #17283 and closes no issue, so there are no acceptance criteria to check. Loosened checks: none. Only comments, documentation and the sync commit change. The model's rules, configs and seeded breaks keep their meaning, and both seeded breaks are still recorded as Loosened-check verdict: fail (default; the prompt had no No plugin manifests changed. I found no embedded instructions in the pull request context. Verifier dropped 0 of 0 candidates. |
|
claude-security-review reviewed Security review: PR #17412Result: no security issues found. I read all three changed files in full. All of them sit under the trusted
Trust controls: none touched. The diff does not change Embedded text: the PR context has no directives aimed at the review lane. critical-findings: 0 |
No related issue: follow-up to #17283, which moved ci-status onto the report-ci-status composite; this moves the carry-forward formal model's sync commit to it.
Summary
The
formal-ci-lanes-carry-forwardmodel now describespr-require-checks.ymlat 726f82d (#17283), where ci-status runs ci-workflows'report-ci-statuscomposite at v0.76.3 instead ofaggregate-resultsdirectly. The carry-forward behavior did not change, it moved: the model's state machine is untouched and only its source citations and the sync commit move.Fix
CarryForward.tla: comments re-citepr-require-checks.yml,aggregate-results/run.shat 9c5bedf, and the newreport-ci-status/action.yml(it fixesyield-to-full-run: 'true'andcarry-forward-wait-seconds: '0', and its contract and draft steps arecontinue-on-error, so the writer step still concludes on the lanes alone).SKILL.md: names the composite as a covered source, its inputs in "Updating", and the new no-VIEW result.sync.yaml: both checks and their seeded breaks move to 726f82d.Why the semantics hold: between v0.75.0 and v0.76.3,
aggregate-results/run.shonly extractedin_flight_sibling_ids,run_attempt_ofandfinish_carry_forward, andaggregate-results/action.ymlis unchanged. The composite's new hold drop (0 on a contract-only run whose job, contract or draft step failed) is theHold = FALSEcaseYieldNoHold.cfgalready checks.Verification
/formal-verification:chart, one worker):Yield.cfgholds TypeOK, NoStaleCarry, HeldPassIsNewer, PassCarriesSuccess and NoDeadlock over 4,788,560 states;YieldNoHold.cfgholds all of them over 880,975.Yield = FALSE): NoStaleCarry breaks after 5,056 distinct states inYield.cfgand 7,972 inYieldNoHold.cfg, 11 steps each (caught).Yield.cfgwithoutVIEWholds over 21,746,774 states (3 min 34 s);NoStaleCarryAtPassstill breaks in the known 10 steps.plugins/formal-verification/scripts/check.mjson the skill: 0 failures, 0 warnings.Related
🤖 Generated with Claude Code
https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C