Skip to content

chore(formal): move the carry-forward model to the report-ci-status sync commit - #17412

Merged
kyle-sexton merged 1 commit into
mainfrom
chore/carry-forward-model-sync
Nov 19, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
chore/carry-forward-model-sync

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: follow-up to #17283, which moved ci-status onto the report-ci-status composite; this moves the carry-forward formal model's sync commit to it.

Summary

The formal-ci-lanes-carry-forward model now describes pr-require-checks.yml at 726f82d (#17283), where ci-status runs ci-workflows' report-ci-status composite at v0.76.3 instead of aggregate-results directly. The carry-forward behavior did not change, it moved: the model's state machine is untouched and only its source citations and the sync commit move.

Fix

  • CarryForward.tla: comments re-cite pr-require-checks.yml, aggregate-results/run.sh at 9c5bedf, and the new report-ci-status/action.yml (it fixes yield-to-full-run: 'true' and carry-forward-wait-seconds: '0', and its contract and draft steps are continue-on-error, so the writer step still concludes on the lanes alone).
  • SKILL.md: names the composite as a covered source, its inputs in "Updating", and the new no-VIEW result.
  • sync.yaml: both checks and their seeded breaks move to 726f82d.

Why the semantics hold: between v0.75.0 and v0.76.3, aggregate-results/run.sh only extracted in_flight_sibling_ids, run_attempt_of and finish_carry_forward, and aggregate-results/action.yml is unchanged. The composite's new hold drop (0 on a contract-only run whose job, contract or draft step failed) is the Hold = FALSE case YieldNoHold.cfg already checks.

Verification

  • TLC (/formal-verification:chart, one worker): Yield.cfg holds TypeOK, NoStaleCarry, HeldPassIsNewer, PassCarriesSuccess and NoDeadlock over 4,788,560 states; YieldNoHold.cfg holds all of them over 880,975.
  • Seeded break (Yield = FALSE): NoStaleCarry breaks after 5,056 distinct states in Yield.cfg and 7,972 in YieldNoHold.cfg, 11 steps each (caught). Yield.cfg without VIEW holds over 21,746,774 states (3 min 34 s); NoStaleCarryAtPass still breaks in the known 10 steps.
  • plugins/formal-verification/scripts/check.mjs on the skill: 0 failures, 0 warnings.
  • Left out: nothing.

Related

🤖 Generated with Claude Code

https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C

…ync commit

PR #17283 (726f82d) runs ci-status on ci-workflows' report-ci-status
composite at v0.76.3 (9c5bedf). The carry-forward behavior is unchanged,
only moved:

- The composite fixes yield-to-full-run 'true' and
  carry-forward-wait-seconds '0' and calls aggregate-results through `$/`
  at the same commit, so RUN and ACTION are read at 9c5bedf.
- Its contract and draft steps are continue-on-error, so the step the
  writer check reads concludes on the lanes alone, as the model's gate
  does.
- The hold drops to 0 on a contract-only run whose job, contract or draft
  step failed: the Hold = FALSE case YieldNoHold.cfg already checks.
- aggregate-results run.sh changed between v0.75.0 and v0.76.3 only by
  extracting in_flight_sibling_ids, run_attempt_of and
  finish_carry_forward; aggregate-results action.yml is unchanged.

The model's comments re-cite WF, RUN and the new REPORT lines; the state
machine is untouched. TLC at the new commit: Yield.cfg holds every rule
(4,788,560 states), YieldNoHold.cfg too (880,975), the seeded break
(Yield = FALSE) breaks NoStaleCarry after 5,056 and 7,972 distinct states,
Yield.cfg without VIEW holds (21,746,774 states), and NoStaleCarryAtPass
still breaks in the known 10 steps.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 19, 2026 07:18
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T07:20:20.456479Z 724469c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed 724469c180571fd9b6a043dd18c971f1b0b88133: read 3 of 3 changed file(s); 0 finding(s), 0 as inline comments.

Code review: no findings

This pull request only changes citations. It moves the formal-ci-lanes-carry-forward model's sync commit to 726f82d (#17283), where ci-status runs the report-ci-status composite. It re-cites line numbers in CarryForward.tla comments and updates SKILL.md and sync.yaml to match. The model's state machine, its invariants and the .cfg files are unchanged.

I read all three changed files in full (SKILL.md, CarryForward.tla, sync.yaml).

Workflow citations I checked against .github/workflows/pr-require-checks.yml at head:

  • WF:7018: the report-ci-status@9c5bedf… pin (v0.76.3), which matches the commit cited in the model header.
  • WF:7015-7049: the Aggregate lane results step.
  • WF:7045: yield-wait-seconds (600, or 0 on a draft).
  • WF:761-772: the three tries in mark-lanes and its exit 1.
  • WF:4109-4110: ci-status needs: mark-lanes.
  • WF:4132: if: ${{ !cancelled() }}.

The workflow's own comment at WF:7029-7031 says that REPORT:128-129 fixes yield-to-full-run: 'true' and carry-forward-wait-seconds: '0'. That agrees with the model's REPORT:128 and REPORT:129 citations.

Not verified (no shell or GitHub access):

  • The REPORT: and RUN: line numbers point into melodic-software/ci-workflows at 9c5bedf, which I could not read.
  • That 726f82d is the last commit to touch the covered file.
  • The TLC state counts, the seeded-break results and the 3 min 34 s no-VIEW run. These are the author's claims.

Closing issue: none. The pull request says it follows up #17283 and closes no issue, so there are no acceptance criteria to check.

Loosened checks: none. Only comments, documentation and the sync commit change. The model's rules, configs and seeded breaks keep their meaning, and both seeded breaks are still recorded as caught: true. Moving the sync commit counts as a pin or repin, which this criterion does not treat as a loosening.

Loosened-check verdict: fail (default; the prompt had no loosened_check_verdict: or loosened_check_patterns: line); patterns: 0. The prompt had no loosened_check_decision_record: line either, so I did not check the citation requirement.

No plugin manifests changed. I found no embedded instructions in the pull request context.

Verifier dropped 0 of 0 candidates.

@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 724469c180571fd9b6a043dd18c971f1b0b88133: read 3 of 3 changed file(s); 0 finding(s), 0 as inline comments.

Security review: PR #17412

Result: no security issues found.

I read all three changed files in full. All of them sit under the trusted **/.claude/** glob, so each got the full trusted-path read:

  • .claude/skills/formal-ci-lanes-carry-forward/SKILL.md: the description and prose now name the ci-workflows report-ci-status composite as a covered source, and the "Updating" section lists its inputs. The skill keeps disable-model-invocation: true. The only standing instruction in the "Updating" section ("A promise changed on purpose means a rule changes, and only with the owner's yes. Never weaken a rule to make it hold.") is still there word for word. No guardrail is deleted, narrowed or softened, so the instruction-surface lens finds nothing.
  • .claude/skills/formal-ci-lanes-carry-forward/model/CarryForward.tla: only TLA+ comments change. They update line citations and the pinned ci-workflows commit the comments describe. The state machine (actions, invariants, constants) is unchanged.
  • .claude/skills/formal-ci-lanes-carry-forward/sync.yaml: the commit fields move from c4fe439d… to 726f82db…, and the seeded-break descriptions are reworded. The command: lines are unchanged.

Trust controls: none touched. The diff does not change .github/workflows/pr-require-checks.yml, any merge-hold script, the trusted-trigger check, the token broker or the kill switch. It only changes a formal model that describes the ci-status hold logic. Its comments and sync pins have no effect on what CI enforces.

Embedded text: the PR context has no directives aimed at the review lane.

critical-findings: 0

@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit a728673 Nov 19, 2026
63 of 75 checks passed
@kyle-sexton
kyle-sexton deleted the chore/carry-forward-model-sync branch November 19, 2026 08:18
@github-actions github-actions Bot added the merge-path: owner-agent Post-merge accounting record (README.md, Merge paths) label Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-path: owner-agent Post-merge accounting record (README.md, Merge paths)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant