Repository navigation
feat(planning): build the remaining interview friction fixes from the 17279 audit - #17938
Conversation
Lane-Activity: work-resolve-issue/resolve-issue
|
Held for the before-and-after eval that cut item #17736 needs. The pr-merge release step lifts this hold when an eval-pair record exists for the current head. |
|
claude-security-review reviewed Security review: PR #17938 at a9aacc9 (incremental since 063c9c1)No security issues found. This lane already reviewed an earlier head, so this review was blocking only: it reports only CRITICAL and IMPORTANT findings. Scope: I read the whole incremental change to the one listed file, What changed:
Security check:
Trust controls: the changed file matches no Instruction-surface lens: this push deletes no standing instruction. The removed comment lines were moved word for word into the heredoc, with one bullet added. Settled threads:
Prior findings: the only earlier post was a summary that reported no issues, so nothing carries forward. Embedded text: the PR context and the settled threads contain no directive aimed at this lane. Spend: none. critical-findings: 0 |
|
claude-review reviewed Code review: PR #17938 at
|
…open-questions.sh Lint Repo's comment-lint flagged the edited round-number bullet (:83) as a comment outside the necessary posture. Restoring main's wording would leave it wrong, since a `round <N> (added in round <M>)` field now counts as round N (round_field_re), so the bullet goes. The --procedure behavior is unchanged; check-open-questions.test.sh passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review thread PRRT_kwDOTCGFQM66XvC6: the sweep's new deferred disposition (arbiter /planning:design) had no export tag, so a page-lane Brief either lost the route to /planning:plan or failed the Step 4 --surface cross-check. export-brief now tags a retired register row, or a restated deferred or planningOwned bullet, **arbiter: /planning:design** when its text says /planning:design (USER-RESERVED still wins), and surface.md says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
surface-checks AC35 allows a skill token in exporters.py only on the arbiter constant lines; DESIGN_ROUTE now derives from ARBITER_DESIGN, and the exemption names ARBITER_PLAN and ARBITER_DESIGN. The exemption's comment still names only ARBITER_PLAN because comment-lint rejects an edited comment line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # plugins/planning/tests/interview-defenses.test.sh
pr-verify fail note PRRT_kwDOTCGFQM66YjXK asks for the --procedure round-number bullet back in the --help text, with the widened round field. The help text was the script's header comment, printed by a sed sentinel range, and comment-lint (necessary posture) rejects any added header line. usage() now prints the same text from a quoted heredoc, so it is code, and the bullet returns: round numbers run contiguously from 1, and a round field other than `round <N>` or `round <N> (added in round <M>)` is a defect. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The unattended merge path is about to arm native auto-merge at head |
|
Merge-Risk: max=MEDIUM demote=false head=a9aacc92ec43b7461d6e5b41d3be8cb058b0d6fc rubric=10.4.5 rater=claude-opus-5-5 checker=claude-opus-5-5 |
Closes #17736
Summary
Opened by the work-resolve-issue lane. The run's own summary:
Not verified
scopereturn line still reads '/planning:plan by default, USER-RESERVED under the rule in loop.md'. It was left byte-identical so the pinned Step 4 section, which holds the Brief cross-check, stays unchanged; the loop.md rule it points at now lists /planning:designFix
round <N> (added in round <M>)through a newround_field_re(still exactlyround <N>otherwise), with a round-field error message naming both shapes; the --help usage text no longer carries the round-number bullet, because the header comment is the --help text and comment-lint (necessary posture) rejects an added or edited header line; the error message is where the accepted shapes are stated; the…added in roundrow passes --procedure, and five extra-text cells (the(sweep)variant included) fail and are named on stderr; a re-ask-only round with no round number passes, and one that took a…added in roundcell and adds the re-ask-only round rule (no new round number; its draft goes below the round it follows); the Brief template's Deferred questions line and the arbiter paragraph…Verification
The runner ran each check from the base copy against aca1b64:
The run reports:
Left out: the items under Not verified.
Related
#17736