Repository navigation
docs(review): record the bundled code-review scope as of Claude Code 2.1.328 - #18023
melodic-automation-lanes[bot] wants to merge 3 commits into
Conversation
Lane-Activity: work-resolve-issue/resolve-issue
|
claude-security-review reviewed Security review (incremental, blocking only): no security issuesI read the whole incremental diff (
Security relevance: none.
Instruction surface: the change adds a descriptive observation about a native command's behaviour. It deletes, narrows or softens no rule that forbids an action, so no protected-class check applies. Embedded text: nothing in the PR context tells the lane to pass the PR, skip a check or drop a finding. Prior findings: this lane's only earlier post was a summary with 0 findings. There is nothing to restate. This review was blocking only, since this lane already reviewed an earlier head. critical-findings: 0 |
|
claude-review reviewed Code review: PR #18023 (incremental, 87c556c → be91a01)This push brings back the defect this lane flagged earlier, so there is one blocking finding. This lane already reviewed an earlier head, so this review covered blocking findings only. What changed since the last review. One file changed:
The owner asked for this in a reply on another thread. Blocking finding (inline). The added sentence breaks Settled threads. The owner's reply (kyle-sexton) on the thread at L1 is a decision to state the 2.1.328 scope in the record. The finding that thread answers was withheld, so I can't confirm it raised the same point. The rule still forbids this text, so I reported it and left the trade-off to the owner. Closing issue. The PR says Loosened checks. The prompt gave no Other checks.
Verification. The PR's check results and the changelog item numbers (2.1.328-124 and -125) are the author's claims, and I did not check them. I ran no commands and fetched neither linked page. Spend. This review run used prepaid credits only. Verifier dropped 0 of 0 candidates. |
Lane run report
Run 44951822055, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
Lane-Activity: pr-unblock/address-feedback Lane-Thread: PRRT_kwDOTCGFQM66bSE9
Lane run report
Run 44940316630, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
|
pr-unblock / address-feedback finished round 1 of max 4 on 87c556c. |
Lane run report
Run 44951822055, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
|
Unattended merge: native auto-merge leaves this pull request unarmed at head |
…ation pr-verify fail note PRRT_kwDOTCGFQM66bd79: #17908's first done-when item asks the record to state the current /code-review scope and the Claude Code version it was read from. The extraction record now states it as of 2.1.328, read 2026-11-21 from changelog items 2.1.328-124 and 2.1.328-125: on most models it reports only bugs and CLAUDE.md violations, sends reuse, simplification and efficiency cleanups to /simplify, and marks findings Important, Pre-existing or Nit. The live commands-row pointer stays for anything newer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RAoAtWJiWJdXQiPG8Xswsu
| That menu description is history, not the current scope. The scope as of Claude Code 2.1.328, read | ||
| 2026-11-21 from that release's changelog (items 2.1.328-124 and 2.1.328-125): on most models | ||
| `/code-review` reports only bugs and CLAUDE.md violations, sends reuse, simplification and | ||
| efficiency cleanups to `/simplify`, and marks each finding Important, Pre-existing or Nit. Nothing |
There was a problem hiding this comment.
This brings back the restated upstream scope that the previous push removed. The sentence from "The scope as of Claude Code 2.1.328, read 2026-11-21…" through "…Important, Pre-existing or Nit." paraphrases what the bundled /code-review reports. It also copies its severity labels.
.claude/rules/skill-bodies-state-current-rules.md applies to plugins/*/skills/**. It says:
A skill or agent body never restates a volatile upstream specific, quoted or paraphrased.
A record never cures a restatement: restated text with an as-of stamp or
Claim/Basisblock beside it is still the defect, fixed by deleting the restated value and keeping the pointer.
The new sentence breaks the rule whichever class it falls in:
- As described behavior ("reports only bugs and CLAUDE.md violations", "sends … cleanups to
/simplify"), the rule classes it as a pointer. A pointer carries no date, yet this one has "read 2026-11-21". - As copied strings (
Important,Pre-existing,Nit), it is a stored value. A stored value needs a recheck trigger, and none is given.
The paragraph also contradicts itself. Its last sentence still says to read what the bundled skill "reports now" live from the commands row, because nothing in this lane acts on that scope. So the copy can only drift. The 2.1.263 text this PR is retiring is exactly that kind of drift.
scripts/check-as-of-recheck.sh won't catch this. Its stamp pattern needs as of YYYY-MM-DD, and here the version sits between "as of" and the date.
The owner asked for this sentence in a reply on another thread. This lane's earlier thread on the same text is marked lines changed since resolution: yes, so I'm raising it again. To settle it, do one of these:
- (a) Drop the sentence and keep the pointer:
That menu description is history, not the current scope. Nothing in this lane acts on the bundled skill's scope. When someone needs to know what it reports now, …
- (b) Keep it as an owner decision. Record an exception for this file in
docs/conventions/instruction-exception-register/or in the rule, so the next review doesn't flag it again.
If you choose (b), update the PR body to match the head. Its "Fix" section says the paragraph has "no as-of date, no recheck trigger and no paraphrase of upstream behavior".
claude-lane: claude-review
There was a problem hiding this comment.
pr-unblock / address-feedback: UNCERTAIN, left open
Evidence: plugins/review/skills/code-review/reference/bundled-code-review.md:42, .claude/rules/skill-bodies-state-current-rules.md:10, .claude/rules/skill-bodies-state-current-rules.md:30
The finding reads correctly against the rule. Lines 42-45 paraphrase the bundled /code-review scope as of 2.1.328 and copy its severity labels. The rule says a skill body never restates a volatile upstream specific, and that adding a date or record beside a restatement does not fix it. The paragraph's last sentence also still sends readers to the live commands row. I did not apply either fix because both need a person. The head commit (be91a01d, 'record the 2.1.328 /code-review scope as a dated observation') added this sentence, and the finding says the owner asked for it on another thread. This thread carries no direction from a trusted person, so dropping the sentence (option a) would undo an owner's request on a bot's say-so. Option (b) needs an exception entry in docs/conventions/instruction-exception-register/README.md, and check-paths refuses that file. Owner, please choose: (a) delete the sentence from 'The scope as of Claude Code 2.1.328' through 'Important, Pre-existing or Nit.' and keep the pointer, or (b) record an exception and make the PR body's Fix section match the head.
|
pr-unblock / address-feedback finished round 2 of max 4 on be91a01. |
|
The pr-unblock lane stopped on this pull request and needs a person: an adjudicator found that a disputed review finding turns on what the change is meant to do, which a person decides. Reason:
To resume, deal with the reason above, remove the gh workflow run pr-unblock.yml -R melodic-software/claude-code-plugins -f pr-number=18023 -f activity=address-feedback |
Lane run report
Run 44951822055, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
Refs: #17908
Summary
Opened by the work-resolve-issue lane. In bundled-code-review.md's extraction record, the old 2.1.263 menu description, which had the bundled /code-review review for bugs and cleanups, stays as history and is no longer presented as the current scope. Following review feedback, the record does not paraphrase the current scope. It notes that nothing in this lane acts on that scope and points to the /code-review row of the commands reference, where the scope is read live, with the 2.1.328 changelog entry to correlate with.
The second done-when item is still open: re-extracting the two code-review rows in docs/native-surfaces/records.json, then regenerating docs/native-surfaces.md. That needs /harness-ops:audit-native-overlap on a host with the installed Claude Code binary. This lane cannot run inventory.py or overlap.py, and the issue rules out a hand edit, so this PR leaves that item and the issue stays open.
Remaining work
Not verified
Fix
Verification
The runner ran each check from the base copy against d9fdb72:
The run reports:
/code-reviewon most models to report only bugs and CLAUDE.md violations; run/simplifyfor reuse, simplification...", and the newest heading was 2.1.330Left out: the items under Not verified.
Related
#17908