Repository navigation
fix(themes): make the bedroom's click areas disjoint and show a covered room on the card - #18032
Conversation
…ed room on the card The console, tape spine and lava lamp click rectangles overlapped their neighbors, so one click flipped two switches. Narrow them in HITS and in the shader's HIT and HIT2 tables (console 46 -> 38, spine 21 -> 20, lava 42 -> 39), and test that no two rectangles meet under the inclusive edge rule both checks use. While the room is on, another plugin's theme.set now marks the room as covered. The settings card then says "theme: covered" and its theme button sets the room again instead of clearing; /bedroom on does the same, and /bedroom status names the covering plugin. Closes #17509 Refs: #18020 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c6e6884b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Lane run report
Run 44944084128, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
|
claude-review reviewed Code review (incremental, blocking only): PR #18032 at
|
|
claude-security-review reviewed Security review (incremental, blocking only): no security issues foundThis review covers only the changes since What I checked:
Other checks:
Spend: none. critical-findings: 0 |
|
The pr-verify verifier failed head What it wrote (25 lines)This pull request leaves the merge queue, and ci-status holds it out while it carries |
A Node suite reads lights.ts and scene/lib.ts as text and asserts each switch's HITS rectangle equals its HIT or HIT2 row, so a regeneration from a source with other rectangles fails. The mod test kit cannot read files or import the shader module, so the check lives beside the plugin's other shell-discovered suites. A card test covers a covering plugin that clears its own theme: the room comes back and the open card says "theme: on" again, with a button that clears. Refs: #17509 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs: #17509
Refs: #18020
The settings-card change is the owner's decision recorded at #18020 (comment).
Summary
Two bug fixes in the
themesplugin's bedroom theme:theme: on, and its theme button cleared that plugin's theme instead of bringing the room back.Part of #17509 is delivered here:
HITSis disjoint.lights.tsmatch it.HITS.The shader's source, which is outside this repository, is not changed, and
lights.tsis not regenerated. See Remaining.Fix
scene/lib.tsHITSand the shader'sHIT/HIT2tables inlights.tsnow agree on narrower rectangles:Both hit tests include the edges, and these edges no longer meet.
lights.tswas edited directly, on those two table lines only. No available build script reproduces the file on main, so it could not be regenerated faithfully.A
theme.sethook (register.tsx) records that the room is covered when another plugin sets a theme while the room is on. Like the existingtheme.clearhook, it keys onnext.origin.plugin. It never sets the room again by itself: the other plugin's theme stays until the person asks for the room.In the covered state:
theme: covered, and its button runs/bedroom on. That sets the room's look again without callingtheme.clear, which would remove every theme./bedroom onanswersthe room is back./bedroom statusnames the covering plugin.Verification
claude plugin test plugins/themes: 136 pass, 0 fail.plugins/themes/tests/shader-hits.test.sh(Node): 1 pass. It parses theHITandHIT2lines oflights.tsand theHITSblock ofscene/lib.tsas text, and asserts that each switch's rectangle equals its shader row. The rows are tv, lava, pc, lamp, tape, console, light, with the spine inHIT2. Run against main's oldlights.tsit fails (lava is HIT row 1), so a regeneration from the old source fails the suite.HITS, naming exactly the three overlaps in the issue (console and spine,light and lava,spine and lava), and passes now./bedroom onsends onesetand noclear.theme: on, thentheme: covered, then back totheme: on, and a press while covered sends onesetand noclear.theme: onagain; its button then clears.claude plugin validate plugins/themespasses, with warnings. On the changed files, the only warnings are TS5097 (an import path ending in.tsor.tsx), the same kind other files in the plugin get.Remaining
lights.tsmust then be regenerated from it. Until then, a regeneration from the current source brings the overlap back, andshader-hits.test.shfails on it.Related
theme.clearremoves every plugin's theme. This is why the covered card sets the room again instead of clearing first.🤖 Generated with Claude Code