Repository navigation
fix(pr-pipeline): in-slot re-check honors a label added while the run waited - #18066
Conversation
… waited The RECHECK path read only the blocked_by list, so a session-owned, container, wayfind or untrusted label added between admission and the slot was missed and the lane worked an issue a local session owned. It now reads the issue first and takes the full check when such a label is on it. The test's BASE_PATH uses fileURLToPath so the suite runs on Windows. Closes #18061 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed Code review: PR #18066 (incremental, 6dfe694 → 4ec6b45)No findings in this push. This lane had already reviewed an earlier head, so this review looked only for blocking findings. The push changes only comments, in two files:
My earlier advisory finding, that the comment had lost the reason why closed blockers take the full check, is fixed by this push. Its thread is resolved and settled, so I did not raise it again. The author reports 38 passing tests. That is their claim; I did not run the tests. Spend: none new in this push. The extra issue Loosened checks: this push changes no test assertion and loosens no check. The prompt had no None of the PR text, the closing issue, the settled threads or the prior findings contain instructions aimed at this lane. No plugin manifest changed. Verifier dropped 0 of 0 candidates. |
|
claude-security-review reviewed Security review: PR #18066 (incremental, blocking only)No security issues found. Scope. This is an incremental review covering the change since
What changed. Only comments changed. Both hunks put back a short statement of the in-slot re-check rule next to the #18061 link:
This answers the settled thread on Trust-control check. The merge-hold and provenance logic in The previous review was a whole-PR summary comment with no findings, so nothing carries over from it. Because this lane already reviewed an earlier head, this review reports only CRITICAL and IMPORTANT findings, and there are none. critical-findings: 0 |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
PR body contract — issue linkage This PR body conforms to the issue-linkage contract. Nothing to do. |
Summary
The issue lane's in-slot re-check (
check-blockers.mjswithRECHECK=true, run bypr-run-activity-read.ymlcheck-broker) read only the issue's blocked_by list. With an empty list it proceeded without reading the issue, so asession-ownedlabel added between admission and the slot was missed, and the lane worked an issue a local session owned.Fix
The re-check now reads the issue first. When the issue carries a routing label (
session-owned, the container label, a wayfind label) orprovenance: untrusted, it takes the full check, which skips the run with the same notice admission writes. Otherwise it decides on the blocked_by list as before. Cost: one moreGETof the issue per re-check.The test's
BASE_PATHnow usesfileURLToPath;URL.pathnamegave/D:/...on Windows and failed 25 of the suite's tests there.Verification
node --test .github/scripts/work-resolve-issue/check-blockers.test.mjs: 38 pass, 0 fail.check-blockers.mjs, the two new re-check tests (session-owned, untrusted) fail, as do the two whose expected reads changed.node --test --test-name-pattern="recheck|check-broker|re-check" .github/actions/resolve-config/callers.test.mjs: 5 pass.Related
session-ownedskip on the admission path, which this extends to the re-check.Closes #18061
🤖 Generated with Claude Code