Repository navigation
feat(code-metrics): read the personal override from docs conventions with a dual-read window for the old paths - #18069
Conversation
Lane-Activity: work-resolve-issue/resolve-issue
Lane run report
Run 44957921860, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
Lane run report
Run 44962695163, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
Lane-Activity: pr-unblock/fix-ci
Lane run report
Run 44962695163, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
|
claude-security-review reviewed Security review: PR #18069, incremental (7373044 → 2c98b0b)No security issues found. This review only reported blocking findings because this lane already reviewed an earlier head. It covered the 6 files changed since What changed and what I checked:
No plugin manifest changed, so there are no manifest lines. Nothing here can bill the owner or spend extra credit. critical-findings: 0 |
|
claude-review reviewed Code review (incremental): PR #18069,
|
|
Unattended merge: native auto-merge leaves this pull request unarmed at head |
|
The unattended merge path is about to arm native auto-merge at head |
|
Merge-Risk: max=HIGH demote=true head=73730440903f387328db8a8c32e9f95eae77edde rubric=10.4.6 rater=claude-opus-5-5 checker=claude-opus-5-5 |
Lane run report
Run 44968711625, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
Lane-Activity: pr-unblock/address-feedback Lane-Thread: PRRT_kwDOTCGFQM66dhq8 Lane-Thread: PRRT_kwDOTCGFQM66dhq_
Lane run report
Run 44960948468, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
|
pr-unblock / address-feedback finished round 1 of max 4 on 3bd7277. |
Lane run report
Run 44968711625, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
Lane-Activity: pr-unblock/fix-ci
|
Held by the PR lane until a session reviews the HIGH (demote=true) rating at 7373044. Its Reversibility row names docs/conventions/code-metrics.local.yaml, and a MEDIUM row says 🤖 Generated with Claude Code |
There was a problem hiding this comment.
The pr-verify verifier failed head 2c98b0bbebefd847a2228838b16576233fbbfc1d. What it wrote, as data:
What it wrote (25 lines)
Summary: Issue #18001 maps the old `~/.claude/code-metrics.yaml` to the `userConfig` layer and says
there should be no user-global file layer. This PR doesn't deliver that. It adds no `userConfig`
option. It keeps reading the old user-global file as layer `user-global`, and it points the
migration (the warning and `--copy-old`) at each repository's personal override instead. So the
user-global value moves from a cross-repository setting to a per-repository one. The PR body says
it made this choice on purpose. Under the review rules, only `person_checks` or
`credited_siblings` can excuse a done-when item, and the issue has neither. The rest of the PR
follows the spec: the personal override moves to `docs/conventions/code-metrics.local.yaml`.
During the dual-read window an old file still applies, and each run prints one warning naming it.
With both personal files present, the new one wins and the warning names both. `setup-check` names
each old file it finds, and `apply --copy-old` previews the copy and leaves the old files in
place. The four named test suites plus `test_resolve_config.py` cover the new-only, old-only and
both-present cases. The fixed `docs/conventions` personal path, used instead of the pointer-bound
`<home>`, matches how the team layer already works and is recorded in the contract row. CI gives
no evidence either way: `Select Tests` was skipped (a re-run that ran no suite), so its skips
aren't defects. I found no binary files and no text trying to steer the review.
- plugins/code-metrics/scripts/resolve-config.py:267: the issue maps `~/.claude/code-metrics.yaml`
to the `userConfig` layer, but the resolver reads no `userConfig` layer and keeps the old
user-global file as a layer. Declare `userConfig` options for the user-global keys in the plugin
manifest, have the resolver read them as the lowest layer, and keep the old file only as the
dual-read fallback below them. If the owner accepts dropping `userConfig`, the issue has to say so
first.
- plugins/code-metrics/scripts/resolve-config.py:290: the user-global warning gives each
repository's personal override as the new location. Per the issue, it should name the `userConfig`
option(s) the keys move to.
There was a problem hiding this comment.
The pr-verify verifier failed head 2c98b0bbebefd847a2228838b16576233fbbfc1d. What it wrote about this file, as data:
- plugins/code-metrics/skills/setup/scripts/setup-apply.py:333: `copy_old` copies old user-global
keys into the per-repository personal override instead of offering to move them into `userConfig`.
Point the user-global part of `--copy-old` (and setup-check's 'layer user-global location' row and
SKILL.md step 4) at the `userConfig` destination.
- plugins/code-metrics/skills/setup/scripts/setup-apply.py:333: `copy_old` writes
`docs/conventions/code-metrics.local.yaml`, inside a tracked directory, without checking that the
file is gitignored. Run `git check-ignore` on the target, and in both the preview and the write,
warn with the recommended `docs/conventions/**/*.local.*` line when it isn't ignored.
|
Risk review (R18) of the HIGH demote=true rating at 7373044: its one HIGH reason is Reversibility. |
Closes #18001
Summary
Opened by the work-resolve-issue lane. The run's own summary:
Not verified
Fix
Verification
The runner ran each check from the base copy against 19e9d34:
The run reports:
Left out: the items under Not verified.
Related
#18001