Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
bump: minor
---

### Changed

- `/testing:run-e2e` reads `recording` and `browser_mode` from `<home>/testing/e2e.md` and its personal override `<home>/testing/e2e.local.md`, and the worst-case catalog extension from `<home>/testing/worst-case.md`, `<home>` being the convention home (`docs/conventions` by default). The old `.claude/testing/e2e.md`, `.claude/testing/e2e.local.md`, `~/.claude/testing/e2e.md` and `.claude/testing/worst-case.md` are still read where no `<home>` file supplies that layer, and each run prints one warning per old file naming where to move it ([#18051](https://github.com/melodic-software/claude-code-plugins/issues/18051)).
2 changes: 1 addition & 1 deletion docs/contracts/config-cascade/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -703,7 +703,7 @@ its conformance cell.
| `code-tidying` (`verification`) | team-only | team: `<home>/code-tidying.yaml` (`<home>` from the convention-home pointer line at the default branch, default `docs/conventions`; schema `plugins/code-tidying/schemas/code-tidying.schema.json`) | team only | the team file at the default branch; a skill entry over the plugin value; an invalid value resolves `standard`, no value `light` | per-key | conforms to the [location axis](#location-of-the-team-layer-a-docs-convention-file-or-claudename) ([ADR 0064](../../adr/0064-home-plugin-customization-in-docs-conventions-yaml.md)); no `userConfig` option, no `~/.claude` file and no personal override. `verification_skills.<skill>` beats `verification`. `lib/read-verification.sh` (the plugin's copy) reads the file at `origin/<default>` after a fetch, never the working tree, so a branch cannot lower its own level, and names a working-tree copy that gives another level. An invalid value or a file that does not parse is named and resolves `standard`; no value resolves `light`. Levels owned by [`docs/contracts/verification-level/README.md`](../verification-level/README.md); read by `/code-tidying:batch-simplify`. This row covers `verification` and `verification_skills` |
| `docs-naming` | team-only | team: `docs/conventions/docs-naming.yaml` (ADR 0064; schema `plugins/docs-naming/schemas/docs-naming.schema.json`); `userConfig` option `file_names` (one JSON object of `file_names` keys); personal override `docs/conventions/docs-naming.local.yaml` | all three | later layer; team on named policy-floor keys | per-key | conforms. The old team and personal override files, `.claude/docs-naming.json`, `.claude/docs-naming.local.json` and their retired `docs-hygiene` names, are not read; retirement records `docs-naming-r001` and `docs-naming-r002` are `report-only`, `/docs-naming:setup check` names each old file it finds, and while the YAML is absent the first `/docs-naming:setup apply` write copies the old team file's keys into it. In a dual-read window, while the option is unset or invalid, the old user file `~/.claude/docs-naming.json`, else `~/.claude/docs-hygiene.json`, is read in the option's place; every `resolve` run that finds either file WARNs naming it and the option, and `/docs-naming:setup apply` previews copying its keys into the option, leaving the file in place. Removing that read is a later change; per-key override on `file_names.*`, with a policy-floor class on `tiers`, `generated`, `sweep_exclude`, `sweep_exclude_sites`, and the three `exempt_*` keys: a personal layer may add entries and never remove them, and `generated` is team-layer only. Those keys decide what `/docs-naming:realign-file-names` does to a tree (which files are frozen, which reference forms are rewritten, and which shell command runs after a move), so narrowing one from a single machine would weaken a team decision, while adding a scope root or an exemption weakens nothing and stays open. `rule`, `regex`, and `redirect_map` are nearest-wins. Keys owned by [`plugins/docs-naming/reference/config.md`](../../../plugins/docs-naming/reference/config.md), which also documents the `file_names` option (a key inside it that is not a `file_names` key is inert). Written by `/docs-naming:setup apply`, resolved by `plugins/docs-naming/scripts/resolve-config.sh` |
| `rendered-views` | no-floor | team `docs/conventions/rendered-views.yaml`, personal override `docs/conventions/rendered-views.local.yaml`, and each view-lane plugin's `medium` `userConfig` option; the retired `~/.claude/rendered-views.md` and `.claude/rendered-views*.md` give a notice, never a value | `userConfig`, team and personal override | the publish trust walk, not plain precedence: the argument decides alone; a `terminal` or `file` value from any layer keeps the view local; a publishing value counts only from the untracked, gitignored personal override, then `userConfig`; a team file never publishes; with no layer deciding, the lane's own default | per-key | declared deviation from later-layer-wins: `medium` decides whether a view leaves the machine, so a branch-writable layer can keep a view local but never publish it. An invalid value is reported and ignored without dropping another layer's value. Keys owned by [`rendered-views`](../rendered-views/README.md#the-rendered-views-settings). Resolved by `lib/view-settings.mjs`, which reads each layer with `readLayers` |
| `testing` (`run-e2e`) | no-floor | `.claude/testing/e2e.md` for `recording` / `browser_mode`; `docs/conventions/testing.yaml`, `~/.claude/testing.yaml` and `.claude/testing.local.yaml` for `e2e_driver` / `reuse_running_instance` / `browser_driver` and the `map` scope's `map_unit` / `map_entry_points` / `map_report_order` / `file_findings` / `file_findings_floor`, over the plugin's `userConfig` | all three | later layer | per-key | conforms; per-key override, keys owned by `/testing:run-e2e`. The YAML keys are resolved by `resolve-config.sh e2e` and `resolve-config.sh map`, which report the supplying layer and resolve an unknown or refused value to the default without stopping |
| `testing` (`run-e2e`) | no-floor | `<home>/testing/e2e.md` and `<home>/testing/e2e.local.md` for `recording` / `browser_mode`, the old `.claude/testing/e2e.md`, `.claude/testing/e2e.local.md` and `~/.claude/testing/e2e.md` still read with a warning where no `<home>` file supplies the layer; `<home>/testing/worst-case.md` (old `.claude/testing/worst-case.md` the same way) for the worst-case catalog extension; `docs/conventions/testing.yaml`, `~/.claude/testing.yaml` and `.claude/testing.local.yaml` for `e2e_driver` / `reuse_running_instance` / `browser_driver` and the `map` scope's `map_unit` / `map_entry_points` / `map_report_order` / `file_findings` / `file_findings_floor`, over the plugin's `userConfig` | all three | later layer | per-key | conforms; per-key override, keys owned by `/testing:run-e2e`. The YAML keys are resolved by `resolve-config.sh e2e` and `resolve-config.sh map`, which report the supplying layer and resolve an unknown or refused value to the default without stopping |
| `testing` (`write`) | no-floor | `docs/conventions/testing.yaml` and `.claude/testing.local.yaml` for `tdd_refactor_step` (`on` \| `off`, default `on`) and `first_test` (`user-flow` \| `unit`, default `user-flow`); no user-global file, no `userConfig` | team + personal override | later layer | per-key | declared deviation: repository settings, so the user-global layer is skipped with a warning. Keys owned by `/testing:write`; resolved by `resolve-config.sh write`, which reports the supplying layer and resolves an unknown value to the default without stopping |
| `testing` (`audit`, `test-weaken`) | no-floor | team: `docs/conventions/testing.yaml` (schema `plugins/testing/schemas/testing.schema.json`), else the `yaml config` block in `docs/conventions/testing.md` (read for one more release), else `.claude/testing.yaml`; user-global `~/.claude/testing.yaml`; personal override `.claude/testing.local.yaml` | all three | later layer; the first present of `testing.yaml`, the docs block and `.claude/testing.yaml` in the team layer | per-key (scalars override, lists concatenate) | conforms to [ADR 0064](../../adr/0064-home-plugin-customization-in-docs-conventions-yaml.md), except the declared stop on an unusable layer, which replaces rule 5's soft degrade and its inert unknown keys (see Declared): one warning names each shadowed team file. Keys and layer merge owned by `plugins/testing/scripts/resolve-config.sh`; written by `/testing:setup apply`, read by `/testing:audit` and the `test-weaken` hook, which skip the `run-e2e` and `write` keys the same file carries |
| `testing` (`check-visual-parity`) | lowest-value | team: `docs/conventions/testing.yaml` read from origin's default branch (the working tree only when the repository has no `origin`); user-global `~/.claude/testing.yaml`; personal override `.claude/testing.local.yaml`; per user: the plugin's `pixel_tolerance` `userConfig` option | all three, plus the user option | lowest value (policy floor) | per-key | declared deviation from [ADR 0064](../../adr/0064-home-plugin-customization-in-docs-conventions-yaml.md) Decision 5's floor wording, as the `implementation` row: the `pixel_tolerance` map keeps a tighten-only `userConfig` option. The team value, else the default 0, is the ceiling; a personal layer or the option can only lower it, and a raise is reported as ignored. An invalid layer is named with its file or option, key and value and dropped (Decision 7). Resolved by `visual-compare.sh config` in `/testing:check-visual-parity`, which reports the supplying layer; the test scan skips the map and `/testing:setup apply` keeps it |
Expand Down
15 changes: 9 additions & 6 deletions plugins/testing/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,12 @@ installed and enabled, and otherwise reports
`judge pass not run: testing plugin not installed or not enabled`. The calibration cases and raters are in `skills/audit/evals/judge-calibration/`.

`/testing:run-e2e` reads these optional keys only when it drives the app itself; a run through `/app-control:drive` takes its tools from the control skill. `recording` (`video | gif | off`, default `off`) and
`browser_mode` (`headed | headless`, default `headless`) live on `.claude/testing/e2e.md`, which
this plugin reads until it migrates; then the file moves where
[config locations](reference/config-locations.md) says.
`browser_mode` (`headed | headless`, default `headless`) live in `<home>/testing/e2e.md`, with a
personal override at `<home>/testing/e2e.local.md`; the worst-case catalog extension is
`<home>/testing/worst-case.md`. `<home>` is your convention home, `docs/conventions` by default.
The old `.claude/testing/` files are still read, with a warning naming where to move each one;
[the run-e2e config page](skills/run-e2e/context/e2e-config.md#convention-home-and-old-paths)
lists them.
`e2e_driver` (`auto | harness | run | playwright | chrome`) and `reuse_running_instance`
(`auto | true | false`), both default `auto`, live in `docs/conventions/testing.yaml`, its personal
layers, or the `userConfig` options below; `scripts/resolve-config.sh e2e` resolves them and names
Expand Down Expand Up @@ -168,10 +171,10 @@ its test scan. Keep the team's scan config where it is (the `docs/conventions/te
`reuse_running_instance` only in `docs/conventions/testing.yaml`, or in a personal layer on a
machine that runs this release.

Its `worst-case` action also reads an optional `.claude/testing/worst-case.md`, after the bundled
Its `worst-case` action also reads an optional `<home>/testing/worst-case.md`, after the bundled
catalog in `run-e2e/context/worst-case.md`: the project's own worst-case values, field limits and
data formats, read as data. It reads that path until the plugin migrates; then the file moves where
[config locations](reference/config-locations.md) says. The action renders a target with that data, reverts what it injected
data formats, read as data. An old `.claude/testing/worst-case.md` is still read when no `<home>`
file exists, with a warning naming where to move it. The action renders a target with that data, reverts what it injected
(proven with `cmp` snapshots), and reports what breaks without editing component code.

`/testing:audit` and the `test-weaken` hook read the testing config through the same cascade
Expand Down
6 changes: 3 additions & 3 deletions plugins/testing/evals/e2e-config-layers-delegated/case.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
schema_version: "1.1"
name: e2e-config-layers-delegated
description: 'Legacy run-e2e 3 (prerequisites-pass-config-resolved-drive-delegated). Merges recording and browser_mode across every layer of .claude/testing/e2e.md with each value''s source, delegates the drive to a subagent with those values, and returns evidence paths only. subagent-and-layers reads the reply; meets-expectations (llm) quotes the legacy expectations. Read-only tools, graded on the reply.'
description: 'Legacy run-e2e 3 (prerequisites-pass-config-resolved-drive-delegated). Merges recording and browser_mode across every layer of the e2e.md surface with each value''s source, delegates the drive to a subagent with those values, and returns evidence paths only. subagent-and-layers reads the reply; meets-expectations (llm) quotes the legacy expectations. Read-only tools, graded on the reply.'
tags: [testing, run-e2e, no-network]
expected_outcome: 'Merges recording and browser_mode across every layer of .claude/testing/e2e.md with each value''s source, delegates the drive to a subagent with those values, and returns evidence paths only.'
expected_outcome: 'Merges recording and browser_mode across every layer of the e2e.md surface with each value''s source, delegates the drive to a subagent with those values, and returns evidence paths only.'
execution:
prompt: '/testing:run-e2e the login flow. Do not read the repository, launch, install or run anything; treat these as facts and each step as already run with the result given. Context, not part of the scenario: the app-control plugin is not installed. When the run suggests installing it, the user answers: "No, I''m good. Just use what you have." Say how the run resolves its settings, who drives the browser, and what comes back, then stop.'
allowed_tools: [Read, Glob, Grep]
Expand All @@ -16,4 +16,4 @@ graders:
target: last_message
- name: meets-expectations
type: llm
criteria: 'The run is /testing:run-e2e on this scenario: /testing:run-e2e the login flow. PASS only if the reply satisfies every legacy expectation: "Reads every layer of .claude/testing/e2e.md and merges recording and browser_mode per key" "Reports which layer supplied each effective value" "Delegates the drive loop to a subagent instead of driving the browser in its own context" "Passes the resolved browser_mode and recording through to the executor" "Returns only evidence paths, not browser session output". FAIL if any point is missing or contradicted.'
criteria: 'The run is /testing:run-e2e on this scenario: /testing:run-e2e the login flow. PASS only if the reply satisfies every legacy expectation: "Reads every layer of the e2e.md surface (the team file and personal override at the convention home, docs/conventions by default, plus any old .claude/testing/ or ~/.claude/testing/ file still read) and merges recording and browser_mode per key" "Reports which layer supplied each effective value" "Delegates the drive loop to a subagent instead of driving the browser in its own context" "Passes the resolved browser_mode and recording through to the executor" "Returns only evidence paths, not browser session output". FAIL if any point is missing or contradicted.'
13 changes: 8 additions & 5 deletions plugins/testing/skills/run-e2e/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -225,9 +225,10 @@ Read [context/own-driving.md](context/own-driving.md) and follow it. Before disp
subagent, check prerequisites, resolve the run config, and, for a `playwright` drive, run the
browser-driver check; a stop there dispatches no subagent. The subagent then takes the bundled `run`
launch step, the Workspace environment, session names, a control skill's Ready and driving tool on
this route, and teardown. The workflow steps live in [context/e2e.md](context/e2e.md). These three
commands carry values only this file expands; the context file says when each runs:
this route, and teardown. The workflow steps live in [context/e2e.md](context/e2e.md). These four
commands carry values only this file expands; the context files say when each runs:

- Convention-home command: `bash "${CLAUDE_PLUGIN_ROOT}/lib/resolve-convention-home.sh" --root "${CLAUDE_PROJECT_DIR}"`
- Resolve command: `bash "${CLAUDE_PLUGIN_ROOT}/scripts/resolve-config.sh" e2e --user 'e2e_driver=${user_config.e2e_driver}' --user 'reuse_running_instance=${user_config.reuse_running_instance}'`
- Browser-driver resolve command: `bash "${CLAUDE_PLUGIN_ROOT}/scripts/resolve-config.sh" e2e --user 'browser_driver=${user_config.browser_driver}'`
- Browser-driver check: `bash "${CLAUDE_PLUGIN_ROOT}/scripts/check-browser-driver.sh" --user 'browser_driver=${user_config.browser_driver}'`
Expand Down Expand Up @@ -353,9 +354,11 @@ zoom, dark and right-to-left environments, and report. Before injecting a file a
it, save `git diff HEAD` and `git status --porcelain --untracked-files=all --ignored` outside the
tree and compare each pair with `cmp`; a difference ends the run degraded. Outside a git checkout,
or with no mockable boundary, nothing is injected and every finding is labeled inferred. The
consumer file `.claude/testing/worst-case.md` extends the catalog and is read as data; this plugin
reads it there until it migrates, then it moves where
[config locations](../../reference/config-locations.md) says. The action
consumer file `<home>/testing/worst-case.md` extends the catalog and is read as data. Before the
dispatch, resolve `<home>` with the convention-home command, pick that file or the old
`.claude/testing/worst-case.md` per
[context/e2e-config.md § Convention home and old paths](context/e2e-config.md#convention-home-and-old-paths),
print any warning it calls for, and pass the chosen path, or none, to the subagent. The action
Comment thread
melodic-automation-lanes[bot] marked this conversation as resolved.
Resolved
edits no component code; fixes go to the user. It always takes own driving and skips Step 1:
`/app-control:drive` injects no data.

Expand Down
Loading
Loading