Repository navigation
fix(scripts): run the comment-lint gate in check-affected.sh - #18081
Conversation
Issue-lane PRs failed CI's comment-lint gate because the lane's only self-check, check-affected.sh --uncommitted, listed it as CI only, and the lane commits through the API with hooks off, so the commit-time hook never ran. check-affected.sh now runs the code-tidying comment-lint hook over <merge-base>..HEAD: a scratch repository holds HEAD at the merge-base and the index at HEAD's tree, so the hook's staged diff is the branch's, with the merge-base's settings files as scripts/check-comment-lint.sh uses in CI. A python3 without pygments is a SKIP. The lane's base copy of the checks now carries code-tidying's git-hooks, lib and scripts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RAoAtV6H7kcRVG5xeX1rtT
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review: PR #18081, head 0d05631 (incremental since 1cfa4ac)No security issues found. This review was blocking only. An earlier head was already reviewed, so this pass reported only CRITICAL and IMPORTANT findings. What changed. The push changes one file, Why it is safe.
Spend. No new spend beyond a few seconds of CI time for the extra test case. That is not a hold. critical-findings: 0 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ebc23fe955
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
claude-review reviewed Code review: incremental pass from
|
Lane run report
Run 44966256250, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
Lane-Activity: pr-unblock/address-feedback Lane-Thread: PRRT_kwDOTCGFQM66d9g0 Lane-Thread: PRRT_kwDOTCGFQM66d92Q
Lane run report
Run 44966256250, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
Test Selection traces a changed suite, and this one reads the base's resolve-config package.json, apply-patch files and the skill-quality plugin, which no test-scope line declared (scripts/affected-tests.sh R8). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RAoAtV6H7kcRVG5xeX1rtT
Lane run report
Run 44966256250, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
Lane-Activity: pr-unblock/address-feedback Lane-Thread: PRRT_kwDOTCGFQM66d92Q
|
pr-unblock / address-feedback finished round 1 of max 4 on 0d05631. |
Lane run report
Run 44966256250, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
|
The pr-verify verifier failed head This pull request leaves the merge queue, and ci-status holds it out while it carries |
Closes #18087
Summary
Issue-lane PRs keep failing CI's Lint Repo
comment-lintgate, for example run 44962011745 atplugins/multi-agent/skills/setup/scripts/setup.sh:21-41. The lane's only self-check isscripts/check-affected.sh --uncommitted(docs/conventions/pr-pipeline.yaml:385), andscripts/check-affected-gates.txtlisted comment-lint as CI only on the grounds that the commit-time git hook runs it. The lane commits through the API, and its check wrappers setcore.hooksPath=/dev/null, so the hook never ran before the push.Fix
scripts/check-affected.shrunsplugins/code-tidying/git-hooks/comment-lint.shover<merge-base>..HEAD. The hook only judges its staged diff (checks_init pre-commit), and--worktreewould see nothing inside the--uncommittedsnapshot. So the check builds a scratch repository with HEAD at the merge-base and the index at HEAD's tree, the same thingscripts/check-comment-lint.shgets fromreset --soft. It checks out nothing except AGENTS.md, CLAUDE.md and thecode-tidying*.yamlsettings, all read from the merge-base as CI reads them, and it writes nothing under the checked repository's.git. Apython3that cannot import pygments is a SKIP, not a failure.scripts/check-affected-gates.txt:comment-lintis now a run gate..github/actions/collect-base-activity/action.yml: the lane's base copy of the checks also carriesplugins/code-tidying/{git-hooks,lib,scripts}, so the hook runs from the base. The lane installs.github/requirements-ci.txt, which pins pygments, throughscripts/setup-env.shfor skill activities, and that venv is on PATH.Verification
scripts/check-affected-comment-lint.test.shruns the real hook against a fixture repository. It covers: the hook is absent (SKIP); pygments is missing (SKIP); a clean change passes; a planted comment fails at its line (the planted line comes from the hook's ownshape2fixture), both committed and under--uncommitted; and the merge-base'scomment_lintlevel wins over one the branch sets. With the hook switched to--worktree, the three failing cases go red. PASS=6.team-conventions). The check must readcomment_lint: blockthere, becausecheck-affected.shnow resolves the pointer with--refat the merge-base, asscripts/check-comment-lint.shdoes. This case has not run locally yet; CI runs it.scripts/check-affected.test.shPASS=155,scripts/check-affected-gates.test.shPASS=6, and the newcollect-base-activity.test.mjsstaging case passes.scripts/check-affected.sh --uncommitted --base origin/mainon this branch: 16 passed, 5 skipped. Before I removed my own comments, the new gate flagged them.Related
🤖 Generated with Claude Code
https://claude.ai/code/session_01RAoAtV6H7kcRVG5xeX1rtT