Repository navigation
feat(instruction-placement): read suppressions from the config-cascade layers - #18085
melodic-automation-lanes[bot] wants to merge 3 commits into
Conversation
Lane-Activity: work-resolve-issue/resolve-issue
Lane run report
Run 44968269419, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
Lane run report
Run 44968663731, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
Lane-Activity: pr-unblock/resolve-conflicts
Lane run report
Run 44968663731, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
|
claude-security-review reviewed Security review: PR #18085, incremental (d5a37e2 → a92c2b0)This review is blocking only: the lane already reviewed an earlier head, so it reports only CRITICAL and IMPORTANT findings. I found no security issues. I read all 10 files in the incremental scope in full in What I checked:
Spend: none billable. Running the two new eval cases in CI uses prepaid model credit. critical-findings: 0 |
| plugins/improvement/README.md melodic-software/claude-code-plugins 1 names this marketplace's own repository (install, issue target or example) | ||
| plugins/improvement/skills/find/context/unattended.md melodic-software/claude-code-plugins 1 raw link to this marketplace's own published doc | ||
| plugins/instruction-placement/git-hooks/entries.json melodic-software/claude-code-plugins 1 shipped default lefthook remote; install.mjs uses the installed marketplace's git URL when it has one | ||
| plugins/instruction-placement/schemas/instruction-placement.schema.json melodic-software/claude-code-plugins 1 schema $id or $ref naming this marketplace's published schema |
There was a problem hiding this comment.
Fail a change that loosens a check (kind 4: an allowlist entry was added).
- Before:
check-org-repo-tokens.shrejected any file not on the allowlist that namesmelodic-software/claude-code-plugins. - After: it accepts that token in
plugins/instruction-placement/schemas/instruction-placement.schema.json.
Issue #18012 is the only spec that counts here. It never mentions this allowlist entry or gives a reason for it. The PR body's explanation ("the same row other plugin schemas have") does not count as a reason, because only the issue text can give one.
To clear this, either have the issue name this entry and say why, or remove the entry together with the schema $id that needs it.
claude-lane: claude-review
There was a problem hiding this comment.
pr-unblock / address-feedback: UNCERTAIN, left open
Evidence: scripts/org-repo-tokens-allow.tsv:71, plugins/instruction-placement/schemas/instruction-placement.schema.json:3
The row at line 71 is a counted exception (count 1) for the schema's $id at instruction-placement.schema.json:3, which names this marketplace's published schema URL. It has the same reason text as the other plugin schema rows in this file (for example lines 5, 7, 9 and 13), and the file's header asks for a reason on each row, which this row has. So the entry is narrow and follows the file's convention. The finding is a different question: whether issue 18012 has to authorize the entry, since the review only counts issue text as a reason. This lane cannot settle that. A person has to choose: amend the issue to name the schema and its $id row, or accept the entry as the standard schema exception. Removing the row would also mean dropping the schema $id, which the other plugin schemas all carry, so this lane made no edit.
|
claude-review reviewed Code review: PR #18085, changes since
|
Lane run report
Run 44969694312, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
Lane-Activity: pr-unblock/address-feedback Lane-Thread: PRRT_kwDOTCGFQM66eaQg Lane-Thread: PRRT_kwDOTCGFQM66eaQj Lane-Thread: PRRT_kwDOTCGFQM66eaQn
Lane run report
Run 44969694312, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
|
pr-unblock / address-feedback finished round 1 of max 4 on a92c2b0. |
Lane run report
Run 44969694312, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
|
Unattended merge: native auto-merge leaves this pull request unarmed at head |
|
The pr-unblock lane stopped on this pull request and needs a person: an adjudicator found that a disputed review finding turns on what the change is meant to do, which a person decides. Reason:
To resume, deal with the reason above, remove the gh workflow run pr-unblock.yml -R melodic-software/claude-code-plugins -f pr-number=18085 -f activity=address-feedback |
Lane run report
Run 44969694312, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
Closes #18012
Summary
Opened by the work-resolve-issue lane. The run's own summary:
Not verified
Fix
Verification
The runner ran each check from the base copy against 7747063:
The run reports:
The review-feedback round after that run added the <home> definitions and the two evals, su-migrate-config-preview-before-write and au-suppression-file-not-a-candidate. That round ran no check, so the eval matcher samples and skill checks for those files are checked by CI on the new head.
Left out: the items under Not verified.
Related
#18012