Repository navigation
fix(pr-verify): trust intake-triage-briefed issues the owner has not vetoed - #18089
kyle-sexton wants to merge 3 commits into
Conversation
…vetoed Claim commit: the changelog fragment for the owner's standing rule at https://github.com/melodic-software/architecture/blob/main/docs/owner-decisions.md?plain=1#L318. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RAoAtViDMW2P121uLvSb35
…vetoed pr-verify (admit.mjs briefedIssue, called from resolve-pr.mjs linkedIssues) and the merge gate (babysit_verify_evidence.py briefed_issue) take the body of a lanes App filing as spec when the lanes App's newest admission record names its current title and body by sha256 and the issue carries no hold label, no provenance: untrusted and no hold: body line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RAoAtViDMW2P121uLvSb35
…eads The test-selection trace found the suite reading docs/upstream pages (upstreamPages' default directory) that the selector did not map to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RAoAtViDMW2P121uLvSb35
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8449d48ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "query($o:String!,$r:String!,$n:Int!){repository(owner:$o,name:$r){" | ||
| "issue(number:$n){title body author{...actor} " | ||
| "labels(first:100){totalCount nodes{name}} " | ||
| "comments(last:100){nodes{createdAt lastEditedAt body author{...actor}}}}}}" |
There was a problem hiding this comment.
Paginate comments when locating the newest admission record
If an issue accumulates 100 comments after its latest admission record, this query excludes that record and _briefed returns false even though the issue's title, body, and holds have not changed. Unlike this query, resolve-pr.mjs reads the complete comment history, so pr-verify can approve the spec while the merge gate rejects the same issue as verify:untrusted-spec. Using the trust-test fixture, an admission record followed by 100 ordinary App comments returns true with the whole history and false with this query's last-100 slice. Read earlier pages until the newest admission record is found rather than treating its absence from this slice as no admission.
Useful? React with 👍 / 👎.
|
claude-security-review reviewed Security review: PR #18089 (head f8449d4)No security issues found. I read all 9 changed files in full. Three are on trusted paths: What changedpr-verify and the babysit merge gate now accept an issue the lanes App filed as trusted spec when all of these hold:
This removes the untrusted-spec stop for that kind of issue. That stop is a security control and not one of the owner's friction holds, so I judged it like any other merge hold. What I checked
Embedded text: none. The PR context contains no instruction to the review lane. No spend change: the gate makes one extra GraphQL read per linked issue it checks. critical-findings: 0 |
|
claude-review reviewed Code review: PR #18089, trust intake-briefed lanes App filings as specNo blocking or advisory findings. I read all 9 changed files in full in the diff. I compared the new JS rule,
In Small parity edges I checked and didn't count as findings, because realistic data won't hit them and none adds trust on its own:
Closing issue: none. The PR says "No related issue" and cites the owner's standing rule, so there are no acceptance criteria to check. Path-scoped rules: Loosened checks: The change widens what pr-verify and the merge gate accept as trusted spec. I classed that as a bot-author/trust hold (a friction hold: no finding under the criterion) and a security control, which the security lane ( Scope: I left security findings to the separate security lane, as REVIEW.md splits the work. This was a full review, not blocking-only: there are no earlier heads and no prior findings. Spend: the gate's Verifier dropped 0 of 0 candidates. |
|
The pr-verify verifier failed head What it wrote (27 lines)This pull request leaves the merge queue, and ci-status holds it out while it carries |
No related issue: implements the owner's standing rule at https://github.com/melodic-software/architecture/blob/main/docs/owner-decisions.md?plain=1#L318
Summary
pr-verify gave a bot-filed issue no spec text, so a pull request for it failed with
verify:untrusted-spec(#16032 and #18063 did). The owner chose a standing rule (owner-decisions L318, owner, verbatim: "Standing rule (Recommended)"): an issue intake-triage has briefed, and that the owner has not vetoed, counts as trusted spec, with no case-by-case confirmation.Fix
Definitions, both agent-made from what the code already treats as admission and as a stop:
<!-- issue-admission-record -->comment admission writes when it admits an issue (.github/scripts/intake-triage/admit.mjs:2880). It counts only when the lanes App's account id posted it (never its login), its text is canonical, and it was never edited (.github/scripts/lib/admission-record.mjs:30,:62,:109). Any edit to the title or body after the record breaks the hash, so the brief no longer counts.needs-human,needs-owner-decision,needs-reporter-infoorneeds-spec,.github/actions/resolve-config/read-status.mjs:21) orprovenance: untrusted(.github/scripts/pr-merge/merge-holds.mjs:1701), or its body has a line opening with the word hold and a colon (admit.mjs:253BODY_HOLD). A label list that cannot be read whole also counts as vetoed. The check does not ask who set a hold. Any hold keeps the body out of the spec, which is the stricter reading for a widening of trust.Where it is enforced:
admit.mjsbriefedIssue(:2032) is the one rule, besideownAgentTextandrefinementSpec, and carries the one code comment that links the owner's row.resolve-pr.mjslinkedIssuescalls it (:1119) for an issue no listed human wrote that is not a split child or an own-agent filing. The issue's body then reaches the verifier as spec. Its comments still count only when a listed human wrote them. The issue query now reads the labels'totalCount.babysit_verify_evidence.pybriefed_issue(:1089, withadmission_recordat:1037) is its twin, asown_agent_textis forownAgentText._trusted_speccalls it last (:3696) through_briefed, which reads the issue live once per Reader (BRIEFED_ISSUE_QUERY: title, body, author, labels, newest 100 comments). If only pr-verify had changed, a pass would still readverify:untrusted-specat the gate, which needs a person.docs/conventions/pr-pipeline/README.mdstates the rule beside the own-agent paragraph. Fragments: pr-pipeline (minor), source-control (minor).Agent-made design choices:
<!-- intake-triage refinement -->comment was not chosen, because a refinement that asks questions is not a brief. The<!-- claude-lane intake-triage -->verdict was not chosen either: github-actions[bot] posts it, and any workflow can act as that account.hold:line, whoever set it. A hold set only in the Work status field is not read by this check. It still stops a lane merge throughissue_hold_refusal(babysit_merge_policy.py:5425,:5965). A Work-status-only hold on a non-lane pull request blocks neither pr-verify nor this gate.source:label. Delete toolchain's bundled ecosystem defaults - part 2 of 3 #16032's newest record (2026-11-21T20:25:53Z) predates the owner's body edit (21:22:57Z), so its hash is expected not to match (not computed). Rows L316 and L317 already cover both.write-issue.mjsalready passes a lanes App filing's body to the issue lane as written; it is the lane's input, not a spec-trust decision.trustedSpecTexts(admission's own read) is unchanged, so admission does not trust its own record.Verification
node --test --test-concurrency=4 .github/scripts/pr-verify/resolve-pr.test.mjs: 195 pass, 0 fail. The new test covers 13 cases:needs-human, orNeeds-Owner-Decisionin another case);provenance: untrusted;hold:body line;node --test --test-concurrency=4 .github/scripts/intake-triage/admit.test.mjs: 752 pass, 0 fail.python3 -m unittestovertest_babysit_*_trust.py: 87 tests OK. The new classes cover:briefedIssueagainstbriefed_issueon eight issues, which agree.test_babysit_split_child_trust.py's fake now answers the new query._trusted_spec(verify_evidence, capped_close, verify_index, guards, merge_policy and others): OK, except 29 failures intest_babysit_mergeandtest_babysit_merge_unattendedand failures in the two review-evidence suites. The same 29 fail on main's checkout without this change.scripts/run-ruff.sh checkpasses on the three Python files.scripts/check-affected.sh: 19 passed, 1 skipped.scripts/selection-audit.sh trace --strictover the three changed suites found thatresolve-pr.test.mjsreadsdocs/upstreampages (upstreamPages' default directory) without selecting them (58 gaps). The suite now declares// test-scope: docs/upstream/*, and the trace atf8449d48bareports no gap.Related
babysit_verify_evidence.py(_spec_amended); the hunks do not overlap.🤖 Generated with Claude Code