Repository navigation
fix(prototype): keep a notes-row click when the list re-renders mid-press - #18091
Conversation
…ress render() rebuilt every notes row with replaceChildren on each server state push and each named or view reply from the frame. One landing between a row's mousedown and mouseup left the browser no click to fire, so choose() never ran, the row's actions stayed display:none, and the next click on Edit, Withdraw or Move or resize waited 30 s. That is the click timeout the explore-directions browser suites hit on CI. A render during a press in the list now waits until the click has been dispatched. notes-history-browser asserts a row click survives a render forced mid-press; it fails on the old host. Closes #18090 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RAoAtV6H7kcRVG5xeX1rtT
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9966eb090
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
claude-security-review reviewed Security review: PR #18091 (incremental since b9966eb, blocking only)I found no security issues in this push. I read all 3 files in the incremental scope in full:
None of the incremental files matches a trusted-path glob. The push touches no trust control, merge hold, plugin manifest or instruction surface. The PR context contains no embedded instructions. This review was blocking only, because this lane already reviewed an earlier head. critical-findings: 0 |
|
claude-review reviewed Code review: PR #18091 (incremental, b9966eb..88d6330)No blocking findings in this push. This push fixes this lane's earlier finding, which said a right-button press could leave
I checked how the new listeners behave alongside the existing ones:
The two copies of the code match line for line. The changelog fragment now describes the narrower hold and still uses Both settled threads on Closing issue #18090: this push does not change how the criteria were judged at the earlier head. Criterion 1 (a press survives a mid-press re-render) still holds for a primary-button press, and the earlier assertion covers it. The claims for criteria 2 and 3 come from the author; I did not verify them. Loosened checks would be marked: fail (default). The prompt has no No plugin manifest changed. I found no embedded instructions in the PR context, the settled threads or the prior findings. This review was blocking only: this lane already reviewed an earlier head. Verifier dropped 0 of 0 candidates. |
Lane run report
Run 44974490819, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
Lane run report
Run 44974490819, attempt 1
Failed GitHub API callsNo failed call recorded by the run job's scripts. |
…menu, leave and blur Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RAoAtV6H7kcRVG5xeX1rtT
Closes #18090
Summary
The explore-directions browser suites flaked on
mainwith a Playwright click timing out at 30 s (notes-edit-browserin run 44955798864 attempt 1,notes-region-browserin run 44968944394). The cause is in the notes host page that every suite loads, not in the tests.render()inlib/ui-feedback/host.mjsrebuilds every notes row withreplaceChildrenon each server-sentstatepush (the stream polls every 0.3 s) and on eachnamedorviewreply from the frame. When a render lands between a row's mousedown and mouseup, the browser fires no click on the row,choose()never runs, and the row's actions staydisplay: none(host.html,.note:not([aria-current="true"]) .acts). The next click on Edit, Withdraw or Move or resize then waits 30 s for a button that never shows. A user hits the same lost click.Fix
lib/ui-feedback/host.mjs: a render requested while a pointer is pressed in the notes list waits until the click is dispatched, then runs once. A window-levelclicklistener runs it after the row's handlers.pointerup(on the next task) andpointercancelrun it when no click follows.plugins/prototype/notes-bridge/host.mjsis regenerated byscripts/sync-shared-copies.sh.notes-history-browser-take.js: a new assertion presses on a row, makes the frame postnamed(which re-renders the list), releases, and checks that the row is selected and its Edit action shows..changes/prototype/patch fragment.No test waits or timeouts were changed.
notes-copyout-browserin PR run 44953095719 failed on a different symptom: its status line was still empty after a 2 s poll for the clipboard write, and there was no click timeout. It passed every local load run below, so it is left unchanged.Verification
notes-history-browserassertion fails on the old host and passes on the fixed one.notes-edit,notes-regionandnotes-copyout, 6 copies of each in parallel per round (72 runs per batch):notes-edit, a 5 swaitForSelector, not a click timeout), wall time 69 s; after 0/72, 66 s.The CI-shaped 30 s click timeout did not reproduce under local contention, so the before/after claim rests on the forced-render probe.
plugins/prototype/skills/explore-directions/scripts/*-browser.test.shsuites pass on the fixed host. A first version that deferred the flush to a timer failednotes-panel-browser("Delete removes the draft"), because the list was read before the timer ran. Flushing on the click itself fixed that.scripts/sync-shared-copies.sh --check: all 1035 copies match.Related
🤖 Generated with Claude Code
https://claude.ai/code/session_01RAoAtV6H7kcRVG5xeX1rtT