Skip to content

ci: run the offline lychee link check - #123

Merged
kyle-sexton merged 1 commit into
mainfrom
lychee-offline-lane
Oct 11, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
lychee-offline-lane

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: part of the org-wide lychee rollout that makes a broken local link or anchor block merge.

Summary

Adds an Offline links job to pr-require-checks.yml and feeds it into ci-status, the context the org ci-gate ruleset requires on the default branch.

Fix

  • New lychee job runs the pinned melodic-software/ci-workflows lychee-offline composite (v0.39.8) against the synced lychee.toml, offline, over **/*.md.
  • ci-status now needs the job; its aggregation passes needs.*.result with treat-skipped-as: fail, so a red or skipped lychee job fails ci-status.
  • docs/cursor-cloud-environment.md now says the workflow also runs the offline lychee check.

Verification

  • Local: lychee 0.24.2 --offline --config lychee.toml '**/*.md' reports 0 errors.
  • CI: the Offline links job on this PR runs on Linux, which also catches case-sensitive path mismatches.

Related

  • Shared ruleset: lychee.toml, synced from melodic-software/standards (not edited here).

🤖 Generated with Claude Code

Add an `Offline links` lane that runs the pinned ci-workflows
lychee-offline composite against the synced lychee.toml, and feed it
into ci-status so a broken local link or anchor fails the gate.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review October 11, 2026 14:37
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T14:41:04.987376Z c115d22 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@claude

claude Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 1m 6s —— View job


Security review (/review:security-review)

  • Gather context (diff against origin/main, full pr-require-checks.yml)
  • Apply skip-gate / instruction-surface checks
  • Review for security issues
  • Report result

Scope: .github/workflows/pr-require-checks.yml (+16/-1), docs/cursor-cloud-environment.md (+3/-2).

Findings: none.

Notes from the review:

  • The new lychee job runs on the pull_request trigger (not pull_request_target/workflow_run) with the workflow's existing permissions: contents: read, no secrets passed to the action, and persist-credentials: false on checkout — the safe trigger/permission combination for running an external composite action against untrusted fork content. Dangerous-trigger/permission-widening/unpinned-action concerns are zizmor's advisory lane and are deliberately not re-litigated here.
  • The composite action is pinned by full commit SHA (melodic-software/ci-workflows/...@594987a... # v0.39.8), consistent with the rest of the file.
  • The check runs lychee in offline mode, which removes the live-URL-fetch/SSRF surface a link checker would otherwise expose to attacker-controlled link text in a fork PR.
  • lychee's if: guard mirrors validate-marketplace's existing contract-only predicate exactly, and ci-status now needs: [validate-marketplace, lychee] with treat-skipped-as: fail already in place — so a skipped/red lychee job fails the gate the same way a skipped validate-marketplace already does. No bypass path introduced for contract-only (labeled/unlabeled/non-base edited) events; that carry-forward behavior is the pre-existing, documented mechanism in the file header, unchanged by this diff.
  • docs/cursor-cloud-environment.md is a prose description of the gate, not an enforcing instruction file (AGENTS.md/CLAUDE.md/rules/skill/hook) — its edit only documents the new job and doesn't remove or soften any guardrail. Instruction-surface deletion check: not applicable, nothing removed.

No logic flaws, authorization/access-control gaps, injection surfaces, or unsafe secret/token handling identified in this diff.

@claude

claude Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 2m 2s —— View job


Claude is working on this review

  • Gather context (PR diff, docs preflight)
  • Review .github/workflows/pr-require-checks.yml and docs/cursor-cloud-environment.md
  • Verify composite-action defaults / ci-gate ruleset claims
  • Post findings as inline comments
  • Summarize in this comment

@github-actions

Copy link
Copy Markdown

claude-security-review has reviewed this pull request through c115d22; a later push is reviewed from there.

@github-actions

Copy link
Copy Markdown

claude-review has reviewed this pull request through c115d22; a later push is reviewed from there.

@kyle-sexton
kyle-sexton merged commit 8d2a620 into main Oct 11, 2026
10 checks passed
@kyle-sexton
kyle-sexton deleted the lychee-offline-lane branch October 11, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant