Skip to content

fix: keep the local gitleaks scan in the cross-cutting record - #184

Merged
kyle-sexton merged 1 commit into
mainfrom
fix/ecosystem-records-restore-gitleaks
Nov 14, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
fix/ecosystem-records-restore-gitleaks

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Refs: melodic-software/claude-code-plugins#15727

Summary

Puts the local gitleaks secret scan back into .claude/ecosystems/cross-cutting.yaml. The record merged in #183 set no gitleaks command because no CI job here runs one, and that switched off the scan the bundled toolchain default ran for this repository. The owner had not approved removing a secret scan.

Fix

  • check-cmd now runs lychee and then gitleaks dir . --config .gitleaks.toml --no-banner --redact; each contributes to the status and any failure fails the command.
  • The notes state the line as a deviation from CI: no CI job here runs gitleaks. The command, version (8.30.1) and checksum are those of the gitleaks composite at melodic-software/ci-workflows v0.39.8, which this repository does not call.
  • opt-in, install-hint and tool-pin name gitleaks.
  • One cite into pr-automerge-dependabot.yml moved by a line when the job display names changed; it is corrected.
  • tests/codex-operations.test.mjs: the made-up token on line 206 gets an inline gitleaks:allow comment, the mechanism .gitleaks.toml names for an intentional finding. Without it the scan reports one finding on a clean tree.

Verification

  • The record validates against the ecosystem-commands schema.
  • gitleaks dir 8.30.1 over this branch's tree: no leaks found. Before the test-file comment it reported 1 (rule generic-api-key, the fixture line).
  • node --test tests/codex-operations.test.mjs: 22 passed, 0 failed.
  • An independent review read every cite the change adds or moves, compared the record key by key with the version on main, and ran the command shape with stub tools: exit 0 when clean, exit 1 when gitleaks finds something, errors or is missing. READY, no blocking finding.
  • A probe on the build host showed gitleaks dir also reads untracked and git-ignored files, as the notes say.

Remaining

Issue melodic-software/claude-code-plugins#15727 stays open after this pull request; its baseline steps and recorded /toolchain:check all output are still owed.

Whether a record should keep other bundled checks that CI does not run (typos, for example) is an open owner question; this pull request changes only the secret scan.

Related

session: GitHub Support

🤖 Generated with Claude Code

The cross-cutting record set no gitleaks command because no CI job here
runs one, which switched off the secret scan the bundled toolchain
default ran for this repository. Add the scan back as a stated deviation
from CI, with the command, version and checksum of the gitleaks composite
at ci-workflows v0.39.8, and correct one line cite that moved when the
job display names changed.

Mark the made-up token in tests/codex-operations.test.mjs with an inline
gitleaks:allow comment so the scan passes on a clean tree.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T15:34:10.403887Z ead4c19 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed ead4c1939d54e8941d8c686edcb013dd76c70414: 0 finding(s), 0 as inline comments.

Security review: no findings

critical-findings: 0

I read the full diff (2 files) and found no security issues.

  • .claude/ecosystems/cross-cutting.yaml
    • check-cmd now runs lychee and then a local gitleaks dir . --config .gitleaks.toml --no-banner --redact.
    • It records failure from either tool and exits non-zero if either failed, so neither failure is masked.
    • The change strengthens a control rather than weakening one. It keeps the secret scan the bundled default already ran, and --redact keeps any matched secret out of the output.
    • The commands are fixed strings with no interpolated input. The new tool-pin and checksum entries are metadata for a local lint-only command.
    • The diff touches no workflow, token, trust control, plugin manifest or hold path. It deletes no standing instruction. The prose in notes only documents that CI does not run gitleaks.
  • tests/codex-operations.test.mjs
    • A // gitleaks:allow marker is added to rawGithubToken.
    • The value is a fabricated placeholder (ghp_0123456789abcdefghijABCDEFGHIJ, only 30 characters, so not a real GitHub token). It is a fixture for redaction tests, not a credential.
    • The inline allow is scoped to that one line, so it does not suppress scanning elsewhere.

No manifest, userConfig or trust-control changes are present, so there are no manifest <field> lines.

@github-actions

Copy link
Copy Markdown

claude-review reviewed ead4c1939d54e8941d8c686edcb013dd76c70414: 0 finding(s), 0 as inline comments.

No findings. I read the full diff, the PR context and the one rule file, .claude/rules/pr-body-contract.md, which governs the PR body and title and not the changed files. No closing issue applies: the PR uses Refs:, so there are no acceptance criteria to check. Settled-thread and prior-findings files were not supplied.

  • check-cmd shape: The block runs lychee and then gitleaks, records a failure from either in rc, and ends with test "$rc" -eq 0. A failure or missing tool in either command therefore fails the whole command, as the header comment says. I did not run it; the PR's stub-tool run is author-claimed and unverified by me.
  • Moved cite: pr-automerge-dependabot.yml:22-29 is correct at head. Line 22 is the job key and line 29 is the last with: entry.
  • gitleaks allow comment: .gitleaks.toml names an inline gitleaks:allow comment as the mechanism for an intentional finding, and tests/codex-operations.test.mjs:206 now uses it. The comment does not change the fixture's value, so the collector tests' redaction inputs are unaffected.
  • Version and checksum pins: I did not verify the gitleaks 8.30.1 version and the checksum against the ci-workflows composite. Those come from the PR description and the record's notes, and a wrong value would only affect an install hint.
  • Manifests: No plugin manifest changed, so no manifest <field> lines apply.

Pre-existing (advisory): none.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton merged commit 49ff058 into main Nov 14, 2026
8 checks passed
kyle-sexton added a commit that referenced this pull request Nov 16, 2026
…200)

Refs: melodic-software/claude-code-plugins#15727

## Summary

Refreshes two stale citations in the notes of
`.claude/ecosystems/cross-cutting.yaml`. No command, glob or pin key
changes.

## Fix

- The notes named check-managed-files at `8e1076f` (v0.71.0).
#195 moved that pin to `944d346`
(v0.74.0), and #193 lets Dependabot move it again, so the note now names
it as the commit `pr-check-managed-files-hosted.yml:118` pins, the way
the lychee note already does.
- #194 added a header comment line to
`pr-automerge-dependabot.yml`, so its job is now `:22-30` (was cited
`:22-29`) and the sentence describing what it arms is `:3-8` (was
`:3-7`).

## Verification

- All six records validate against the ecosystem-commands schema
(`check-jsonschema`: `ok -- validation done`).
- Every other citation in the six records was read at `8f73ded`: the
`pr-require-checks.yml`, `pr-check-managed-files-hosted.yml` and both
review-workflow lines still hold. The lychee-offline composite at the
pinned `944d346` still defaults to lychee 0.24.2 with the recorded
checksum and arguments; the gitleaks composite there still pins 8.30.1.
- `/toolchain:check all` and `/toolchain:lint` (toolchain 1.4.3) with
these records, over the changed files of `2d92547..8f73ded` (51 files):
- check: `Overall: PASS (1 of 1 ecosystems that ran a command passed:
typescript; powershell: skip (opt-in unmet); bash, markdown, python,
dotnet, go: no command)`; `npm test` 202 of 202, `npm run validate` 0
errors.
- lint: `Overall: PASS (1 of 1 ecosystems that ran a command passed:
cross-cutting; bash, markdown, python, typescript, yaml: no command)`;
lychee 0 errors, gitleaks no leaks.

## Remaining

- melodic-software/claude-code-plugins#15727 closes after this merges,
with the recorded runs and baseline.
- Open question for the owner, not changed here: `typescript.yaml`'s
globs (`*.mjs`, `package.json`) are narrower than CI, whose
`validate-marketplace` job has no path filter. A change to only a
`SKILL.md`, `plugin.json` or `*.py` file runs no local test while CI
runs `npm test`. The notes state this gap. Matching CI would need
`globs: ["**"]`, which would also make code-metrics count every file as
typescript.

## Related

- #183 (the records),
#184 (the gitleaks line)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant