Repository navigation
fix: keep the local gitleaks scan in the cross-cutting record - #184
Conversation
The cross-cutting record set no gitleaks command because no CI job here runs one, which switched off the secret scan the bundled toolchain default ran for this repository. Add the scan back as a stated deviation from CI, with the command, version and checksum of the gitleaks composite at ci-workflows v0.39.8, and correct one line cite that moved when the job display names changed. Mark the made-up token in tests/codex-operations.test.mjs with an inline gitleaks:allow comment so the scan passes on a clean tree. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review: no findings
I read the full diff (2 files) and found no security issues.
No manifest, |
|
claude-review reviewed No findings. I read the full diff, the PR context and the one rule file,
Pre-existing (advisory): none. Verifier dropped 0 of 0 candidates. |
…200) Refs: melodic-software/claude-code-plugins#15727 ## Summary Refreshes two stale citations in the notes of `.claude/ecosystems/cross-cutting.yaml`. No command, glob or pin key changes. ## Fix - The notes named check-managed-files at `8e1076f` (v0.71.0). #195 moved that pin to `944d346` (v0.74.0), and #193 lets Dependabot move it again, so the note now names it as the commit `pr-check-managed-files-hosted.yml:118` pins, the way the lychee note already does. - #194 added a header comment line to `pr-automerge-dependabot.yml`, so its job is now `:22-30` (was cited `:22-29`) and the sentence describing what it arms is `:3-8` (was `:3-7`). ## Verification - All six records validate against the ecosystem-commands schema (`check-jsonschema`: `ok -- validation done`). - Every other citation in the six records was read at `8f73ded`: the `pr-require-checks.yml`, `pr-check-managed-files-hosted.yml` and both review-workflow lines still hold. The lychee-offline composite at the pinned `944d346` still defaults to lychee 0.24.2 with the recorded checksum and arguments; the gitleaks composite there still pins 8.30.1. - `/toolchain:check all` and `/toolchain:lint` (toolchain 1.4.3) with these records, over the changed files of `2d92547..8f73ded` (51 files): - check: `Overall: PASS (1 of 1 ecosystems that ran a command passed: typescript; powershell: skip (opt-in unmet); bash, markdown, python, dotnet, go: no command)`; `npm test` 202 of 202, `npm run validate` 0 errors. - lint: `Overall: PASS (1 of 1 ecosystems that ran a command passed: cross-cutting; bash, markdown, python, typescript, yaml: no command)`; lychee 0 errors, gitleaks no leaks. ## Remaining - melodic-software/claude-code-plugins#15727 closes after this merges, with the recorded runs and baseline. - Open question for the owner, not changed here: `typescript.yaml`'s globs (`*.mjs`, `package.json`) are narrower than CI, whose `validate-marketplace` job has no path filter. A change to only a `SKILL.md`, `plugin.json` or `*.py` file runs no local test while CI runs `npm test`. The notes state this gap. Matching CI would need `globs: ["**"]`, which would also make code-metrics count every file as typescript. ## Related - #183 (the records), #184 (the gitleaks line) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Refs: melodic-software/claude-code-plugins#15727
Summary
Puts the local gitleaks secret scan back into
.claude/ecosystems/cross-cutting.yaml. The record merged in #183 set no gitleaks command because no CI job here runs one, and that switched off the scan the bundled toolchain default ran for this repository. The owner had not approved removing a secret scan.Fix
check-cmdnow runs lychee and thengitleaks dir . --config .gitleaks.toml --no-banner --redact; each contributes to the status and any failure fails the command.opt-in,install-hintandtool-pinname gitleaks.pr-automerge-dependabot.ymlmoved by a line when the job display names changed; it is corrected.tests/codex-operations.test.mjs: the made-up token on line 206 gets an inlinegitleaks:allowcomment, the mechanism.gitleaks.tomlnames for an intentional finding. Without it the scan reports one finding on a clean tree.Verification
gitleaks dir8.30.1 over this branch's tree: no leaks found. Before the test-file comment it reported 1 (rulegeneric-api-key, the fixture line).node --test tests/codex-operations.test.mjs: 22 passed, 0 failed.gitleaks diralso reads untracked and git-ignored files, as the notes say.Remaining
Issue melodic-software/claude-code-plugins#15727 stays open after this pull request; its baseline steps and recorded
/toolchain:check alloutput are still owed.Whether a record should keep other bundled checks that CI does not run (typos, for example) is an open owner question; this pull request changes only the secret scan.
Related
session: GitHub Support
🤖 Generated with Claude Code