Skip to content

ci: run every shared git hook through the aggregate lefthook remote - #207

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/lefthook-aggregate-remote
Nov 18, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/lefthook-aggregate-remote

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: org-wide rollout of the shared git hooks (every repository gets the same hook set from one source).

Summary

Switches this repository's lefthook remote from the guardrails-only config to claude-code-plugins' root lefthook-remote.yml, which extends all 11 hook plugins' remote configs: guardrails, code-tidying, actionlint, bash-format, go-format, instruction-placement, javascript-format, markdown-format, powershell-format, python-format and spelling.

Fix

lefthook.yml: configs: names lefthook-remote.yml. ref: main and refetch_frequency: 24h are unchanged. Formatters act only where this repository has the tool's config; the lint jobs block only on findings in lines a commit adds.

Verification

  • Formatter dry run over the whole tree (throwaway clone, aggregate installed, every tracked file staged, each formatter job alone): no file rewritten, so no cleanup PR is needed.
  • This commit ran the aggregate's pre-commit, commit-msg and pre-push jobs.
  • The same switch landed first in control-hub#15, where all 16 pre-commit jobs ran on a real commit.

Related

🤖 Generated with Claude Code

Name claude-code-plugins' root lefthook-remote.yml, which extends all 11
hook plugins' remote configs, in place of the guardrails-only config.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T10:02:16.800503Z 311fedb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-review reviewed 311fedb91fb7d6e0bc77826458d3ed8550abe193: 0 finding(s), 0 as inline comments.

No findings. The change is one line in lefthook.yml: the remote configs: entry goes from plugins/guardrails/git-hooks/lefthook-remote.yml to the root lefthook-remote.yml. git_url, ref: main and refetch_frequency: 24h are unchanged.

  • I could not check that lefthook-remote.yml exists at the root of the remote repo's main. The PR body cites claude-code-plugins#17025 and control-hub#15 as evidence; that is author-claimed and I did not verify it.
  • The remote tracks ref: main, so the shared hook set changes without a change in this repo. That is existing behaviour and the PR's stated design.
  • The PR body opens with No related issue: <reason>, so there is no closing issue and no acceptance criteria to check.
  • Loosened check: fail verdict with no consumer entries, since the wrapper supplied none. The diff loosens no check.
  • No manifest files changed.
  • No other file in the repo refers to the old config path.
  • Verifier dropped 0 of 0 candidates.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 311fedb91fb7d6e0bc77826458d3ed8550abe193: 0 finding(s), 0 as inline comments.

No security findings in PR #207 at 311fedb.

The diff is a single line in lefthook.yml. It changes the remote config path from plugins/guardrails/git-hooks/lefthook-remote.yml to lefthook-remote.yml.

  • Trust boundary unchanged. The remote is still https://github.com/melodic-software/claude-code-plugins at ref: main. No new repository, actor, token scope or credential is introduced.
  • Unpinned ref is not part of this diff. The remote tracks main with a 24h refetch both before and after. That is existing behavior, not something this change introduced or widened.
  • Not a trust control. lefthook.yml is not in the trusted-path or trust-control lists. The change does not touch the trusted-trigger check, token scope, kill switch, merge holds or other .github/actions/ controls.
  • Not read. I did not read the contents of the new remote config lefthook-remote.yml in the other repository. It is outside this PR's diff, so what it runs is not covered by this review.

critical-findings: 0

@kyle-sexton
kyle-sexton merged commit 3054b38 into main Nov 18, 2026
8 checks passed
@kyle-sexton
kyle-sexton deleted the ci/lefthook-aggregate-remote branch November 18, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant