Skip to content

chore: remove unnecessary comments under ADR 0110 - #218

Merged
kyle-sexton merged 1 commit into
mainfrom
chore/remove-unnecessary-comments
Nov 21, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
chore/remove-unnecessary-comments

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Refs: melodic-software/control-hub#12

Summary

Comment-removal sweep of melodic-software/codex-plugins under ADR 0110 (necessary posture) and REVIEW.md. Code-file count: 43 tracked code files (8 sync-managed from standards including pr-review*-hosted.yml, 6 under .claude/ecosystems/, 11 agents/openai.yaml files with no comments, and 18 locally-owned scripts/tests/workflows/configs reviewed).

Fix

Removed 11 // --- ... --- section-divider banners (21 deleted lines including adjacent blank lines) from plugins/plugin-ops/skills/verify-plugin/scripts/validate-marketplace.test.mjs.

Preserved untouched:

  • All shebangs, # noqa, # type: ignore, // gitleaks:allow, # yaml-language-server, SHA-pin version comments, JSDoc comments, sync-managed files, .github/workflows/pr-review*.yml, .claude/ecosystems/*.yaml, and all Codex runtime/contract/test-invariant comments across plugins/**/scripts/*, tests/*.mjs, .github/dependabot.yml, and .github/workflows/pr-require-checks.yml.

Verification

  • git diff verified strictly section-divider comment deletions (1 file changed, 21 deletions(-)), zero code tokens modified.
  • Full CI test suite and review lanes verified on this PR.

Related

  • Refs: melodic-software/control-hub#12

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T19:58:29.832333Z 49ea734 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 49ea734e2e9c91e4f229187e6eb45b0150c7f87c: 0 finding(s), 0 as inline comments.

Security review of PR #218 at 49ea734: no security findings.

The diff touches one file, plugins/plugin-ops/skills/verify-plugin/scripts/validate-marketplace.test.mjs. It only deletes section-divider comments, with no executable code changes. It does not touch a manifest, workflow, trust control, hook or standing instruction. The removed comments are descriptive banners only. The surviving fixture-helper comment is kept as is, and none of them state a rule or a guard.

critical-findings: 0

@github-actions

Copy link
Copy Markdown

claude-review reviewed 49ea734e2e9c91e4f229187e6eb45b0150c7f87c: 0 finding(s), 0 as inline comments.

No findings.

The PR deletes 11 // --- ... --- section-divider banners (21 lines) from plugins/plugin-ops/skills/verify-plugin/scripts/validate-marketplace.test.mjs. I read the full diff and every hunk is a comment-only or blank-line deletion, so no test or code token changes.

  • REVIEW.md rule on deleted "why" comments: it flags a deleted comment only when that comment recorded the reason for a decision. These banners only label the test groups below them, so the rule does not apply. The rationale comment under the first banner ("Each helper owns exactly one layer…") is kept.
  • Closing issue: the PR uses Refs: melodic-software/control-hub#12. It closes no issue, so there are no acceptance criteria to check.
  • Plugin manifests: none changed.
  • Loosened checks: no verdict lines came from the wrapper, so I used fail with no consumer entries, and the citation requirement was not checked. Nothing in the diff loosens a check.
  • Verification: I did not run npm test or npm run validate. The PR's CI claims are the author's and I did not confirm them.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton merged commit 67aa48c into main Nov 21, 2026
8 checks passed
@kyle-sexton
kyle-sexton deleted the chore/remove-unnecessary-comments branch November 21, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant